From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 105BD160 for ; Mon, 18 Dec 2017 14:41:02 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2017 05:41:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,422,1508828400"; d="scan'208";a="187993187" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga006.fm.intel.com with ESMTP; 18 Dec 2017 05:41:00 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.49]) by IRSMSX154.ger.corp.intel.com ([169.254.12.83]) with mapi id 14.03.0319.002; Mon, 18 Dec 2017 13:40:57 +0000 From: "Singh, Jasvinder" To: "Kovacevic, Marko" , "dev@dpdk.org" CC: "Iremonger, Bernard" Thread-Topic: [dpdk-dev] [PATCH v3 4/4] doc: update documentation for flow classify lib Thread-Index: AQHTdY9OafFLcd0br0meXCJw07pZm6NI9PIAgAArTcA= Date: Mon, 18 Dec 2017 13:40:56 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D3329F33B@IRSMSX103.ger.corp.intel.com> References: <20171211162646.146936-1-jasvinder.singh@intel.com> <20171215103924.5185-1-jasvinder.singh@intel.com> <20171215103924.5185-4-jasvinder.singh@intel.com> <6DC05C7C5F25994B81B3F2F214251F6632AAEB@IRSMSX104.ger.corp.intel.com> In-Reply-To: <6DC05C7C5F25994B81B3F2F214251F6632AAEB@IRSMSX104.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2JlOTY1MDItMjFiMi00ZDA5LWEwOWItY2NkZTA0MzhmYWU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjNVQ09yYzUxd1JFY1Y2RWtEM1wvam1IMUllZkxLVVR1d1ZtZmVVUlhCdms4PSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 4/4] doc: update documentation for flow classify lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2017 13:41:03 -0000 > -----Original Message----- > From: Kovacevic, Marko > Sent: Monday, December 18, 2017 11:05 AM > To: Singh, Jasvinder ; dev@dpdk.org > Cc: Iremonger, Bernard > Subject: RE: [dpdk-dev] [PATCH v3 4/4] doc: update documentation for flow > classify lib >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh > > Sent: Friday, December 15, 2017 10:39 AM > > To: dev@dpdk.org > > Cc: Iremonger, Bernard > > Subject: [dpdk-dev] [PATCH v3 4/4] doc: update documentation for flow > > classify lib > > > > Updates the documentation for flow classification library and sample > > application. > > > > Signed-off-by: Jasvinder Singh >=20 >=20 > > v3: > > - add validate API desciption to programmers guide >=20 > Small typo desciption/ description >=20 >=20 > > @@ -225,11 +236,16 @@ The ``Classifier`` has the following internal > structures: > > /* Input parameters */ > > char name[RTE_FLOW_CLASSIFIER_MAX_NAME_SZ]; > > int socket_id; > > - enum rte_flow_classify_table_type type; > > > > - /* Internal tables */ > > - struct rte_table tables[RTE_FLOW_CLASSIFY_TABLE_MAX]; > > + /* Internal */ > > + /* ntuple_fliter */ >=20 > Small typo above. Ntuple_fliter/ ntuple_filter. >=20 >=20 > > + struct rte_eth_ntuple_filter ntuple_filter; > > + > > + /* clasifier tables */ >=20 > Same above clasifier / classifier >=20 >=20 > > To create an ACL table the ``rte_table_acl_params`` structure must be > > @@ - > > 314,14 +329,14 @@ and SCTP. > > RTE_FLOW_ITEM_TYPE_END, > > }; > > > > -The internal function ``flow_classify_parse_flow`` parses the > > +The API function ``rte_flow_classify_validate`` parses the > > IPv4 5-tuple pattern, attributes and actions and returns the 5-tuple > > data in the ``rte_eth_ntuple_filter`` structure. > > > > .. code-block:: c > > > > static int > > - flow_classify_parse_flow( > > + rte_flow_classify_validate(struct rte_flow_classifier *cls, > > const struct rte_flow_attr *attr, > > const struct rte_flow_item pattern[], > > const struct rte_flow_action actions[], @@ -333,7 > > +348,7 @@ Adding Flow Rules The ``rte_flow_classify_table_entry_add`` > > API creates an ``rte_flow_classify`` object which contains the > > flow_classify id and type, the action, a union of add and delete keys a= nd a > union of rules. > > -It uses the ``flow_classify_parse_flow`` internal function for > > parsing the > > +It uses the ``rte_flow_classify_validate`` api function for parsing > > +the >=20 > Above api/ API >=20 >=20 > Otherwise everything else seem ok >=20 > Acked-by: Marko Kovacevic >=20 Thanks Marko for review. I will fix them in next version. Jasvinder