From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id BE9AD1B1BE for ; Wed, 3 Jan 2018 11:34:49 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jan 2018 02:34:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,501,1508828400"; d="scan'208";a="7076113" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga008.fm.intel.com with ESMTP; 03 Jan 2018 02:34:47 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.138]) by irsmsx105.ger.corp.intel.com ([163.33.3.28]) with mapi id 14.03.0319.002; Wed, 3 Jan 2018 10:30:53 +0000 From: "Singh, Jasvinder" To: Tomasz Duszynski , "dev@dpdk.org" CC: "Dumitrescu, Cristian" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: set metering algorithm to the correct value Thread-Index: AQHTe0KHtyfaqTTmqkeOguFflYb1xqNiBDgQ Date: Wed, 3 Jan 2018 10:30:52 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D332BC255@IRSMSX103.ger.corp.intel.com> References: <1513960357-26092-1-git-send-email-tdu@semihalf.com> In-Reply-To: <1513960357-26092-1-git-send-email-tdu@semihalf.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2I2YmVmZGQtYWQxMC00MGE3LWI3YzAtNDRmZmNmYTUxNjVmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImV4eUxCbHREczNLaEdCUTBXUThjMEU1bFBic3Jydkw2MTRGOFJKbkRZZUE9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: set metering algorithm to the correct value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jan 2018 10:34:50 -0000 Hi Tomasz, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski > Sent: Friday, December 22, 2017 4:33 PM > To: dev@dpdk.org > Cc: Tomasz Duszynski ; Dumitrescu, Cristian > > Subject: [dpdk-dev] [PATCH] app/testpmd: set metering algorithm to the > correct value >=20 > No meter what option for traffic metering algorithm was given on the > testpmd command line value 0 (RTE_MTR_NONE) was set and passed to the > driver. >=20 > Fix that by setting traffic metering algorithm to the proper value. >=20 > Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and > policing") > Cc: cristian.dumitrescu@intel.com >=20 > Signed-off-by: Tomasz Duszynski > --- > app/test-pmd/cmdline_mtr.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c > index d8d806d..8dad8f8 100644 > --- a/app/test-pmd/cmdline_mtr.c > +++ b/app/test-pmd/cmdline_mtr.c > @@ -171,7 +171,7 @@ static void > cmd_add_port_meter_profile_srtcm_parsed(void *parsed_result, >=20 > /* Private shaper profile params */ > memset(&mp, 0, sizeof(struct rte_mtr_meter_profile)); > - mp.alg =3D 0; > + mp.alg =3D RTE_MTR_SRTCM_RFC2697; > mp.srtcm_rfc2697.cir =3D res->cir; > mp.srtcm_rfc2697.cbs =3D res->cbs; > mp.srtcm_rfc2697.ebs =3D res->ebs; > @@ -277,7 +277,7 @@ static void > cmd_add_port_meter_profile_trtcm_parsed(void *parsed_result, >=20 > /* Private shaper profile params */ > memset(&mp, 0, sizeof(struct rte_mtr_meter_profile)); > - mp.alg =3D 0; > + mp.alg =3D RTE_MTR_TRTCM_RFC2698; > mp.trtcm_rfc2698.cir =3D res->cir; > mp.trtcm_rfc2698.pir =3D res->pir; > mp.trtcm_rfc2698.cbs =3D res->cbs; > @@ -389,7 +389,7 @@ static void > cmd_add_port_meter_profile_trtcm_rfc4115_parsed( >=20 > /* Private shaper profile params */ > memset(&mp, 0, sizeof(struct rte_mtr_meter_profile)); > - mp.alg =3D 0; > + mp.alg =3D RTE_MTR_TRTCM_RFC4115; > mp.trtcm_rfc4115.cir =3D res->cir; > mp.trtcm_rfc4115.eir =3D res->eir; > mp.trtcm_rfc4115.cbs =3D res->cbs; > -- > 2.7.4 The above fix is already addressed in the patch( https://dpdk.org/dev/patch= work/patch/31486/ ) which is under review. Thanks, Jasvinder