From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0CA1A1B169 for ; Wed, 10 Jan 2018 12:12:47 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2018 03:12:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,339,1511856000"; d="scan'208";a="9619237" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga008.jf.intel.com with ESMTP; 10 Jan 2018 03:12:45 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.138]) by IRSMSX109.ger.corp.intel.com ([169.254.13.28]) with mapi id 14.03.0319.002; Wed, 10 Jan 2018 11:12:44 +0000 From: "Singh, Jasvinder" To: Thomas Monjalon CC: "dev@dpdk.org" , "Iremonger, Bernard" , "Kovacevic, Marko" Thread-Topic: [dpdk-dev] [PATCH v4 1/4] lib/librte_flow_classify: remove table id parameter from apis Thread-Index: AQHTiajMY0bLWKBc20iRpRwfy5A1CqNs3Z/ggAARWwCAAAEZEIAAAvqAgAAAWbA= Date: Wed, 10 Jan 2018 11:12:43 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D332C3EBE@IRSMSX103.ger.corp.intel.com> References: <20171215103924.5185-1-jasvinder.singh@intel.com> <2144605.X1J6VfJWv8@xps> <54CBAA185211B4429112C315DA58FF6D332C3E9C@IRSMSX103.ger.corp.intel.com> <2597712.le8lxF3Odu@xps> In-Reply-To: <2597712.le8lxF3Odu@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjllY2U3ZWUtN2Q0NS00Zjc3LWFlNDUtOTM4OWMwMzhhMzRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjdQbHVUaW9aellxR3JpVDRQK3hYeGFUODFvZlZPaEZRUkczUTdsRWpcL0VRPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/4] lib/librte_flow_classify: remove table id parameter from apis X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 11:12:48 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, January 10, 2018 11:07 AM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Iremonger, Bernard ; > Kovacevic, Marko > Subject: Re: [dpdk-dev] [PATCH v4 1/4] lib/librte_flow_classify: remove t= able > id parameter from apis >=20 > 10/01/2018 11:59, Singh, Jasvinder: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 10/01/2018 10:54, Singh, Jasvinder: > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > > 19/12/2017 15:29, Jasvinder Singh: > > > > > > This patch removes table id parameter from all the flow > > > > > > classify apis to reduce the complexity alongwith some code clea= nup. > > > > > > > > > > > > The validate api is exposed as public api to allow user to > > > > > > validate the flow before adding it to the classifier. > > > > > > > > > > This patch does not compile alone. > > > > > Should we merge all patches together? > > > > > > > > No, It should compile alone. On my system it doesn't show any > > > > error and > > > compilation goes successfully. Could you send me error log, etc ? > > > > > > test/test/test_flow_classify.c:48:10: fatal error: too many arguments= to > > > function call, expected 6, have 7 > > > NULL, NULL); > > > ^~~~ > > > > > > I guess it is expected that test and example does not compile after p= atch > 1. > > > That's why I suggest to merge all 4 patches. > > > > Ok, I will send revised patch with all merged into one. >=20 > I can merge them myself, it is fine. Much Appreciated! Thank you.=20