From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 75EAB2D13 for ; Fri, 12 Jan 2018 14:07:40 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jan 2018 05:07:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,348,1511856000"; d="scan'208";a="194340511" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga005.fm.intel.com with ESMTP; 12 Jan 2018 05:07:36 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by irsmsx110.ger.corp.intel.com (163.33.3.25) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 12 Jan 2018 13:07:35 +0000 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.138]) by irsmsx111.ger.corp.intel.com ([169.254.2.30]) with mapi id 14.03.0319.002; Fri, 12 Jan 2018 13:07:35 +0000 From: "Singh, Jasvinder" To: "Dumitrescu, Cristian" , Tomasz Duszynski , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table Thread-Index: AQHTiuMS0mKYL3JloEywWrHgQ5bbGKNu/5cAgAE2bhA= Date: Fri, 12 Jan 2018 13:07:34 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D332C7149@IRSMSX103.ger.corp.intel.com> References: <1515678563-13424-1-git-send-email-tdu@semihalf.com> <3EB4FA525960D640B5BDFFD6A3D891267BAFBFA4@IRSMSX108.ger.corp.intel.com> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891267BAFBFA4@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWVhOTgwZTAtZTA0MC00N2ZkLWFmYjctMDRlYWE5YTdjNzg5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InZLXC8wZkk2SXE0YktMREQ3QU82SUJcL0s5WHFOQjk3elF3Qk9qZ1UyUmVIUT0ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 13:07:41 -0000 > -----Original Message----- > From: Dumitrescu, Cristian > Sent: Thursday, January 11, 2018 6:34 PM > To: Tomasz Duszynski ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Singh, Jasvinder > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions > table >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski > > Sent: Thursday, January 11, 2018 1:49 PM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo ; Wu, Jingjing > > ; Tomasz Duszynski > > Subject: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions > > table > > > > Since METER action is supported by the testpmd application suitable > > entry should exist in flow actions information table. > > > > Without that testpmd will return error on adding a new flow to the > > list of flows attached to a given port. > > > > Signed-off-by: Tomasz Duszynski > > --- > > app/test-pmd/config.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > > 0a84481..4ad19fb 100644 > > --- a/app/test-pmd/config.c > > +++ b/app/test-pmd/config.c > > @@ -1038,6 +1038,7 @@ static const struct { > > MK_FLOW_ACTION(RSS, sizeof(struct rte_flow_action_rss)), /* > > +queue[] */ > > MK_FLOW_ACTION(PF, 0), > > MK_FLOW_ACTION(VF, sizeof(struct rte_flow_action_vf)), > > + MK_FLOW_ACTION(METER, sizeof(struct rte_flow_action_meter)), > > }; > > > > /** Compute storage space needed by action configuration. */ > > -- > > 2.7.4 >=20 > Adding Jasvinder to this thread. The above change looks fine to me. Acked-by: Jasvinder Singh =20