From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D44551B81F for ; Mon, 9 Apr 2018 16:51:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2018 07:51:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,427,1517904000"; d="scan'208";a="45416692" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga001.fm.intel.com with ESMTP; 09 Apr 2018 07:51:11 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.176]) by IRSMSX102.ger.corp.intel.com ([169.254.2.164]) with mapi id 14.03.0319.002; Mon, 9 Apr 2018 15:51:11 +0100 From: "Singh, Jasvinder" To: "Richardson, Bruce" CC: "dev@dpdk.org" , "Dumitrescu, Cristian" Thread-Topic: [dpdk-dev] [PATCH] table: fix build error with gcc 8 Thread-Index: AQHT0AFNTQ9pmruvZkyB+qkMVw0GuKP4VxeAgAAsv2A= Date: Mon, 9 Apr 2018 14:51:10 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D33334FB8@IRSMSX101.ger.corp.intel.com> References: <20180409124948.130974-1-jasvinder.singh@intel.com> <20180409130902.GA129412@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20180409130902.GA129412@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDJlNmY5YjMtNjg2OC00YzRjLTlmZTAtMDBkMTI4NTlmMjc5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkxTeEgwZXFMQ0xwaVwvcUdiXC9ydmtkcjN2ZHg1SlVySFFkSnd3emJqVTliRT0ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] table: fix build error with gcc 8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 14:51:15 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Monday, April 9, 2018 2:09 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH] table: fix build error with gcc 8 >=20 > On Mon, Apr 09, 2018 at 01:49:48PM +0100, Jasvinder Singh wrote: > > Fix build error with gcc 8.0 due to cast between function types. > > Fixes: 5a80bf0ae613 ("table: add cuckoo hash") > > > > Signed-off-by: Jasvinder Singh >=20 > What's the actual error message? Why do the types not match? >=20 > /Bruce =20 Error log is captured below; CC rte_table_hash_cuckoo.o /librte_table/rte_table_hash_cuckoo.c: In function 'rte_table_hash_cuckoo_c= reate': /librte_table/rte_table_hash_cuckoo.c:110:16: error: cast between incompati= ble function types from 'rte_table_hash_op_hash' {aka 'long unsigned int (*)(v= oid *, void *, unsigned int, long unsigned int)'} to 'uint32_t (*)(const void *, uint32_t, uint32_t)' {aka 'unsigned int (*= )(const void *, unsigned int, unsigned int)'} [-Werror=3Dcast-function-typ= e] .hash_func =3D (rte_hash_function) p->f_hash, ^ cc1: all warnings being treated as errors