From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 91CEA1B8D7 for ; Tue, 10 Apr 2018 11:53:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2018 02:53:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,431,1517904000"; d="scan'208";a="35959366" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga002.fm.intel.com with ESMTP; 10 Apr 2018 02:53:10 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.176]) by IRSMSX108.ger.corp.intel.com ([169.254.11.155]) with mapi id 14.03.0319.002; Tue, 10 Apr 2018 10:53:09 +0100 From: "Singh, Jasvinder" To: Thomas Monjalon CC: "dev@dpdk.org" , "Dumitrescu, Cristian" Thread-Topic: [dpdk-dev] [PATCH] examples/ip_pipeline: fix freebsd build error Thread-Index: AQHTz/tH52coCfuYc0+WpMr/RcQ6oaP49QwAgADOFYA= Date: Tue, 10 Apr 2018 09:53:09 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D33336104@IRSMSX101.ger.corp.intel.com> References: <20180409120632.38567-1-jasvinder.singh@intel.com> <1876749.P1BhTyUkUM@xps> In-Reply-To: <1876749.P1BhTyUkUM@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTAzYzRkMzctMDdmNS00NGJlLTk0ZjctNGY3MjViM2Y0ZGMzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImlqQ1hOZGViSDg3YmVOZEk3MVBtSENOWkQ2MDhqc3B5aXd3RE05cW1CZVU9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix freebsd build error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 09:53:13 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, April 9, 2018 11:34 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix freebsd build e= rror >=20 > 09/04/2018 14:06, Jasvinder Singh: > > IP_Pipeline app is not supported in FreeBSD environment. Therefore, > > skip it while building the sample apps on FreeBSD. > > > > Fixes: 4bbf8e30aa5e ("examples/ip_pipeline: add CLI interface") > > Fixes: 2f74ae28e23f ("examples/ip_pipeline: add tap object") > > > > Signed-off-by: Jasvinder Singh > > --- > > --- a/examples/ip_pipeline/Makefile > > +++ b/examples/ip_pipeline/Makefile > > +ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp") > > +$(error This application can only operate in a linuxapp environment, > > +\ please change the definition of the RTE_TARGET environment > > +variable) endif >=20 > It is not skipping the example, just throwing an error (which is needed). >=20 > You should add a test in examples/Makefile to really skip it. >=20 Pushed v2 that allows skipping the ip pipeline app on FreeBSD.Thanks.=20