From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id F257E1B97B for ; Tue, 10 Apr 2018 12:25:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2018 03:25:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,431,1517904000"; d="scan'208";a="40855889" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by FMSMGA003.fm.intel.com with ESMTP; 10 Apr 2018 03:25:50 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.176]) by IRSMSX153.ger.corp.intel.com ([169.254.9.3]) with mapi id 14.03.0319.002; Tue, 10 Apr 2018 11:25:50 +0100 From: "Singh, Jasvinder" To: Thomas Monjalon CC: "dev@dpdk.org" , "Dumitrescu, Cristian" Thread-Topic: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix freebsd build error Thread-Index: AQHT0LGkE1vh8G+pME6tM3uzwUSaOKP5t3MAgAASVIA= Date: Tue, 10 Apr 2018 10:25:50 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D333361C4@IRSMSX101.ger.corp.intel.com> References: <20180409120632.38567-1-jasvinder.singh@intel.com> <20180410095132.130232-1-jasvinder.singh@intel.com> <50779258.T1JUn8BQf7@xps> In-Reply-To: <50779258.T1JUn8BQf7@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmE2MTc0Y2ItZDZlZS00Nzk4LTgxNTAtMzQzNGMyOWU5ZTU0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlwvYklNb0RXSnRtVGk2dituWFRwVE82YmVoZmZWbmVSTmFQVU9vVU5sSk1NPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix freebsd build error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 10:25:54 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, April 10, 2018 11:15 AM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix freebsd buil= d > error >=20 > 10/04/2018 11:51, Jasvinder Singh: > > IP_Pipeline app is not supported in FreeBSD environment. Therefore, > > skip it while building the sample apps on FreeBSD. > [...] > > --- a/examples/ip_pipeline/Makefile > > +++ b/examples/ip_pipeline/Makefile > > @@ -67,6 +67,13 @@ RTE_TARGET ?=3D x86_64-native-linuxapp-gcc > > > > include $(RTE_SDK)/mk/rte.vars.mk > > > > +ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp") >=20 > You can use CONFIG_RTE_EXEC_ENV_LINUXAPP >=20 > > +$(info This application can only operate in a linuxapp environment, \ > > +please change the definition of the RTE_TARGET environment variable) > > +all: > > +clean: > > +else >=20 >=20 > Copy of my previous comment: > " > It is not skipping the example, just throwing an error (which is needed). >=20 > You should add a test in examples/Makefile to really skip it. > " In V2, we follow the same pattern as followed in other examples such as l3f= wd-power, ethtool, etc. If we put check in examples/Makefile, than how the situation is handled if = someone tries to build ip_pipeline straight instead of building all example= s.=20 > In this v2, you replaced the error by an info message. > Error was better in my opinion. >=20 >=20