From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 1B08A7CEA for ; Thu, 19 Apr 2018 10:37:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2018 01:37:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,468,1517904000"; d="scan'208";a="43054746" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by FMSMGA003.fm.intel.com with ESMTP; 19 Apr 2018 01:37:27 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.176]) by IRSMSX102.ger.corp.intel.com ([169.254.2.164]) with mapi id 14.03.0319.002; Thu, 19 Apr 2018 09:37:26 +0100 From: "Singh, Jasvinder" To: "Pattan, Reshma" , "dev@dpdk.org" Thread-Topic: [PATCH] examples/ip_pipeline: fixes uninitialized scalar variable Thread-Index: AQHT1zb1+ahF8/0gl0CUFXmSL+47aaQHxMww Date: Thu, 19 Apr 2018 08:37:26 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D333419A2@IRSMSX101.ger.corp.intel.com> References: <1524070690-12000-1-git-send-email-reshma.pattan@intel.com> In-Reply-To: <1524070690-12000-1-git-send-email-reshma.pattan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzUyN2UxMDktNmU1Ni00YWJiLWIyNWItYTdlNzhjNTNkN2YyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ijl1UkErbWN5dlphSlwvemFDd3R6STRyZ1dOSmt4a2d6Mk9vS0M4XC9nWG90TT0ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fixes uninitialized scalar variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 08:37:29 -0000 > -----Original Message----- > From: Pattan, Reshma > Sent: Wednesday, April 18, 2018 5:58 PM > To: dev@dpdk.org > Cc: Singh, Jasvinder ; Pattan, Reshma > > Subject: [PATCH] examples/ip_pipeline: fixes uninitialized scalar variabl= e >=20 > Using uninitialized value p.thread_id when calling kni_create. > Initialize the kni_params object to 0. >=20 > Coverity issue: 272569 > Fixes: 9a408cc8ac ("examples/ip_pipeline: add KNI object") > CC: jasvinder.singh@intel.com >=20 > Signed-off-by: Reshma Pattan > --- > examples/ip_pipeline/cli.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c inde= x > 199a31ff8..575e176c1 100644 > --- a/examples/ip_pipeline/cli.c > +++ b/examples/ip_pipeline/cli.c > @@ -651,6 +651,7 @@ cmd_kni(char **tokens, > char *name; > struct kni *kni; >=20 > + memset(&p, 0, sizeof(p)); > if ((n_tokens !=3D 6) && (n_tokens !=3D 8)) { > snprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]); > return; > -- > 2.14.3 Reviewed-by: Jasvinder Singh