From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 090F0A045E for ; Fri, 31 May 2019 16:45:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D8FC61B94E; Fri, 31 May 2019 16:45:39 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 101451B948; Fri, 31 May 2019 16:45:37 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 May 2019 07:45:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,535,1549958400"; d="scan'208";a="180349970" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga002.fm.intel.com with ESMTP; 31 May 2019 07:45:36 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.10]) by IRSMSX154.ger.corp.intel.com ([169.254.12.120]) with mapi id 14.03.0415.000; Fri, 31 May 2019 15:45:35 +0100 From: "Singh, Jasvinder" To: "Wang, Xiao W" CC: "dev@dpdk.org" , "Dumitrescu, Cristian" , "stable@dpdk.org" Thread-Topic: [PATCH] net/softnic: fix pipeline time calculation Thread-Index: AQHVCyi6UmdcTXmd0UClQvhTlQBuMqaFWzZg Date: Fri, 31 May 2019 14:45:35 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D3FD15433@IRSMSX101.ger.corp.intel.com> References: <20190515135904.81415-1-xiao.w.wang@intel.com> In-Reply-To: <20190515135904.81415-1-xiao.w.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzkyNjU0OTMtYmZiZS00NzJkLWFlZDQtMmI5MGUwNzFhNzkzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibUlwTXhuQnI3UEZXMVJiTndnUndidUlDcjBhK25WYmdsSHVuYmZ2d3NLcGV0ZElGTzlUc1NsTVNSZU93Y0RGKyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/softnic: fix pipeline time calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, Xiao W > Sent: Wednesday, May 15, 2019 2:59 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian ; > Wang, Xiao W ; stable@dpdk.org > Subject: [PATCH] net/softnic: fix pipeline time calculation >=20 > When a new pipeline is added to a thread, the "time_next_min" value may > need update, otherwise this pipeline won't get served timely. >=20 > Fixes: 70709c78fda6 ("net/softnic: add command to enable/disable pipeline= ") > Cc: stable@dpdk.org >=20 > Signed-off-by: Xiao Wang > --- > drivers/net/softnic/rte_eth_softnic_thread.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/drivers/net/softnic/rte_eth_softnic_thread.c > b/drivers/net/softnic/rte_eth_softnic_thread.c > index 855408e98..2b482117d 100644 > --- a/drivers/net/softnic/rte_eth_softnic_thread.c > +++ b/drivers/net/softnic/rte_eth_softnic_thread.c > @@ -337,6 +337,9 @@ softnic_thread_pipeline_enable(struct pmd_internals > *softnic, > tdp->timer_period =3D (rte_get_tsc_hz() * p->timer_period_ms) / > 1000; > tdp->time_next =3D rte_get_tsc_cycles() + tdp->timer_period; >=20 > + if (tdp->time_next < td->time_next_min) > + td->time_next_min =3D tdp->time_next; > + > td->n_pipelines++; >=20 > /* Pipeline */ > @@ -522,6 +525,9 @@ thread_msg_handle_pipeline_enable(struct > softnic_thread_data *t, > (rte_get_tsc_hz() * req->pipeline_enable.timer_period_ms) / > 1000; > p->time_next =3D rte_get_tsc_cycles() + p->timer_period; >=20 > + if (p->time_next < t->time_next_min) > + t->time_next_min =3D p->time_next; > + > t->n_pipelines++; >=20 > /* Response */ > -- > 2.15.1 Hi Wang,=20 Timer values for pipelines and thread level message handlers are already ad= justed in runtime function rte_pmd_softnic_run_internal(). In runtime funct= ion, the values of t->time_next_min is updated as well. IMO, above changes = not needed. Could you help with the case where timer adjustments in runtime= not working? Thanks, Jasvinder =20