From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jasvinder.singh@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 8A591952
 for <dev@dpdk.org>; Thu,  2 Mar 2017 14:03:25 +0100 (CET)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 02 Mar 2017 05:03:24 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.35,231,1484035200"; d="scan'208";a="63570560"
Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25])
 by orsmga004.jf.intel.com with ESMTP; 02 Mar 2017 05:03:23 -0800
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.77]) by
 irsmsx110.ger.corp.intel.com ([169.254.15.101]) with mapi id 14.03.0248.002;
 Thu, 2 Mar 2017 13:03:22 +0000
From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Doherty, Declan" <declan.doherty@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute
 APIs
Thread-Index: AQHSkboMXqgP22+Bv0OSvtdSbE5ifKGAVNKAgAEoiOA=
Date: Thu, 2 Mar 2017 13:03:21 +0000
Message-ID: <54CBAA185211B4429112C315DA58FF6DF9103A@IRSMSX103.ger.corp.intel.com>
References: <1487969657-172541-2-git-send-email-jasvinder.singh@intel.com>
 <1488283701-186162-1-git-send-email-jasvinder.singh@intel.com>
 <1488283701-186162-2-git-send-email-jasvinder.singh@intel.com>
 <1924972.0cHYGgSmY3@xps13>
In-Reply-To: <1924972.0cHYGgSmY3@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWNiYmJlMjgtYTFjNS00YWNlLWI5ZTEtMzE0ZjY5NzkwMmQzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IktIdWRpUVcwWlBNTkxZWUV6dWRuRm5GbTRyM1pqWmtvcUdTYkVJVlFtY289In0=
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute
 APIs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Mar 2017 13:03:25 -0000

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, March 1, 2017 6:46 PM
> To: Singh, Jasvinder <jasvinder.singh@intel.com>
> Cc: dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compu=
te
> APIs
>=20
> 2017-02-28 12:08, Jasvinder Singh:
> >  lib/librte_net/rte_net_crc.c       | 664
> +++++++++++++++++++++++++++++++++++++
> >  lib/librte_net/rte_net_crc.h       | 101 ++++++
>=20
> I think it should be in librte_hash.
>=20
> Please check lib/librte_hash/rte_hash_crc.h

Is it good to include payload crc calculation in hash library as I see all =
hash related functionality there?