From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com
 [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 6E2235936
 for <dev@dpdk.org>; Tue, 10 Feb 2015 17:54:33 +0100 (CET)
Received: by mail-wi0-f169.google.com with SMTP id z2so14483113wiv.0
 for <dev@dpdk.org>; Tue, 10 Feb 2015 08:54:33 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :cc:subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=d0hrXuL2i5wk67FH3E0Fbx8L04F+kp70cPixegQbs6U=;
 b=CQa551q8uv2+UuhZaod0y/kbvKcbYdxPaLjBUVcHGlRS45rYdEE287Y6gfaofdrd/I
 Jxz5A+nNFlBe9fxDtdAe2ZtRtB75tt2YetEM4tOYx01UYyA+1p1uTnOt0xRTPK8nNMAp
 c2ElJ8jBiLZWZBwfNCm+rXYKc0kIYTtbdHZELMuMneFlK+btuS9R8UEF1sS4gabztrel
 Bn4LoT+HkjYHKK4nkFrertVC9E52VqeP7wzZbiec55v5F4EbruziOLN88rT5AK7iQCIR
 ky0vvpqaIFb37FHn8eXiahM/vcV1U7VitPy8ZH0WsGBr75/5TQ9EXYBAd91x5k8KE0me
 CWFw==
X-Gm-Message-State: ALoCoQk9VPA9LhchMisMHYBp4tC1SgvMFUu5rqYcsCdmlrRHkof2l9VH28rz6IdmJW+SIDmivlO3
X-Received: by 10.180.149.242 with SMTP id ud18mr11645049wib.94.1423587273303; 
 Tue, 10 Feb 2015 08:54:33 -0800 (PST)
Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id qo10sm19995807wjc.38.2015.02.10.08.54.31
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 10 Feb 2015 08:54:32 -0800 (PST)
Message-ID: <54DA37C7.6080603@6wind.com>
Date: Tue, 10 Feb 2015 17:54:31 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.2.0
MIME-Version: 1.0
To: "Zhang, Helin" <helin.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
References: <1422623775-8050-1-git-send-email-olivier.matz@6wind.com>
 <1423041925-26956-1-git-send-email-olivier.matz@6wind.com>
 <1423041925-26956-3-git-send-email-olivier.matz@6wind.com>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A806563@SHSMSX104.ccr.corp.intel.com>
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A806563@SHSMSX104.ccr.corp.intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 02/20] mbuf: enhance the API documentation
 of offload flags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Feb 2015 16:54:33 -0000

Hi Helin,

On 02/10/2015 06:38 AM, Zhang, Helin wrote:
>> -/** Packet is IPv4 without requiring IP checksum offload. */
>> +/**
>> + * Packet is IPv4. This flag must be set when using any offload feature
>> + * (TSO, L3 or L4 checksum) to tell the NIC that the packet is an IPv4
>> + * packet.
>> + */
>>   #define PKT_TX_IPV4          (1ULL << 55)
>>
>> -/** Tell the NIC it's an IPv6 packet.*/
>> +/**
>> + * Packet is IPv6. This flag must be set when using an offload feature
>> + * (TSO or L4 checksum) to tell the NIC that the packet is an IPv6
>> + * packet.
>> + */
>>   #define PKT_TX_IPV6          (1ULL << 56)
> Above two macro for IPV4/IPV6 will be used for inner L3 for tunneling case, right?
> If yes, the annotations may need to mention that, to avoid confusing end users.

That's right, I'll clarify this in a next version.

Thanks
Olivier