From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 38B439A81 for ; Wed, 11 Feb 2015 12:25:44 +0100 (CET) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1BBPgFQ012788 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 11 Feb 2015 06:25:42 -0500 Received: from localhost.localdomain (vpn1-7-166.ams2.redhat.com [10.36.7.166]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1BBPfmj011237; Wed, 11 Feb 2015 06:25:42 -0500 Message-ID: <54DB3C35.9000104@redhat.com> Date: Wed, 11 Feb 2015 13:25:41 +0200 From: Panu Matilainen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "Gonzalez Monroy, Sergio" , "dev@dpdk.org" References: <6ca22ee1257e34ee2b89f2fb354d6c382b8f3e29.1423644785.git.pmatilai@redhat.com> <91383E96CE459D47BCE92EFBF5CE73B004F4AB6C@IRSMSX108.ger.corp.intel.com> In-Reply-To: <91383E96CE459D47BCE92EFBF5CE73B004F4AB6C@IRSMSX108.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Subject: Re: [dpdk-dev] [PATCH] mk: fix missing link of librte_vhost in shared, non-combined config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 11:25:44 -0000 On 02/11/2015 12:51 PM, Gonzalez Monroy, Sergio wrote: > Hi Panu, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen >> Sent: Wednesday, February 11, 2015 8:53 AM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH] mk: fix missing link of librte_vhost in shared, >> non-combined config >> >> When building shared, non-combined library, librte_vhost does not get >> linked in, causing among other things vhost example to fail building to do >> undefined symbols on linkage. >> >> Signed-off-by: Panu Matilainen >> --- >> mk/rte.app.mk | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 95dbb0b..55d989e 100644 >> --- a/mk/rte.app.mk >> +++ b/mk/rte.app.mk >> @@ -125,6 +125,10 @@ LDLIBS += -lm >> LDLIBS += -lrt >> endif >> >> +ifeq ($(CONFIG_RTE_LIBRTE_VHOST), y) >> +LDLIBS += -lrte_vhost >> +endif >> + >> endif # ! CONFIG_RTE_BUILD_COMBINE_LIBS >> >> ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y) >> -- >> 2.1.0 > > I think that vhost is being linked in the wrong place (plugins section). > The plugins only get linked when building static libraries. > I think the patch should also remove vhost from the plugins section. Right, so vhost isn't a pluggable driver in the sense that pmds are. I wont claim to be familiar with all this virt-related puzzle pieces :) I'll send an updated patch, I was just looking to fix build in my particular config and ignored the rest. On a related note, shouldn't librte_pmd_bond and librte_pmd_xenvirt be included in the plugins section along with all the other pmds? - Panu -