From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-we0-f179.google.com (mail-we0-f179.google.com
 [74.125.82.179]) by dpdk.org (Postfix) with ESMTP id 27D20B515
 for <dev@dpdk.org>; Thu, 19 Feb 2015 10:20:59 +0100 (CET)
Received: by wesp10 with SMTP id p10so6096368wes.2
 for <dev@dpdk.org>; Thu, 19 Feb 2015 01:20:59 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=0nUPytpj++Vb83ZZiNtHjT7TFuL9tQTAWtJYxyArjvY=;
 b=ZqcYbCQMXQ+uynTBplp7IQmY+dLEmHdqh48IF7gj10f5Q9L2ucd+vLdHHUfpLA+gS7
 YjCeB6qEAZRc2xk2u3O/NRR29fD1NDkr8bi5Ec2hYQEneJCkyCD/5CS8V/I7mcHJxvpv
 Kkga6wStex1Rs/Dhv69PDF58xmdcPQBpinc+zBCbYz/YSd8w2dj9hFrufwsdjvaiMoGa
 +uCr1SE7YKAwDCcMLlvcsQ7LsKBeHNKAaqYr8+rHX+9fFK1Rpu111pxKOQFQtbs4tPKx
 GMcWxTUG7s+xTB8gwrj/FBJZ01Wf7RpoD7vgEIjQcgO4fjQ75MP0+40aW+VvGPiyV+Z8
 73LQ==
X-Gm-Message-State: ALoCoQmYEoTirO1mVhncNrNEHYAemYxihqK5i3cpSXV4iyDIkOkk2YI3LrU4zC6D+Vs3VqMOZJDS
X-Received: by 10.194.77.133 with SMTP id s5mr7219384wjw.71.1424337658970;
 Thu, 19 Feb 2015 01:20:58 -0800 (PST)
Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id e18sm36489290wjz.27.2015.02.19.01.20.58
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 19 Feb 2015 01:20:58 -0800 (PST)
Message-ID: <54E5AAF9.9010705@6wind.com>
Date: Thu, 19 Feb 2015 10:20:57 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.2.0
MIME-Version: 1.0
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>, 
 dev@dpdk.org
References: <1423660055-23920-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <1424271498-23583-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <1424271498-23583-2-git-send-email-sergio.gonzalez.monroy@intel.com>
In-Reply-To: <1424271498-23583-2-git-send-email-sergio.gonzalez.monroy@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v5 1/6] reorder: new reorder library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Feb 2015 09:20:59 -0000

Hi Sergio,

On 02/18/2015 03:58 PM, Sergio Gonzalez Monroy wrote:
> This library provides reordering capability for out of order mbufs based
> on a sequence number in the mbuf structure.
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> Signed-off-by: Richardson Bruce <bruce.richardson@intel.com>
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
>
> [...]
>
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -289,6 +289,9 @@ struct rte_mbuf {
>   		uint32_t usr;	  /**< User defined tags. See @rte_distributor_process */
>   	} hash;                   /**< hash information */
>
> +	/* sequence number - field used in distributor and reorder library */
> +	uint32_t seqn;
> +
>   	/* second cache line - fields only used in slow path or on TX */
>   	MARKER cacheline1 __rte_cache_aligned;
>

Just one small comment about rte_mbuf: the comment should be in doxygen
style.


Regards,
Olivier