From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 84054B5B2 for ; Thu, 19 Feb 2015 13:37:11 +0100 (CET) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1JCbAsF002743 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 19 Feb 2015 07:37:10 -0500 Received: from localhost.localdomain (vpn1-6-118.ams2.redhat.com [10.36.6.118]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1JCb9Rj000902; Thu, 19 Feb 2015 07:37:09 -0500 Message-ID: <54E5D8F4.9000305@redhat.com> Date: Thu, 19 Feb 2015 14:37:08 +0200 From: Panu Matilainen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "Ananyev, Konstantin" , "dev@dpdk.org" References: <2601191342CEEE43887BDE71AB977258213F0CA8@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB977258213F0CA8@irsmsx105.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix build with gcc 5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 12:37:12 -0000 On 02/19/2015 02:02 PM, Ananyev, Konstantin wrote: > Hi Panu, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen >> Sent: Thursday, February 19, 2015 10:25 AM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH] ixgbe: fix build with gcc 5 >> >> Add extra parenthesis to remove ambiguity on what we want to compare, >> otherwise gcc 5 issues a "logical not is only applied to the left hand >> side of comparison" warning which with -Werror fails the build. >> >> Signed-off-by: Panu Matilainen >> --- >> lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c >> index 37e5bae..93a6a00 100644 >> --- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c >> +++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c >> @@ -2898,8 +2898,8 @@ STATIC s32 ixgbe_fc_autoneg_fiber(struct ixgbe_hw *hw) >> */ >> >> linkstat = IXGBE_READ_REG(hw, IXGBE_PCS1GLSTA); >> - if ((!!(linkstat & IXGBE_PCS1GLSTA_AN_COMPLETE) == 0) || >> - (!!(linkstat & IXGBE_PCS1GLSTA_AN_TIMED_OUT) == 1)) { >> + if (((!!(linkstat & IXGBE_PCS1GLSTA_AN_COMPLETE)) == 0) || >> + ((!!(linkstat & IXGBE_PCS1GLSTA_AN_TIMED_OUT)) == 1)) { >> ERROR_REPORT1(IXGBE_ERROR_POLLING, >> "Auto-Negotiation did not complete or timed out"); >> goto out; > > Unfortunately we are not supposed to change files under ixgbe subfirectory (except ixgbe_osdep.*). Oh, sorry about that, I didn't realize there were untouchable files in the repo. Its not a very common setup :) > Usually we deal with it just by: > If GCC_VERSION... > CFLAGS_ixgbe_common.o += -Wno... > > You can have a look at lib/librte_pmd_ixgbe/Makefile, there are plenty of such things. Yup, noticed that but assumed the warning disablers were mainly for things that are not trivial to fix. This one can be worked around just as easily with -Wlogical-not-parentheses, but since this flag is new to gcc 5 it can't really be added until gcc 5 is recognized as a supported version by the makefiles: http://dpdk.org/dev/patchwork/patch/3452/ I'll send an updated version using warning disabler once other gcc-5 support goes in. - Panu -