From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 673181B237;
 Fri, 10 Nov 2017 09:55:14 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga104.jf.intel.com with ESMTP; 10 Nov 2017 00:55:13 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,373,1505804400"; 
   d="scan'208";a="497570"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.21.79])
 ([10.254.21.79])
 by FMSMGA003.fm.intel.com with ESMTP; 10 Nov 2017 00:55:10 -0800
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Alejandro Lucero <alejandro.lucero@netronome.com>, dev@dpdk.org,
 stable@dpdk.org
References: <1510142385-23710-1-git-send-email-alejandro.lucero@netronome.com>
 <15bd63fc-1c14-faae-ac09-b94375fb1553@intel.com>
 <20171110130554.3e491e70@shemminger-XPS-13-9360>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <54a78672-5676-49d4-245c-47ac1ee75a4d@intel.com>
Date: Fri, 10 Nov 2017 00:55:09 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171110130554.3e491e70@shemminger-XPS-13-9360>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] net/nfp: initialize stats struct
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Nov 2017 08:55:14 -0000

On 11/9/2017 8:05 PM, Stephen Hemminger wrote:
> On Thu, 9 Nov 2017 17:10:16 -0800
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
>> On 11/8/2017 3:59 AM, Alejandro Lucero wrote:
>>> Not all struct fields will be written and random data could
>>> confuse readers.
>>>
>>> Fixes: 92aa491b881e ("nfp: add statistics")
>>> Coverity: 140755  
>>
>> Hi Alejandro,
>>
>> Thank you for coverity fixes, but they will be considered for next release,
>> since trying to limit rc4 only for critical fixes.
>>
>> Thanks,
>> ferruh
>>
>>>
>>> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>  
>>
> 
> This looks like a bug fix. because the stats are on the stack and will
> be garbage.

Yes it is, also other nfp patches are fixes.

This is for an effort to close the release, eventually it needs to stop
somewhere, and technically after rc3 is only for critical bug fixes, so this is
the time for stop getting these kind of patches.

After above said, relying on scope of the patches are PMD only and patches are
sent by driver maintainers, I will get them, reminding Thomas' right to drop
them back if he disagrees.