From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5436AA04B5; Wed, 30 Sep 2020 09:49:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7DFA01D592; Wed, 30 Sep 2020 09:49:01 +0200 (CEST) Received: from qrelay247.mxroute.com (qrelay247.mxroute.com [172.82.139.247]) by dpdk.org (Postfix) with ESMTP id 0A7521D446 for ; Wed, 30 Sep 2020 09:48:58 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] 149.28.56.236.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by qrelay247.mxroute.com (ZoneMTA) with ESMTPA id 174ddfc48380004a7d.001 for ; Wed, 30 Sep 2020 07:48:52 +0000 X-Zone-Loop: 7e1ef16f4628fd3343fc48c1c275390f49cc4c9635d5 X-Originating-IP: [149.28.56.236] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter004.mxroute.com (Postfix) with ESMTPS id 35BA63EA0A; Wed, 30 Sep 2020 07:48:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ezlNhdWbF4fMY5gzWYBeyImSbTS6zGCDTpvXPh5+iCI=; b=Pd0LvJH/aubQu5xhW6S4BkSJig B7orAD2QtY9p7FsQZSvOH4gHnKUIyO/fWsRfSZb4wRA0V9YErIrewBgvk6GAhYxZ1PeTOi8IGdZIj TVq6R6ytwQVTMEGRGl0/XoB2A41yx1SWyXpuHSSgbOuI4SiiCk64r4tt6T9pepsChTWrbndor5X/6 aICLjPpkpS7JP49aB5307RxEcCCc6GpVPnvJ7INN8tk6As2myHPdDxdBf7xUB8t3+wKUq31lugXNy TRW2KCXxexT0YwH13Nz/CtFPpputLt+qSgRUXak6Anhw9y0yT3JdWLGCCXLycTGe2fGNuQpFxWerc qZy7fDPw==; To: Jerin Jacob , Sunil Kumar Kori Cc: Timothy McDaniel , Jerin Jacob Kollanukkaran , "mattias.ronnblom@ericsson.com" , "liang.j.ma@intel.com" , "peter.mccarthy@intel.com" , "nipun.gupta@nxp.com" , Pavan Nikhilesh Bhagavatula , "dev@dpdk.org" , "erik.g.carrillo@intel.com" , "gage.eads@intel.com" , "harry.van.haaren@intel.com" , "hemant.agrawal@nxp.com" , "bruce.richardson@intel.com" , techboard@dpdk.org References: <1599843507-19970-1-git-send-email-timothy.mcdaniel@intel.com> <1599843507-19970-2-git-send-email-timothy.mcdaniel@intel.com> From: "Kinsella, Ray" Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: <54b0ad59-e37e-fd69-a193-c33015729fd1@ashroe.eu> Date: Wed, 30 Sep 2020 08:48:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH 1/2] eventdev: implement ABI change X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 28/09/2020 06:53, Jerin Jacob wrote: > On Thu, Sep 24, 2020 at 3:25 PM Sunil Kumar Kori wrote: >> >>> -----Original Message----- >>> From: dev On Behalf Of Timothy McDaniel >>> Sent: Friday, September 11, 2020 10:28 PM >>> Cc: Jerin Jacob Kollanukkaran ; >>> mattias.ronnblom@ericsson.com; liang.j.ma@intel.com; >>> peter.mccarthy@intel.com; nipun.gupta@nxp.com; Pavan Nikhilesh >>> Bhagavatula ; dev@dpdk.org; >>> erik.g.carrillo@intel.com; gage.eads@intel.com; harry.van.haaren@intel.com; >>> hemant.agrawal@nxp.com; bruce.richardson@intel.com >>> Subject: [dpdk-dev] [PATCH 1/2] eventdev: implement ABI change > > Please change subject to "eventdev: express DLB PMD constraints" or > something similar. > >>> >>> This commit implements the eventdev ABI changes required by the DLB PMD. >>> >>> The DLB hardware does not conform exactly to the eventdev interface. >>> 1) It has a limit on the number of queues that may be linked to a port. >>> 2) Some ports are further restricted to a maximum of 1 linked queue. >>> 3) It does not (currently) have the ability to carry the flow_id as part of the >>> event (QE) payload. >>> >>> Due to the above, we would like to propose the following enhancements. >>> >>> 1) Add new fields to the rte_event_dev_info struct. These fields allow the >>> device to advertise its capabilities so that applications can take the >>> appropriate actions based on those capabilities. >>> >>> 2) Add a new field to the rte_event_dev_config struct. This field allows the >>> application to specify how many of its ports are limited to a single link, or will >>> be used in single link mode. >>> >>> 3) Replace the dedicated implicit_release_disabled field with a bit field of >>> explicit port capabilities. The implicit_release_disable functionality is assigned >>> to one bit, and a port-is-single-link-only attribute is assigned to another, with >>> the remaining bits available for future assignment. >>> >>> Signed-off-by: Timothy McDaniel >>> --- >>> drivers/event/dpaa/dpaa_eventdev.c | 3 +- >>> drivers/event/dpaa2/dpaa2_eventdev.c | 5 +- >>> drivers/event/dsw/dsw_evdev.c | 3 +- >>> drivers/event/octeontx/ssovf_evdev.c | 5 +- >>> drivers/event/octeontx2/otx2_evdev.c | 3 +- >>> drivers/event/opdl/opdl_evdev.c | 3 +- >>> drivers/event/skeleton/skeleton_eventdev.c | 5 +- >>> drivers/event/sw/sw_evdev.c | 8 ++-- >>> drivers/event/sw/sw_evdev_selftest.c | 6 +-- >>> lib/librte_eventdev/rte_event_eth_tx_adapter.c | 2 +- >>> lib/librte_eventdev/rte_eventdev.c | 66 +++++++++++++++++++++++--- >>> lib/librte_eventdev/rte_eventdev.h | 51 ++++++++++++++++---- >>> lib/librte_eventdev/rte_eventdev_pmd_pci.h | 1 - >>> lib/librte_eventdev/rte_eventdev_trace.h | 7 +-- >>> lib/librte_eventdev/rte_eventdev_version.map | 4 +- > > Missed to remove the announced depreciation notice. > > >>> 15 files changed, 134 insertions(+), 38 deletions(-) >>> >>> /** >>> * @internal >>> * Wrapper for use by pci drivers as a .remove function to detach a event diff >>> --git a/lib/librte_eventdev/rte_eventdev_trace.h >>> b/lib/librte_eventdev/rte_eventdev_trace.h >>> index 4de6341..5ec43d8 100644 >>> --- a/lib/librte_eventdev/rte_eventdev_trace.h >>> +++ b/lib/librte_eventdev/rte_eventdev_trace.h >>> @@ -34,6 +34,7 @@ RTE_TRACE_POINT( >>> rte_trace_point_emit_u32(dev_conf- >>>> nb_event_port_dequeue_depth); >>> rte_trace_point_emit_u32(dev_conf- >>>> nb_event_port_enqueue_depth); >>> rte_trace_point_emit_u32(dev_conf->event_dev_cfg); >>> + rte_trace_point_emit_u8(dev_conf- >>>> nb_single_link_event_port_queues); >>> rte_trace_point_emit_int(rc); >>> ) >>> >> I tried running testpmd with trace support with this patch and got following error: >> >> EAL: __rte_trace_point_emit_field():442 CTF field is too long >> EAL: __rte_trace_point_register():468 missing rte_trace_emit_header() in register fn >> >> It is because of memory (384 bytes) for CTF gets exhausted during eventdev_configure. >> Did you also observe the same issue ? If yes, Then please send a separate patch to increase >> Maximum buffer size TRACE_CTF_FIELD_SIZE. Recommended size is 448 bytes. > > Please check this and send the next version for this and common code > change[1]. I would like to merge-common code change first and then the > DLB drivers. > > [1] > http://patches.dpdk.org/patch/77466/ > > >> >>> @@ -59,7 +60,7 @@ RTE_TRACE_POINT( >>> rte_trace_point_emit_i32(port_conf->new_event_threshold); >>> rte_trace_point_emit_u16(port_conf->dequeue_depth); >>> rte_trace_point_emit_u16(port_conf->enqueue_depth); >>> - rte_trace_point_emit_u8(port_conf->disable_implicit_release); >>> + rte_trace_point_emit_u32(port_conf->event_port_cfg); >>> rte_trace_point_emit_int(rc); >>> ) >>> >>> @@ -165,7 +166,7 @@ RTE_TRACE_POINT( >>> rte_trace_point_emit_i32(port_conf->new_event_threshold); >>> rte_trace_point_emit_u16(port_conf->dequeue_depth); >>> rte_trace_point_emit_u16(port_conf->enqueue_depth); >>> - rte_trace_point_emit_u8(port_conf->disable_implicit_release); >>> + rte_trace_point_emit_u32(port_conf->event_port_cfg); >>> rte_trace_point_emit_ptr(conf_cb); >>> rte_trace_point_emit_int(rc); >>> ) >>> @@ -257,7 +258,7 @@ RTE_TRACE_POINT( >>> rte_trace_point_emit_i32(port_conf->new_event_threshold); >>> rte_trace_point_emit_u16(port_conf->dequeue_depth); >>> rte_trace_point_emit_u16(port_conf->enqueue_depth); >>> - rte_trace_point_emit_u8(port_conf->disable_implicit_release); >>> + rte_trace_point_emit_u32(port_conf->event_port_cfg); >>> ) >>> >>> RTE_TRACE_POINT( >>> diff --git a/lib/librte_eventdev/rte_eventdev_version.map >>> b/lib/librte_eventdev/rte_eventdev_version.map >>> index 3d9d0ca..2846d04 100644 >>> --- a/lib/librte_eventdev/rte_eventdev_version.map >>> +++ b/lib/librte_eventdev/rte_eventdev_version.map >>> @@ -100,7 +100,6 @@ EXPERIMENTAL { >>> # added in 20.05 >>> __rte_eventdev_trace_configure; >>> __rte_eventdev_trace_queue_setup; >>> - __rte_eventdev_trace_port_setup; >>> __rte_eventdev_trace_port_link; >>> __rte_eventdev_trace_port_unlink; >>> __rte_eventdev_trace_start; >>> @@ -134,4 +133,7 @@ EXPERIMENTAL { >>> __rte_eventdev_trace_crypto_adapter_queue_pair_del; >>> __rte_eventdev_trace_crypto_adapter_start; >>> __rte_eventdev_trace_crypto_adapter_stop; >>> + >>> + # changed in 20.11 >>> + __rte_eventdev_trace_port_setup; > > + Ray, Techboard > > Trace is still experimental. So I assume we don't need any > depreciation notice to change this. Correct, no need for a depreciation notice. No need to change the map file either. >>> }; >>> -- >>> 2.6.4 >>