From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1ABABA0524; Wed, 5 May 2021 13:57:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 941DA40040; Wed, 5 May 2021 13:57:10 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 229DD4003C for ; Wed, 5 May 2021 13:57:08 +0200 (CEST) IronPort-SDR: JiKxA7AxjV1nwCcGep+PlXbwUv7v9P839zKp/mxYufFJ9UU9WjoSbE1vD+UE4gRbzuS4MIJXiy ab8gi+r0t3SQ== X-IronPort-AV: E=McAfee;i="6200,9189,9974"; a="219043987" X-IronPort-AV: E=Sophos;i="5.82,274,1613462400"; d="scan'208";a="219043987" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2021 04:57:08 -0700 IronPort-SDR: oRcxzOIgdbIRTVUaSDCs3zqvNxEO6dNn03mwjDEqHpQ1iII84VYLd5wKSc423MiY3xOG1Kdg0o 0uUBb/tF+3Pw== X-IronPort-AV: E=Sophos;i="5.82,274,1613462400"; d="scan'208";a="468927231" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.210.178]) ([10.213.210.178]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2021 04:57:05 -0700 To: Thomas Monjalon , David Hunt , Ferruh Yigit Cc: rasland@nvidia.com, matan@nvidia.com, viacheslavo@nvidia.com, leif.y.johansson@ericsson.com, Alexander Kozyrev , dev@dpdk.org, Andrew Rybchenko References: <20210408032554.20255-1-akozyrev@nvidia.com> <20210429145518.20999-1-akozyrev@nvidia.com> <58e9e3da-4b88-877c-934c-6b57387b3440@intel.com> <2178881.vkImXlHJGI@thomas> From: "Burakov, Anatoly" Message-ID: <54bf26d9-e3f5-eca1-2431-3df0e6d82371@intel.com> Date: Wed, 5 May 2021 12:57:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <2178881.vkImXlHJGI@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: add power monitoring support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04-May-21 6:43 PM, Thomas Monjalon wrote: > 04/05/2021 19:40, Ferruh Yigit: >> On 4/29/2021 3:55 PM, Alexander Kozyrev wrote: >>> Support the PMD power management API in MLX5 driver. >>> The monitor policy of this API puts a CPU core to sleep until >>> a data in some monitored memory address is changed by the NIC. >>> Implement the get_monitor_addr function to return an address >>> of a CQE owner bit to monitor the arrival of a new packet. >>> >>> Signed-off-by: Alexander Kozyrev >> >> Hi David, Anatoly, >> >> What to you think adding "Power Monitoring" as a new feature in the NIC feature >> table? So the drivers supporting it can advertise it. >> https://doc.dpdk.org/guides/nics/overview.html >> >> For it need to, >> - add "Power Monitoring" to template .ini file, >> '.doc/guides/nics/features/default.ini' >> - Document it in the features file, '.doc/guides/nics/features.rst' >> - Update driver .ini files to advertise the feature, like 'ixgbe.ini' > > +1 > > It would be good to have discoverability for this feature. Seems like having a first non-Intel user is a good excuse to do just that :) -- Thanks, Anatoly