From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8327FA00C3; Fri, 13 May 2022 10:58:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7010F410F5; Fri, 13 May 2022 10:58:44 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 6C50F40DDE for ; Fri, 13 May 2022 10:58:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652432322; x=1683968322; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=5+ELK5WJZVSHSYaVfECqkmblKhkvEoDxuU8KUKOzasY=; b=Yz/S3TOotujoXXvI7EIFLaKUDQRHYBwu1MqWIhjbjAvbmS8Ls+/54B2+ hxK7duGgMEthQW0fW6a+VzJfzMDVsRtOqQjYZVeJxE633OtP9Vl4+K0ND 0lfBg7nMe+zBSDlo7CuDf2huDckbdRdbQR5jXk3gc2NeVL0Fd+MP6nqIM L7ASAebMGwm4kAuO4wbbCdS4wAHVKDYECy2/SD0aztM+hz3ujjw/Q5v7H /zghn14bYUIjZp8rhgGZ3RqsbwvHMpDlrcSrbcBK7P87gLO/kBdurktBF S1nEcB6DaauPE4L/YiyzWpL8Azt0ax1lzcOxBDvn4TZy+QF5w8S7Awux8 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10345"; a="270192196" X-IronPort-AV: E=Sophos;i="5.91,221,1647327600"; d="scan'208";a="270192196" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2022 01:58:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,221,1647327600"; d="scan'208";a="637219038" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP; 13 May 2022 01:58:41 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 13 May 2022 01:58:41 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 13 May 2022 01:58:40 -0700 Received: from fmsmsx612.amr.corp.intel.com ([10.18.126.92]) by fmsmsx612.amr.corp.intel.com ([10.18.126.92]) with mapi id 15.01.2308.027; Fri, 13 May 2022 01:58:40 -0700 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "maxime.coquelin@redhat.com" , "Cao, Gang" , "Liu, Changpeng" Subject: RE: [PATCH v7 13/18] vdpa/ifc: read virtio max queues from hardware Thread-Topic: [PATCH v7 13/18] vdpa/ifc: read virtio max queues from hardware Thread-Index: AQHYWheH4P4CuvF9+Eqr/cN2tbw4dq0bW2eQgAE/W1A= Date: Fri, 13 May 2022 08:58:40 +0000 Message-ID: <54d37368c6bb4102b068b7d9b5fc2298@intel.com> References: <1643093258-47258-2-git-send-email-andy.pei@intel.com> <1651048206-282372-1-git-send-email-andy.pei@intel.com> <1651048206-282372-14-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Thanks for your reply. This patch will be omitted in next version. > -----Original Message----- > From: Xia, Chenbo > Sent: Thursday, May 12, 2022 9:55 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coquelin@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v7 13/18] vdpa/ifc: read virtio max queues from > hardware >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Wednesday, April 27, 2022 4:30 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; maxime.coquelin@redhat.com; > > Cao, Gang ; Liu, Changpeng > > > > Subject: [PATCH v7 13/18] vdpa/ifc: read virtio max queues from > > hardware > > > > Original code max_queues is set to IFCVF_MAX_QUEUES. > > New code max_queues is the min of IFCVF_MAX_QUEUES and hardware > num_queues. > > > > Signed-off-by: Andy Pei > > --- > > drivers/vdpa/ifc/ifcvf_vdpa.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c > > b/drivers/vdpa/ifc/ifcvf_vdpa.c index 4060a44..5a8cf1c 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -1457,6 +1457,10 @@ struct rte_vdpa_dev_info dev_info[] =3D { > > internal->hw.blk_cfg->geometry.sectors); > > DRV_LOG(INFO, "num_queues: 0x%08x", > > internal->hw.blk_cfg->num_queues); > > + > > + /* reset max_queue here, to minimum modification */ > > + internal->max_queues =3D RTE_MIN(IFCVF_MAX_QUEUES, > > + internal->hw.blk_cfg->num_queues); >=20 > MQ is not supported now in this driver, should we make this change later? >=20 > Thanks, > Chenbo >=20 > > } > > > > list->internal =3D internal; > > -- > > 1.8.3.1 >=20