From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9913FA034E; Wed, 19 Jan 2022 18:27:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9BCE4117E; Wed, 19 Jan 2022 18:27:04 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 36E3A41147 for <dev@dpdk.org>; Wed, 19 Jan 2022 18:27:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642613223; x=1674149223; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=EcrrgE+nW7Le7NPE7xnVT346sEX1MOEZ6E0EK2QLBpw=; b=W8bv2nm4qS3jX1mLFBuIgg9JWLvpbU2Fk7D0qkVzSojjudqefYFrwGdX y2/7cIEySROZ70WaVC01WGxYUZGOrfVRGFeqAsq3Ddxh2syQbCV89Uelb 8HimZz6dwH/tpMZahx1b7Pxt5sTJPh6IJFYRzLqzndzZcQr/G9bSEQ6eb Y1zks/5hxz0qShBnA4Phin77fLHRVOe5XAtpLezftkgYbQFoey3qh0rBW wtSGstiPRfkPrzPAEAMQ7LtaI1I+oO9q1q8DFo+S/vWjzElHMN+5q4t5H a08Iw5nBul+YV5CmOWONzUa0c6aRkgcxlGtoxlU/dkkz2u7RrJkhVdg7K Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="243944973" X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="243944973" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 09:27:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="493101857" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 19 Jan 2022 09:27:01 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 19 Jan 2022 09:27:00 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 19 Jan 2022 09:27:00 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 19 Jan 2022 09:27:00 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 19 Jan 2022 09:26:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TSzcihFs+Jn9rucOZCgA9HX0M4ukz4TRmanzGvyHhRp4J/Mp2UIpwYWmnhoSqN9ITaJsWeSF5O6ufAM3ygA+D9CfQ3yPhrLihWZGM1zQ6+0QGjaTOqHYluhTIyBvhLXgwLGqr3UOalpNIPt3G9eS8mHtl6XLYJcOuRhuFrTDaBUb31wRt3phspkS0ZmiiHEAgcKAxucWiq63p233R2B8Npp1UqYgoA6VN5vr7ViUNN/hxddSmYxT6KfBBr0hkV0D9Bj5N409e+IBBYk9AgnDJzdRLQcd76Ojqw2zCg0syUk2nuvgGigPM+pXknUWi2moEnkmoVrMkTttMe5MgXZogw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DJJXOvK8QbglzpUzH2fGzNxv9DOSUZzVBCb98515fVk=; b=NRBsK7/ZbGVQA1zPMgl8LwSDyY7wTuLVZclp1cLqctuWNuPRafStVHNW+MwH5welkdBvTjoCZW5zpnc8OgBe2AlGdYEKXKaCH/r6MGfYfuX8UFa7dAVo//RynBOnhrnBq2bKY92JrON6hNbt8uy28XxkrVEnRzi2suHuR0AoUs5aEQlrLNDOWamC1siG6B1oLXLOJO5O4JI3lAOK5+q435q1DWslFqxihIOXQRWfvVzgIU4COZ02fraY2/Uugve5YoB8c8wnfCAaouQXRhb1IP63NmBfcTiZr+yWHQCrZy0wr8AmGfH7LmylEq2DHljYKc2eQjh4KDguGphsermhnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MWHPR11MB1503.namprd11.prod.outlook.com (2603:10b6:301:f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.12; Wed, 19 Jan 2022 17:26:53 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4909.008; Wed, 19 Jan 2022 17:26:53 +0000 Message-ID: <54e67663-9c38-6bdb-7033-207da837668b@intel.com> Date: Wed, 19 Jan 2022 17:26:47 +0000 Content-Language: en-US To: Yanling Song <songyl@ramaxel.com>, <dev@dpdk.org> CC: <yanling.song@linux.dev>, <yanggan@ramaxel.com>, <xuyun@ramaxel.com>, <stephen@networkplumber.org>, <lihuisong@huawei.com> References: <cover.1640838702.git.songyl@ramaxel.com> <683cdaab3c9602409662f77862b83f2c345855c5.1640838702.git.songyl@ramaxel.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Subject: Re: [PATCH v6 09/26] net/spnic: support MAC and link event handling X-User: ferruhy In-Reply-To: <683cdaab3c9602409662f77862b83f2c345855c5.1640838702.git.songyl@ramaxel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0096.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::36) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d0a75673-7ffb-4785-21b9-08d9db70e231 X-MS-TrafficTypeDiagnostic: MWHPR11MB1503:EE_ X-Microsoft-Antispam-PRVS: <MWHPR11MB1503BA65B2F04E08350BA9B695599@MWHPR11MB1503.namprd11.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HXwNKA4hcuByqKKdKHYsiUp0bOgK2TsTe3PIhqjzsE6vZNtpEi6G5kp12N6VzvZyh/VR43B07wE/US1papriCDecpjAA4wG8ZWtg9rZ9ea/jylQ7Vx9A/haCUcFDb9OIn9l+43Nkr+XytJ4tiTZfAp71QMy90C2fuWP3FdTzQriyBRUIArOr39tXLdGbdaQnUIkwMGzbbJI365DEoP3drzWFyiRJu7fSF2JcBGryHr8rPQd5CKf+s7HIUQzIAHAzAdIPzBVP9N8zRoGeYhsB9haAbuCaYNQgN7XJuJp/cyF1SZOfqeYi2xll1XWe8h4TdmAZqLIFelrmwg4ir3PuEDeBtByoyV57z8IH2QLu0L9y22RbXyjNSdn17hdp9to443qYR+DKZ/9Xs2/0Lg2GyX6NA0HPtPPTHKf1sa1CKdu80/WPrsNESdyPBYa6r8e0cJkoT4hUukOINdqQfEZ/rIZo8UQoEaPF5lo7NE4ERtU8U39QvBietvkCpdBIQ8pkbWKe1CWZ1kSnmMe2N9E7eu/vSCe5kcLQR40WjD5T7RtBTAE96Se3vk9g0D2HodbTNfEIUfBVeeoKZJ0R3dXMsZDfo5wPYBmwvdrCaomXmpaz+uQLC4zq97Wm0vIcvzm1d8z8vzr3wabtQrwlR0gC+iCeRZ0Zzqxf1RkYR77m8mp4LDpMjf8bqjhVUePk/EvZaH98achv3EnEfkWj6xFzMA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(86362001)(316002)(44832011)(4744005)(5660300002)(38100700002)(6512007)(83380400001)(26005)(4326008)(31686004)(31696002)(6506007)(6486002)(36756003)(6666004)(82960400001)(66946007)(8676002)(53546011)(186003)(66476007)(66556008)(8936002)(2616005)(508600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bE5WZnlHNmhLZ0VoS3V3S0Fub3pFOVFRNEpYNk5LbW5Ia0QvU0xHMU51Z292?= =?utf-8?B?UnJzN09EVDJKZlpGRjBVUnY4MzF2eDJiWnBHZlFmOHg0ZGVYNnZBRzdodWRE?= =?utf-8?B?aStkREFjSkdCNmlad0Z4M0ROS0MzS2lPRHFKWU50MjR4TTZuZDdxbG1jSVRu?= =?utf-8?B?TUVPUTdqTW16Yzg1ZExaaEQ1SnVBaXdTWlE0M0cyRFVlMzJ3ZDlUclNKNmw0?= =?utf-8?B?MElIbTIzQ0lvK2lGZ1poQ1VSdHFQVjhwRmdtT29BWkU3a2lDV2ZVZ3MxUkIz?= =?utf-8?B?c1hCbVc5SGZiZ21zblNCTmptNVlLZTQ5enR4RFdqTlcrRXc2RStKaUd1dHBH?= =?utf-8?B?SGl0QjY0UDNRdGZmeWZPRDZJWmZEdnVxQW9jR3BxOGhhdk02VXFNZDJ1OWxy?= =?utf-8?B?U1haQytBRy9hMEJuUGN3RWNtb1JXUVhYOWx0Tmo1RHNXL2xBSmZIaDhiejd0?= =?utf-8?B?YlRDczBGNWdzbUhTMTVYMlkxaDNISjdQdGoycUhiUUFFU3NCVCs3eHVTQVBK?= =?utf-8?B?QVJ0cXhTa3YrQVBKL1d6Yi9zaDlzSW5JOVF2MUx0VGJJUjluSVRYeXJEcFAv?= =?utf-8?B?cFVlSkg4eGVsRy9WR1BCOW9mc1JqdjJwUmFsK2c0aFlrakV4cWUzeDhCVDFm?= =?utf-8?B?TEpvcFpSbDFUblc5TzdJZklJY0kxU3hGVFZxN2NWanZodnNhUllwd3JObVM2?= =?utf-8?B?aDQ4TnhyWnNjR1ZaRm9MTC9FODFHVjM1aFVoenlMY29xRS9RYm5uUkZDcTRy?= =?utf-8?B?YWdXWnZyei9OUjNXMDRBcFBIK2V2ZDNhRkFiWjJrTXh3UVpscU9uT2h4blNt?= =?utf-8?B?L1prM040cm13em5XN1Ftc1lxUWxBdUlkVk9sVGlMYkptMWhhV1hQZ0lTL2Qy?= =?utf-8?B?YkM2Tk9nTFdRd2c5THlMOUQva1ZpWVlxU21uMzl1NUEzZmpKZ1JoV1VudjNw?= =?utf-8?B?TWJ0RFU3eGpBbWtyZmZjQ29sSXNyVFBQVG42NFp6Q1Zpa291QTc1ck1hd1Nt?= =?utf-8?B?Yjc4bFBGajBhUE5oNlNDSVB6Z091MDgyRkFVeCtTZWZZb1h1R1NMRHd6T2Qr?= =?utf-8?B?K2NIamZMMzlUWVVnTWczN0FMV1R0RGVMVDhOTjlJRjlnYzFMWDhzc0o5Vnky?= =?utf-8?B?NldHdUZUb2htRnRwV3N0OW4xdElZTG9BWXN5Y1hoNzF3ekZZZGhYQmtPL0o0?= =?utf-8?B?NFpLWXFQUFJpN25LSEhkWFROclB1RUd6ejRvUTZPMFU0R3hnZ2thcnY0MTk5?= =?utf-8?B?ZmpnNDN1ay9SSURGaDFHbUhHM25ITUR3QWlpa0NVU3NNakdTWTBDNUtmTFhL?= =?utf-8?B?ZnZaUTVBTUhQb2NmSjYrOE5XUFFwcHpBVkNvVURPc2NmWStNYWk4MGo3MEg5?= =?utf-8?B?Qnp4NGorRVN5SUhMWE9jUi9XalJzcXFPUmpQZnZ1S1UzQlByaTYzTi95T2JZ?= =?utf-8?B?dDhNYWR4SG80N3N4eXFNR1BKL0ZjQUdCc3hYMXBSSzZMZ1VQQ0hRQ0IxdU9K?= =?utf-8?B?TDNWekxZOXlYakErOFpRMmJkZWlrRzlkeHNrWGVhNnFFZ214NDZVOCs4KzR1?= =?utf-8?B?NkZ1RGJkOXVOYldWWU5yYUFJb0pzK2ZCc0ZlYkh1Nk9tTWVHc0hGYzJqS1BK?= =?utf-8?B?dW91R2Z2ckhRUWJqUUprcDZid1crTHZxNDlKZDR4WEw4dXdWeFFJQmRYQSt0?= =?utf-8?B?YXpUTGNtd0p6NkFXOUY1citjbFlGemM4c0hrY0xESDIwUml3K01xVUgrdVpz?= =?utf-8?B?dkdaTEMwUWJlWWRUQmNMYi9meW90SE5wSEdSSUVPa29mQTRkemxTeWV1SndF?= =?utf-8?B?YnB6S2xKMVJpcDhEZGhaQ1NuakluNjh5ak9LdjFSZTNiL0RPVXp4Zm16UXBt?= =?utf-8?B?SWNyTGRSaGF1ZFdCTmpLdnJDK04wRmRFTzNJMEdsQmhRVlRaUHpabHdQNXd0?= =?utf-8?B?RFlKMERKRE5zbE0zTjZwMUpBbkh1aTlBNTlzSHhDNDU2SEVlWHpDY1NBMHJY?= =?utf-8?B?RU5MM0pnejdSUTBUc1Foa1AwaENuclRWNHF6UmgrV2xPUHk5S1c5MnYrQ3FP?= =?utf-8?B?Mk1wejBMV3lyMW5ZdGhEUlkvODVmWm1PVHFpTEpRSUhxM2NRbWFENm5yV25Y?= =?utf-8?B?NnJmbHBlRllJN0VZOEZoKyt0Z1dWdFpWM2ZRQk1jU21iZmRmYXpkQitjc2N6?= =?utf-8?Q?wQ4Y7BB7c2UJNPfoSOindIs=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d0a75673-7ffb-4785-21b9-08d9db70e231 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2022 17:26:52.9813 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wNbTc5aCU+5kDs2zRfGHv4mjA9i+9AcKnOTXlJg7wlsuSNS+p51vTbquIaxJUCEvM0Ighot7yFymzq+/EuFKLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1503 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 12/30/2021 6:08 AM, Yanling Song wrote: > This commit adds interfaces to add/remove MAC addresses > and registers related ops to struct eth_dev_ops. Furthermore, > this commit adds callback to handle link events. > The patch also adds the VF dev_ops. It would be more clear to support PF first and add mbox support and VF later. But VF support is crept into the code from early patches, I assume that is because the driver is already complete and spliting it is hard at this stage.. Similarly the primary/secondary support seems spread through the patches, hard to separate the feature. Above are sign of the patches are not split logically which makes harder to review them and detect any issues, and future fixes references won't be clear. If you can clarify the split more, that would be great but I can see it is hard with an existing driver. > Signed-off-by: Yanling Song <songyl@ramaxel.com>