From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0B57A0C46; Tue, 17 Aug 2021 18:29:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 336A740DF5; Tue, 17 Aug 2021 18:29:37 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 559D04014E for ; Tue, 17 Aug 2021 18:29:35 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10079"; a="203292587" X-IronPort-AV: E=Sophos;i="5.84,329,1620716400"; d="scan'208";a="203292587" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 09:29:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,329,1620716400"; d="scan'208";a="488088397" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga008.fm.intel.com with ESMTP; 17 Aug 2021 09:29:33 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 17 Aug 2021 09:29:33 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 17 Aug 2021 09:29:33 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 17 Aug 2021 09:29:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VCjL5+4JyrHHd56I0Z8a2K8TNj0jXevSiBs7C5v9KWmX9q/N3xANNSR+a5i5mKcSkNcX/hsW7S3wUuCjCVFYZaJgk71BX8op4l0TGIswYkwyT30M3UAEXnT9fg9DvitEvBvcufiDfW+GYmRVWODYrnyojupMs3WlwNqDbq/isztDwPgWl9LeRU75ZVrkJ89XstjQsaC4l/Wu3H1zMubpsEra7GmwlAD6DY+QaHbicNhLoqvL5I8L6uOlC5IOloqlDM/iFljwgEPQ/oYqLL6UAM7HTrEbJ2WnLSCK0SJlQIhuPcsJvU9jpyqszQTzUz4byRAT7dVt4J0lJPHffBsXmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X9hA5JhDPFw4C44EyAJivTs5B+7d6Q9vZzVsLbTqVgU=; b=UPDNMpjOQcmShQx4SnVs3LfnZtMuU7pMdRJ17J4vK+uaGvjroXKm4x0oPG3YpD+vqpr0ZMXcB1NoLj6z6Bbu0keIdIrxOOj8EoqPWi4y9Q1T9lB53aE6jfivb5qlt/Q/bbkmBGf4Y/HFacxV48KLfJAv+k4wggYdsKEO63d9B022zvkoeZCbH34QaKsHQ+O2sqzfLAWqElaG+CHYkrBtzsBOxPIFHaTUx4/2MoirgnSRRsEkXRIxa8FGERJsWl0gNh5lLoOwv3mfUZrNleey9WNk/TXzsYh2lIM2WKdEGD7aVeJ7nZm+Ysxq5eS7YX1RHgTW3Td5TinCT7ksOsfR9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X9hA5JhDPFw4C44EyAJivTs5B+7d6Q9vZzVsLbTqVgU=; b=zX3evtyw6ta09LcUaPLMlEiKOaCcohNEYIGzZnlbGst/Q4ZlqgjhIIXnOjlIOK6GUWJpWTvPZRlORpL2HN/KsZRrnCVttcfzYZpmObHI/4BtSw1BS9526emCAwdNbnrsurFhwQC17IK3T3RTgJ52057xWVZe77Z2mmGfCgRzllI= Authentication-Results: corigine.com; dkim=none (message not signed) header.d=none;corigine.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4856.namprd11.prod.outlook.com (2603:10b6:510:32::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.17; Tue, 17 Aug 2021 16:29:32 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf%7]) with mapi id 15.20.4415.024; Tue, 17 Aug 2021 16:29:32 +0000 From: Ferruh Yigit To: Heinrich Kuhn , CC: Simon Horman References: <20210716083545.34444-1-heinrich.kuhn@netronome.com> <20210729134711.35870-1-heinrich.kuhn@netronome.com> <20210729134711.35870-5-heinrich.kuhn@netronome.com> <9815f897-3e04-26e7-1048-8f9eda29d0aa@intel.com> X-User: ferruhy Message-ID: <54fcbb86-a82a-8573-bbe8-16abfda0cef9@intel.com> Date: Tue, 17 Aug 2021 17:29:27 +0100 In-Reply-To: <9815f897-3e04-26e7-1048-8f9eda29d0aa@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0265.eurprd04.prod.outlook.com (2603:10a6:10:28e::30) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0265.eurprd04.prod.outlook.com (2603:10a6:10:28e::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Tue, 17 Aug 2021 16:29:31 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 310eb0c8-0009-4afd-78e2-08d9619c3152 X-MS-TrafficTypeDiagnostic: PH0PR11MB4856: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X/k9AGCKxQUope89fW9PZylDiPBl5Cm3t1yESZCb7mrvokp/YP/sU1JXIR1IzEKb+XGTv4VxLRJjFCSQr3fpEded3R0hSUuQFZmRkyhNx7M4Ydvv6kcNrNkFyySw3gky0l/ZF51u1mFIwLo9REb5tlthHXxOtTV2hrlj20p1UrdcC3hhAgMLW5zAedZe4z1xISFj3Xk505eF7WG6/DTzbxHnsSOzmFiWC7ZMSaVXuO7wgU3GbTKlpVFYA4z3Z2fQ1KbjrCQ84BPiTrHz2ZuaDkvgokP1jfBmcx1nuwZhh3iBEUctqA+7TYpq7yUUeF4YGDRc3RmNlet1wxWIdW6F7Q4TRoqzLA8L233K0vfldfoNr6i2OuGrI1rdBCon5f5OjpI03aAa4hpd1XsoQYZmeX4uLgMNuQTwVOJtHx7sUdRN17yOemyHXYrF19QMPxhzJvBI9hkoGZAlvANM5gGkQHa5rzNhcQbBXeUYOsLU9t2bivYDRHCMK5nSUPmkD0p8Nx9+B0fzQyKhdvzettY5pamP2IE5Cx6MdABaBAdPhXGdeqAAZo2JwobK4fEop/kIC+eG4Brvw5dsI9VT79R1I9an1BYKyr1T6q9bz8RnsV0leiuKXET92tLsRWw4Z1S4E3I7W/cRQt+3vN3pZ2LxSZEY6biMd96EiW/WnFV/5YITMSIgT0H11ccoXNP5gq3/NbqugScrbkIN8Svw7be7WQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(136003)(396003)(39860400002)(366004)(376002)(4326008)(31686004)(6486002)(38100700002)(478600001)(53546011)(16576012)(36756003)(316002)(26005)(186003)(5660300002)(8936002)(2616005)(956004)(83380400001)(44832011)(66556008)(66476007)(8676002)(31696002)(86362001)(6666004)(66946007)(2906002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enFqcjRrdDI4ZlI5MEQxcWM4NXYrNGRHRFY0aDZlS0tycjFLVllDNmQ4d1ZQ?= =?utf-8?B?TzJoR29FNmx4UlFldHhSdWE3Q3NmZUtIeGtKMkI3WStVRW9hd3N1c0M2N3Jv?= =?utf-8?B?UXoyUzIzb0l4dzM2c2RIYk5yWENVU3lmbjVRVmluOGk4U1NJeCswMTZIemVI?= =?utf-8?B?TnlEV3pDMnhrZFFDUDh1N09YSDRuc0E5RE9hV0pGSVZPTCtKZ0h3L0JoYjJu?= =?utf-8?B?V24zYmhlNVljRE91S0hvZTQ2bmN6ODk2ZzFtM3NOdnhDeU5jcjl3dkNqTDAv?= =?utf-8?B?U1A5ZVRKSUM0SUNpdEVqWTB2eVZNV2IwVzVueXNZNFNhNk5BSnJ2Z2ZXZVd4?= =?utf-8?B?UUdnbDk5LzlQU1UxQmZvQWVHT2E5NDBnak1kMEdnLzNnY3Ewb3FRcXV5NHNZ?= =?utf-8?B?MGFLQThqWFNsY05OVndobVFuVFNLUmNrZEtiUUp1RGQvWmJJa1grL0dPRmw1?= =?utf-8?B?VGEydGtzaVlYRnlrOWQxNUYxZ2xyZFloVzBETFhPcUI3MlZ3d3BCWEswOUMz?= =?utf-8?B?ZENDOFNjTWRwZE03OS9pQkpJUkF0aEV6Z0FleThSTForNkNqdHhIQmxCbE5H?= =?utf-8?B?V2lTTDFMU01sUzJIL0piRWZESlZ1K0Z1ZWxsWTNPcytTNkhMZm1XNjNxd0wy?= =?utf-8?B?bTFUUjlnOTYvem5mY0l3U0RnMmR6QjYrcWR6aVZSSHFGY3g1WjFSSGVQOGp3?= =?utf-8?B?V0Rabm5FanN0SFViYjhDeWhqUnNiME9KQkZSNmR6a04vS0lRUE5oMVlMZDNW?= =?utf-8?B?RlRhc0RsZ3FYdTBmdkpCUTBPUUJsTU50Zkk4cHV2SW5KTW9DbzZ5S2Q1U3Vv?= =?utf-8?B?MEF4TmV4SnRweENXeC9xKzJLUjN1UDk5WkFQNDcwU0hyYXF1eDFWM3dVWmtS?= =?utf-8?B?a2owRVNoSnExdU9lWEVWbTJCbEpmelJUdnZjbndueHYxOTVkMzQ4RWRsQ29C?= =?utf-8?B?WTVSYlNIQWhBUDExSEtXL3F2TG5MNnZsYkRUUDRHVWV3eWROWFMwcDE1aURv?= =?utf-8?B?dldtaTdodytLSDNPalNsdWJBbHRWWWFDNnhvTUovbkd0QWRRaFM3b3R3cU5x?= =?utf-8?B?V3hIRkZBNUV2UmJZMjc2c0ZNMjJhaTJ5TXd1VFppSDgrMkQzRnV5NndiSFpu?= =?utf-8?B?NTY3ZVNibkJKa2toSWg4clBkYzJUcVQ4OUlON3RnSTVyUVVLc3BzVWlQUFJh?= =?utf-8?B?Ym93YXp4b29nK2U0UGgwbTRlYklmTmxOTWhYNWVaS3dwVER1eG5yMEpqb3FZ?= =?utf-8?B?aHlGUG5IRTdZS3JpWldtc2cvTndyM01ETHA3RDVvZm9ydkE1NXdERFY3NGdw?= =?utf-8?B?SG9kZWZwa1pGcERyS3BHaHRJUkx1TG1GWjd0eWxXaDlvTnRYOVBWWVNVY2lq?= =?utf-8?B?NTIrTWJQTUM0NE14RnYvd1Rjcm1ETHlBaFhJdU5SUXovSVpwSkwwdVA0bkRt?= =?utf-8?B?Ry9lSlVPZUVrM280cWNZN0RKQ3hJMkNNT05jZy9tdGFnT3NlZ3ltek50UG5X?= =?utf-8?B?RkY3T3UyT2JDZ3JRcURleWhSMTBQMGxMenorMGYwaHh6ZDcyWUh4SjRxS25P?= =?utf-8?B?S0tySDN1Z1ZPSHZTdVh0VWl6MkF4NXE5Yy9wTzNQSVNxY043c0toYkVtekto?= =?utf-8?B?ZGdVZ3djWmZzMFlRc2llMUxvK3lVa1p5L0wzRlcxb3krMTVPRmVkdW5ndkl0?= =?utf-8?B?UmpHc2tteVNkUlY1aTJNOXBjWDFmdnoyYUpMQjc1dE9RdFpLaURZSGNtUGZq?= =?utf-8?Q?Mu2hHiBHM9O1A3yBDeDDbW5ESMBjiZR3prWq1zv?= X-MS-Exchange-CrossTenant-Network-Message-Id: 310eb0c8-0009-4afd-78e2-08d9619c3152 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2021 16:29:32.2166 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eqEvptx8VH05NIQaxAoKEmnnUwxP8YH9pfei1ndnUhUgKjXLU/pxNdld8gPkulXfdpj2TpyIgREq2fS9ZIA2Qg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4856 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 4/7] net/nfp: prototype common functions in header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/17/2021 3:44 PM, Ferruh Yigit wrote: > On 7/29/2021 2:47 PM, Heinrich Kuhn wrote: >> The majority of "ethdev" type functions are used for both PF devices and >> VF devices. Prototype these functions in the nfp_net_pmd header file in >> preparation of splitting PF and VF specific functions. >> >> Signed-off-by: Heinrich Kuhn >> Signed-off-by: Simon Horman >> --- >> drivers/net/nfp/nfp_net.c | 87 +++++++++++++---------------------- >> drivers/net/nfp/nfp_net_pmd.h | 49 ++++++++++++++++++++ >> 2 files changed, 81 insertions(+), 55 deletions(-) >> > > <...> > > > Following functions seems only used in this file, and you may want to keep them > 'static': > nfp_net_dev_link_status_print > nfp_net_irq_unmask > nfp_net_dev_interrupt_delayed_handler > nfp_net_rss_reta_write > nfp_net_rss_hash_write > > (I may be missed some, you may want to double check all.) > > Rest of the set looks good to me. > Since rest is OK, I will make above functions static while merging, if they needs to be used by other files they can always be updated again.