From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A0A8B1B847 for <dev@dpdk.org>; Thu, 12 Apr 2018 00:27:33 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 10CDB21680; Wed, 11 Apr 2018 18:27:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 11 Apr 2018 18:27:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=8BPRCrPnGbOIaP0LX8HiqViBT3 QfFWUvu1cGKSnNyyg=; b=GyTRPRde9J3iTt1AahxGg/evdv2jmFrz2mQ/eBdXDX mlj+ID+eL+/dpDd4qVDLreee9Xdaxorta7H12+NTteja42z/KrxrO5pfSmebj2qH k+euA4DzqrwYI1l6Mj5985upkBqnoDM3ByoSkM6Sf0xgODOouao8eTkH4Q1yp8ji Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=8BPRCr PnGbOIaP0LX8HiqViBT3QfFWUvu1cGKSnNyyg=; b=iT7lA8LQHhYsfh0XykQEAa lsUkICh4gJhYJXms1hGukAkRqegeV2OS5oskQTwQgGJ50JtfKcGGByME4DJozZ2u bdqSx6xqwrZqNRIGmi9OuzUBUjJm7dq1apJ2uq3OB1KH+qpXQgqUJLgK/Yj0zdxI 3Y/SOm9/Tqkwz6C7wuWfE7b0826ZcgN3hj0p2zw54C+dhrEyBinmQfXIfdXEnmsE B18ErLk2ZRyVIt/fKrF4X4O68M5CIooF8i1giSjlzftKgS02j/V69cRl9A1850Zs zFjye781DU1iT1V6dyPSgAzZeLGhfTzGi6UX7CydEku5go/ZESuZPQTdK4epFrOg == X-ME-Sender: <xms:1IvOWoG3_5Hos38f_qZL756JA1OdnmK-wePxVLeqMRnHol-Z7edxMg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3E261E4441; Wed, 11 Apr 2018 18:27:32 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Neil Horman <nhorman@tuxdriver.com>, anatoly.burakov@intel.com Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com> Date: Thu, 12 Apr 2018 00:27:31 +0200 Message-ID: <5500696.OPBsZNLSF3@xps> In-Reply-To: <20180402120619.30404-1-nhorman@tuxdriver.com> References: <20180402120619.30404-1-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] linuxapp eal: set fd to -1 for MAP_ANONYMOUS cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 11 Apr 2018 22:27:33 -0000 02/04/2018 14:06, Neil Horman: > https://dpdk.org/tracker/show_bug.cgi?id=18 > > Indicated that several mmap call sites in the linuxapp eal code used an > fd that was not -1 in their calls while using MAP_ANONYMOUS. While > probably not a huge deal, the man page does say the fd should be -1 for > portability, as some implementations don't ignore fd as they should for > MAP_ANONYMOUS, and seting -1 here allows us to eliminate some code. > > Signed-off-by: Neil Horman <nhorman@tuxdriver.com> > CC: Thomas Monjalon <thomas@monjalon.net> > CC: Ferruh Yigit <ferruh.yigit@intel.com> > --- > lib/librte_eal/linuxapp/eal/eal_memory.c | 32 +++++++------------------------- > 1 file changed, 7 insertions(+), 25 deletions(-) This patch probably need a rebase on top of Anatoly's patches. Anatoly, please, could you review?