From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63F3FA04F1; Sun, 24 May 2020 23:24:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C14C1D54D; Sun, 24 May 2020 23:24:44 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 5BFCE1D545 for ; Sun, 24 May 2020 23:24:42 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 295527B7; Sun, 24 May 2020 17:24:41 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 24 May 2020 17:24:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= vtblDnRVVajrtayhM8Oq1r6Cq2kHLAUnOXOQ6yRb0LM=; b=nhcBh9duIywvpK8Q d1PyDsiXrTsxCZRpT2e1pLLiwCj/aRdZyNszHf3hsQgIaKSvvU6768EbWxQDn1eH 6s/6Te+E8v81rnyMxJLU3os33oEK1cHHD/ZuG5DYG6L8FIWZI1HAHW8PwxuyuAu5 bliG7EcbatLOKSbKVYH4hg6Pj74YJTpUV4IYR9HX24le8as+QKLUHT/DmAm/8PgU z4e9G27rG3h/wxGLWn8+iZ7K00TgMZbs3PzrbAaskLX35ThbtKRRgnquIKhiWzQc /KaZNnSV4kppwrM11YJK/m+LgCKbBfD3P1qVop1CB4t9OKYWNXxfulXlFXMXCdR4 aHEkYg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=vtblDnRVVajrtayhM8Oq1r6Cq2kHLAUnOXOQ6yRb0 LM=; b=wfk/Td+h5a3YxPARqNM7PrMWoncnqwSPfuvKBPqjSHMBJY2gqYi1G6ktu cQA6zA58eWcEQekXMHXcuXMxRhrl5IhWgZNsb+PoM4nlfsTece0RTdk6vjUTx+Ie n8+Dug//c1dRrp/sp+yeapnwRJBEYKHYMLMn6cTgl1XBOHWyO6G2ODuuLX9rMxo0 zY3Zpe3SnQ8PKV3q3wcvTBws52oFz2/dsmwqJOeHtpnGPi+Xuy4uibz+STuUFM1w V024/kzZ2k2B92GY9e20K2w/PpoWnTzFWpj07VyFrYg0+HYNtacu1gk2/bwO8i9y ATCu11lSLzf+E+pkonQ0kua5YegUg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddukedgudehlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9B03D3066532; Sun, 24 May 2020 17:24:39 -0400 (EDT) From: Thomas Monjalon To: "A.McLoughlin" , John McNamara , Marko Kovacevic Cc: Olivier Matz , dev@dpdk.org, "Van Haaren, Harry" , Jerin Jacob Date: Sun, 24 May 2020 23:24:38 +0200 Message-ID: <5504161.4p4Js1nEjy@thomas> In-Reply-To: References: <20190823131007.9000-1-aideen.mcloughlin@intel.com> <20191017155848.3kxixqhsv2pd4jvy@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] doc: add graphic showing layout of mbuf struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Any update? 18/10/2019 12:56, Jerin Jacob: > On Thu, Oct 17, 2019 at 9:28 PM Olivier Matz wrote: > > > > Hi, > > > > On Tue, Aug 27, 2019 at 10:02:30AM +0100, A.McLoughlin wrote: > > > This patch adds a graphical overview of the rte_mbuf struct, showing where > > > each value is stored within the struct. > > > > > > Signed-off-by: A.McLoughlin > > > --- > > > v1 -> v2: > > > * changed uint16_t refcnt(+atomic) to uint16_t refcnt > > > v2 -> v3: > > > * added layout of extrenally stored struct rte_mbuf sched sched > > > * added struct names for named structs > > > * made variable names bold for differenciation from types > > > * minor styling changes > > > * specified that graphic represents layout on 64B machine > > > --- > > > doc/guides/prog_guide/img/mbuf_graphic.svg | 6962 ++++++++++++++++++++ > > > doc/guides/prog_guide/mbuf_lib.rst | 12 + > > > 2 files changed, 6974 insertions(+) > > > create mode 100644 doc/guides/prog_guide/img/mbuf_graphic.svg > > > > The diagram is nice, however we have to be careful because it > > has to be kept sync with the code. I tried to edit the svg with > > inkscape, and it seems the text is described as vector shapes, > > which make the diagram impossible to update. > > > > Couldn't it be replaced by the output of pahole? Or better, just explain > > how to generate it in the documentation? The user can then be sure that > > +1 for explaining how to generate it in the documentation as pahole > output varies for the 128B cache line machine. > > > > the information is up to date, matches its architecture, and can also > > check structures other than mbuf.