* [dpdk-dev] [PATCH 0/8] NXP DPAA2 compilation and runtime fixes @ 2017-07-11 14:55 Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 1/8] crypto/dpaa2_sec: remove GCC 7.1 compilation error Hemant Agrawal ` (8 more replies) 0 siblings, 9 replies; 10+ messages in thread From: Hemant Agrawal @ 2017-07-11 14:55 UTC (permalink / raw) To: dev, thomas; +Cc: ferruh.yigit, shreyansh.jain, akhil.goyal This patch series add support for: [1-2] GCC 7.1 compilation issue [3-4] Compilation with all debug mode enabled [5-7] Run time issues obseved over RC1 [8] adding newline char in RTE_LOG Hemant Agrawal (8): crypto/dpaa2_sec: remove GCC 7.1 compilation error net/dpaa2: fix flow control switch case break bus/fslmc: fixes compilation in debug mode event/dpaa2: enable debug mode compilation bus/fslmc: set the dpaa2 device name bus/fslmc: align the object name log to real resource names config: enable virtual IOVA by default for DPAA2 drivers: add newline in RTE LOG usages in dpaa2 config/defconfig_arm64-dpaa2-linuxapp-gcc | 2 +- drivers/bus/fslmc/fslmc_vfio.c | 5 +- drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c | 2 +- drivers/bus/fslmc/portal/dpaa2_hw_dpci.c | 2 +- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 10 ++-- drivers/bus/fslmc/rte_fslmc.h | 1 + drivers/crypto/dpaa2_sec/Makefile | 4 ++ drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 46 ++++++++--------- drivers/event/dpaa2/dpaa2_eventdev.c | 17 +++---- drivers/event/dpaa2/dpaa2_hw_dpcon.c | 2 +- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 12 ++--- drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 10 ++-- drivers/net/dpaa2/dpaa2_ethdev.c | 78 ++++++++++++++--------------- 13 files changed, 99 insertions(+), 92 deletions(-) -- 2.7.4 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH 1/8] crypto/dpaa2_sec: remove GCC 7.1 compilation error 2017-07-11 14:55 [dpdk-dev] [PATCH 0/8] NXP DPAA2 compilation and runtime fixes Hemant Agrawal @ 2017-07-11 14:55 ` Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 2/8] net/dpaa2: fix flow control switch case break Hemant Agrawal ` (7 subsequent siblings) 8 siblings, 0 replies; 10+ messages in thread From: Hemant Agrawal @ 2017-07-11 14:55 UTC (permalink / raw) To: dev, thomas; +Cc: ferruh.yigit, shreyansh.jain, akhil.goyal Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> --- drivers/crypto/dpaa2_sec/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/crypto/dpaa2_sec/Makefile b/drivers/crypto/dpaa2_sec/Makefile index f109115..c2a02ed 100644 --- a/drivers/crypto/dpaa2_sec/Makefile +++ b/drivers/crypto/dpaa2_sec/Makefile @@ -46,6 +46,10 @@ CFLAGS += $(WERROR_FLAGS) endif CFLAGS += -D _GNU_SOURCE +ifeq ($(shell test $(GCC_VERSION) -gt 70 && echo 1), 1) +CFLAGS += -Wno-implicit-fallthrough +endif + CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa2_sec/ CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa2_sec/mc CFLAGS += -I$(RTE_SDK)/drivers/bus/fslmc/ -- 2.7.4 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH 2/8] net/dpaa2: fix flow control switch case break 2017-07-11 14:55 [dpdk-dev] [PATCH 0/8] NXP DPAA2 compilation and runtime fixes Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 1/8] crypto/dpaa2_sec: remove GCC 7.1 compilation error Hemant Agrawal @ 2017-07-11 14:55 ` Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 3/8] bus/fslmc: fixes compilation in debug mode Hemant Agrawal ` (6 subsequent siblings) 8 siblings, 0 replies; 10+ messages in thread From: Hemant Agrawal @ 2017-07-11 14:55 UTC (permalink / raw) To: dev, thomas; +Cc: ferruh.yigit, shreyansh.jain, akhil.goyal Fixes: 977d0006ada1 ("net/dpaa2: add support for flow control") Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> --- drivers/net/dpaa2/dpaa2_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index c19f726..acedc7c 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -1255,6 +1255,7 @@ dpaa2_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf) */ cfg.options |= DPNI_LINK_OPT_PAUSE; cfg.options &= ~DPNI_LINK_OPT_ASYM_PAUSE; + break; case RTE_FC_TX_PAUSE: /* Enable RX flow control * OPT_PAUSE not set; -- 2.7.4 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH 3/8] bus/fslmc: fixes compilation in debug mode 2017-07-11 14:55 [dpdk-dev] [PATCH 0/8] NXP DPAA2 compilation and runtime fixes Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 1/8] crypto/dpaa2_sec: remove GCC 7.1 compilation error Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 2/8] net/dpaa2: fix flow control switch case break Hemant Agrawal @ 2017-07-11 14:55 ` Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 4/8] event/dpaa2: enable debug mode compilation Hemant Agrawal ` (5 subsequent siblings) 8 siblings, 0 replies; 10+ messages in thread From: Hemant Agrawal @ 2017-07-11 14:55 UTC (permalink / raw) To: dev, thomas; +Cc: ferruh.yigit, shreyansh.jain, akhil.goyal Fixes: 9ccb76b24c1d ("bus/fslmc: enable portal interrupt handling") Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c index 88dd2e9..5cf5cfe 100644 --- a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c +++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c @@ -122,7 +122,7 @@ static void dpaa2_affine_dpio_intr_to_respective_core(int32_t dpio_id) snprintf(string, STRING_LEN, "dpio.%d", dpio_id); file = fopen("/proc/interrupts", "r"); if (!file) { - PMD_DRV_LOG(WARN, "Failed to open /proc/interrupts file\n"); + PMD_DRV_LOG(WARNING, "Failed to open /proc/interrupts file\n"); return; } while (getline(&temp, &len, file) != -1) { @@ -133,7 +133,7 @@ static void dpaa2_affine_dpio_intr_to_respective_core(int32_t dpio_id) } if (!token) { - PMD_DRV_LOG(WARN, "Failed to get interrupt id for dpio.%d\n", + PMD_DRV_LOG(WARNING, "Failed to get interrupt id for dpio.%d\n", dpio_id); if (temp) free(temp); @@ -146,10 +146,10 @@ static void dpaa2_affine_dpio_intr_to_respective_core(int32_t dpio_id) cpu_mask, token); ret = system(command); if (ret < 0) - PMD_DRV_LOG(WARN, + PMD_DRV_LOG(WARNING, "Failed to affine interrupts on respective core\n"); else - PMD_DRV_LOG(WARN, " %s command is executed\n", command); + PMD_DRV_LOG(WARNING, " %s command is executed\n", command); free(temp); fclose(file); -- 2.7.4 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH 4/8] event/dpaa2: enable debug mode compilation 2017-07-11 14:55 [dpdk-dev] [PATCH 0/8] NXP DPAA2 compilation and runtime fixes Hemant Agrawal ` (2 preceding siblings ...) 2017-07-11 14:55 ` [dpdk-dev] [PATCH 3/8] bus/fslmc: fixes compilation in debug mode Hemant Agrawal @ 2017-07-11 14:55 ` Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 5/8] bus/fslmc: set the dpaa2 device name Hemant Agrawal ` (4 subsequent siblings) 8 siblings, 0 replies; 10+ messages in thread From: Hemant Agrawal @ 2017-07-11 14:55 UTC (permalink / raw) To: dev, thomas; +Cc: ferruh.yigit, shreyansh.jain, akhil.goyal Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> --- drivers/event/dpaa2/dpaa2_eventdev.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index 412cee1..ff11618 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.c +++ b/drivers/event/dpaa2/dpaa2_eventdev.c @@ -93,7 +93,7 @@ dpaa2_eventdev_enqueue_burst(void *port, const struct rte_event ev[], if (unlikely(!DPAA2_PER_LCORE_DPIO)) { ret = dpaa2_affine_qbman_swp(); if (ret) { - PMD_DRV_LOG(ERR, PMD, "Failure in affining portal\n"); + PMD_DRV_LOG(ERR, "Failure in affining portal\n"); return 0; } } @@ -179,10 +179,9 @@ static void dpaa2_eventdev_dequeue_wait(uint64_t timeout_ticks) * case to avoid the problem. */ if (errno == EINTR) { - PMD_DRV_LOG(DEBUG, PMD, "epoll_wait fails\n"); + PMD_DRV_LOG(DEBUG, "epoll_wait fails\n"); if (i++ > 10) - PMD_DRV_LOG(DEBUG, PMD, - "Dequeue burst Failed\n"); + PMD_DRV_LOG(DEBUG, "Dequeue burst Failed\n"); goto RETRY; } } @@ -234,7 +233,7 @@ dpaa2_eventdev_dequeue_burst(void *port, struct rte_event ev[], if (unlikely(!DPAA2_PER_LCORE_DPIO)) { ret = dpaa2_affine_qbman_swp(); if (ret) { - PMD_DRV_LOG(ERR, PMD, "Failure in affining portal\n"); + PMD_DRV_LOG(ERR, "Failure in affining portal\n"); return 0; } } @@ -270,7 +269,7 @@ dpaa2_eventdev_dequeue_burst(void *port, struct rte_event ev[], rxq->cb(swp, fd, dq, &ev[num_pkts]); } else { qbman_swp_dqrr_consume(swp, dq); - PMD_DRV_LOG(ERR, PMD, "Null Return VQ received\n"); + PMD_DRV_LOG(ERR, "Null Return VQ received\n"); return 0; } @@ -596,7 +595,7 @@ dpaa2_eventdev_setup_dpci(struct dpaa2_dpci_dev *dpci_dev, dpci_dev->token, i, &rx_queue_cfg); if (ret) { - PMD_DRV_LOG(ERR, PMD, + PMD_DRV_LOG(ERR, "set_rx_q failed with err code: %d", ret); return ret; } @@ -652,7 +651,7 @@ dpaa2_eventdev_create(const char *name) ret = dpaa2_eventdev_setup_dpci(dpci_dev, dpcon_dev); if (ret) { - PMD_DRV_LOG(ERR, PMD, + PMD_DRV_LOG(ERR, "dpci setup failed with err code: %d", ret); return ret; } @@ -670,7 +669,7 @@ dpaa2_eventdev_probe(struct rte_vdev_device *vdev) const char *name; name = rte_vdev_device_name(vdev); - PMD_DRV_LOG(INFO, PMD, "Initializing %s\n", name); + PMD_DRV_LOG(INFO, "Initializing %s", name); return dpaa2_eventdev_create(name); } -- 2.7.4 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH 5/8] bus/fslmc: set the dpaa2 device name 2017-07-11 14:55 [dpdk-dev] [PATCH 0/8] NXP DPAA2 compilation and runtime fixes Hemant Agrawal ` (3 preceding siblings ...) 2017-07-11 14:55 ` [dpdk-dev] [PATCH 4/8] event/dpaa2: enable debug mode compilation Hemant Agrawal @ 2017-07-11 14:55 ` Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 6/8] bus/fslmc: align the object name log to real resource names Hemant Agrawal ` (3 subsequent siblings) 8 siblings, 0 replies; 10+ messages in thread From: Hemant Agrawal @ 2017-07-11 14:55 UTC (permalink / raw) To: dev, thomas; +Cc: ferruh.yigit, shreyansh.jain, akhil.goyal rte_eth_dev_allocated expect the device name to be filled. Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> --- drivers/bus/fslmc/fslmc_vfio.c | 5 +++-- drivers/bus/fslmc/rte_fslmc.h | 1 + drivers/net/dpaa2/dpaa2_ethdev.c | 6 +----- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c index 725faab..edd9a73 100644 --- a/drivers/bus/fslmc/fslmc_vfio.c +++ b/drivers/bus/fslmc/fslmc_vfio.c @@ -551,10 +551,11 @@ int fslmc_vfio_process_group(void) dev->dev_type = (strcmp(object_type, "dpseci")) ? DPAA2_MC_DPNI_DEVID : DPAA2_MC_DPSECI_DEVID; - FSLMC_VFIO_LOG(DEBUG, "DPAA2: Added [%s-%d]", - object_type, object_id); + sprintf(dev->name, "%s.%d", object_type, object_id); + dev->device.name = dev->name; fslmc_bus_add_device(dev); + FSLMC_VFIO_LOG(DEBUG, "DPAA2: Added %s", dev->name); } else { /* Parse all other objects */ struct rte_dpaa2_object *object; diff --git a/drivers/bus/fslmc/rte_fslmc.h b/drivers/bus/fslmc/rte_fslmc.h index 4b69d38..e60d6eb 100644 --- a/drivers/bus/fslmc/rte_fslmc.h +++ b/drivers/bus/fslmc/rte_fslmc.h @@ -78,6 +78,7 @@ struct rte_dpaa2_device { uint16_t object_id; /**< DPAA2 Object ID */ struct rte_intr_handle intr_handle; /**< Interrupt handle */ struct rte_dpaa2_driver *driver; /**< Associated driver */ + char name[32]; /**< DPAA2 Object name*/ }; typedef int (*rte_dpaa2_probe_t)(struct rte_dpaa2_driver *dpaa2_drv, diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index acedc7c..9666d9d 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -1531,13 +1531,9 @@ rte_dpaa2_probe(struct rte_dpaa2_driver *dpaa2_drv, struct rte_dpaa2_device *dpaa2_dev) { struct rte_eth_dev *eth_dev; - char ethdev_name[RTE_ETH_NAME_MAX_LEN]; - int diag; - sprintf(ethdev_name, "dpni-%d", dpaa2_dev->object_id); - - eth_dev = rte_eth_dev_allocate(ethdev_name); + eth_dev = rte_eth_dev_allocate(dpaa2_dev->device.name); if (eth_dev == NULL) return -ENOMEM; -- 2.7.4 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH 6/8] bus/fslmc: align the object name log to real resource names 2017-07-11 14:55 [dpdk-dev] [PATCH 0/8] NXP DPAA2 compilation and runtime fixes Hemant Agrawal ` (4 preceding siblings ...) 2017-07-11 14:55 ` [dpdk-dev] [PATCH 5/8] bus/fslmc: set the dpaa2 device name Hemant Agrawal @ 2017-07-11 14:55 ` Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 7/8] config: enable virtual IOVA by default for DPAA2 Hemant Agrawal ` (2 subsequent siblings) 8 siblings, 0 replies; 10+ messages in thread From: Hemant Agrawal @ 2017-07-11 14:55 UTC (permalink / raw) To: dev, thomas; +Cc: ferruh.yigit, shreyansh.jain, akhil.goyal the DPAA2 resources are named with ".", so changing "-" with "." Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> --- drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c | 2 +- drivers/bus/fslmc/portal/dpaa2_hw_dpci.c | 2 +- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 2 +- drivers/event/dpaa2/dpaa2_hw_dpcon.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c index daec414..33f9eed 100644 --- a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c +++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c @@ -98,7 +98,7 @@ dpaa2_create_dpbp_device(struct fslmc_vfio_device *vdev __rte_unused, TAILQ_INSERT_TAIL(&dpbp_dev_list, dpbp_node, next); - PMD_INIT_LOG(DEBUG, "DPAA2: Added [dpbp-%d]", dpbp_id); + PMD_INIT_LOG(DEBUG, "DPAA2: Added [dpbp.%d]", dpbp_id); return 0; } diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpci.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpci.c index d222f26..478e4f7 100644 --- a/drivers/bus/fslmc/portal/dpaa2_hw_dpci.c +++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpci.c @@ -140,7 +140,7 @@ rte_dpaa2_create_dpci_device(struct fslmc_vfio_device *vdev __rte_unused, TAILQ_INSERT_TAIL(&dpci_dev_list, dpci_node, next); - PMD_INIT_LOG(DEBUG, "DPAA2: Added [dpci-%d]", dpci_id); + PMD_INIT_LOG(DEBUG, "DPAA2: Added [dpci.%d]", dpci_id); return 0; } diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c index 5cf5cfe..ffe9396 100644 --- a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c +++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c @@ -503,7 +503,7 @@ dpaa2_create_dpio_device(struct fslmc_vfio_device *vdev, io_space_count++; dpio_dev->index = io_space_count; TAILQ_INSERT_TAIL(&dpio_dev_list, dpio_dev, next); - PMD_INIT_LOG(DEBUG, "DPAA2: Added [dpio-%d]", object_id); + PMD_INIT_LOG(DEBUG, "DPAA2: Added [dpio.%d]", object_id); return 0; } diff --git a/drivers/event/dpaa2/dpaa2_hw_dpcon.c b/drivers/event/dpaa2/dpaa2_hw_dpcon.c index 27f5bcb..d3e73f9 100644 --- a/drivers/event/dpaa2/dpaa2_hw_dpcon.c +++ b/drivers/event/dpaa2/dpaa2_hw_dpcon.c @@ -100,7 +100,7 @@ rte_dpaa2_create_dpcon_device(struct fslmc_vfio_device *vdev __rte_unused, TAILQ_INSERT_TAIL(&dpcon_dev_list, dpcon_node, next); - PMD_DRV_LOG(DEBUG, "DPAA2: Added [dpcon-%d]", dpcon_id); + PMD_DRV_LOG(DEBUG, "DPAA2: Added [dpcon.%d]", dpcon_id); return 0; } -- 2.7.4 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH 7/8] config: enable virtual IOVA by default for DPAA2 2017-07-11 14:55 [dpdk-dev] [PATCH 0/8] NXP DPAA2 compilation and runtime fixes Hemant Agrawal ` (5 preceding siblings ...) 2017-07-11 14:55 ` [dpdk-dev] [PATCH 6/8] bus/fslmc: align the object name log to real resource names Hemant Agrawal @ 2017-07-11 14:55 ` Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 8/8] drivers: add newline in RTE LOG usages in dpaa2 Hemant Agrawal 2017-07-14 13:49 ` [dpdk-dev] [PATCH 0/8] NXP DPAA2 compilation and runtime fixes Thomas Monjalon 8 siblings, 0 replies; 10+ messages in thread From: Hemant Agrawal @ 2017-07-11 14:55 UTC (permalink / raw) To: dev, thomas; +Cc: ferruh.yigit, shreyansh.jain, akhil.goyal Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> --- config/defconfig_arm64-dpaa2-linuxapp-gcc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/defconfig_arm64-dpaa2-linuxapp-gcc b/config/defconfig_arm64-dpaa2-linuxapp-gcc index d807ed3..8a42944 100644 --- a/config/defconfig_arm64-dpaa2-linuxapp-gcc +++ b/config/defconfig_arm64-dpaa2-linuxapp-gcc @@ -54,7 +54,7 @@ CONFIG_RTE_LIBRTE_VHOST_NUMA=n # CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=y CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS="dpaa2" -CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=y +CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=n # # Compile NXP DPAA2 FSL-MC Bus -- 2.7.4 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH 8/8] drivers: add newline in RTE LOG usages in dpaa2 2017-07-11 14:55 [dpdk-dev] [PATCH 0/8] NXP DPAA2 compilation and runtime fixes Hemant Agrawal ` (6 preceding siblings ...) 2017-07-11 14:55 ` [dpdk-dev] [PATCH 7/8] config: enable virtual IOVA by default for DPAA2 Hemant Agrawal @ 2017-07-11 14:55 ` Hemant Agrawal 2017-07-14 13:49 ` [dpdk-dev] [PATCH 0/8] NXP DPAA2 compilation and runtime fixes Thomas Monjalon 8 siblings, 0 replies; 10+ messages in thread From: Hemant Agrawal @ 2017-07-11 14:55 UTC (permalink / raw) To: dev, thomas; +Cc: ferruh.yigit, shreyansh.jain, akhil.goyal Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 46 +++++++++---------- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 12 ++--- drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 10 ++-- drivers/net/dpaa2/dpaa2_ethdev.c | 71 +++++++++++++++-------------- 4 files changed, 72 insertions(+), 67 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index 9fc9dea..d6c3088 100644 --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c @@ -669,7 +669,7 @@ sec_fd_to_mbuf(const struct qbman_fd *fd) if (unlikely(DPAA2_GET_FD_IVP(fd))) { /* TODO complete it. */ - RTE_LOG(ERR, PMD, "error: Non inline buffer - WHAT to DO?"); + RTE_LOG(ERR, PMD, "error: Non inline buffer - WHAT to DO?\n"); return NULL; } op = (struct rte_crypto_op *)DPAA2_IOVA_TO_VADDR( @@ -731,8 +731,8 @@ dpaa2_sec_dequeue_burst(void *qp, struct rte_crypto_op **ops, /*Issue a volatile dequeue command. */ while (1) { if (qbman_swp_pull(swp, &pulldesc)) { - RTE_LOG(WARNING, PMD, "SEC VDQ command is not issued." - "QBMAN is busy\n"); + RTE_LOG(WARNING, PMD, + "SEC VDQ command is not issued : QBMAN busy\n"); /* Portal was busy, try again */ continue; } @@ -926,7 +926,7 @@ dpaa2_sec_cipher_init(struct rte_cryptodev *dev, sizeof(struct ctxt_priv) + sizeof(struct sec_flc_desc), RTE_CACHE_LINE_SIZE); if (priv == NULL) { - RTE_LOG(ERR, PMD, "No Memory for priv CTXT"); + RTE_LOG(ERR, PMD, "No Memory for priv CTXT\n"); return -1; } @@ -937,7 +937,7 @@ dpaa2_sec_cipher_init(struct rte_cryptodev *dev, session->cipher_key.data = rte_zmalloc(NULL, xform->cipher.key.length, RTE_CACHE_LINE_SIZE); if (session->cipher_key.data == NULL) { - RTE_LOG(ERR, PMD, "No Memory for cipher key"); + RTE_LOG(ERR, PMD, "No Memory for cipher key\n"); rte_free(priv); return -1; } @@ -980,7 +980,7 @@ dpaa2_sec_cipher_init(struct rte_cryptodev *dev, case RTE_CRYPTO_CIPHER_SNOW3G_UEA2: case RTE_CRYPTO_CIPHER_ZUC_EEA3: case RTE_CRYPTO_CIPHER_NULL: - RTE_LOG(ERR, PMD, "Crypto: Unsupported Cipher alg %u", + RTE_LOG(ERR, PMD, "Crypto: Unsupported Cipher alg %u\n", xform->cipher.algo); goto error_out; default: @@ -1042,7 +1042,7 @@ dpaa2_sec_auth_init(struct rte_cryptodev *dev, sizeof(struct sec_flc_desc), RTE_CACHE_LINE_SIZE); if (priv == NULL) { - RTE_LOG(ERR, PMD, "No Memory for priv CTXT"); + RTE_LOG(ERR, PMD, "No Memory for priv CTXT\n"); return -1; } @@ -1052,7 +1052,7 @@ dpaa2_sec_auth_init(struct rte_cryptodev *dev, session->auth_key.data = rte_zmalloc(NULL, xform->auth.key.length, RTE_CACHE_LINE_SIZE); if (session->auth_key.data == NULL) { - RTE_LOG(ERR, PMD, "No Memory for auth key"); + RTE_LOG(ERR, PMD, "No Memory for auth key\n"); rte_free(priv); return -1; } @@ -1112,7 +1112,7 @@ dpaa2_sec_auth_init(struct rte_cryptodev *dev, case RTE_CRYPTO_AUTH_AES_CMAC: case RTE_CRYPTO_AUTH_AES_CBC_MAC: case RTE_CRYPTO_AUTH_ZUC_EIA3: - RTE_LOG(ERR, PMD, "Crypto: Unsupported auth alg %u", + RTE_LOG(ERR, PMD, "Crypto: Unsupported auth alg %u\n", xform->auth.algo); goto error_out; default: @@ -1174,7 +1174,7 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev, sizeof(struct ctxt_priv) + sizeof(struct sec_flc_desc), RTE_CACHE_LINE_SIZE); if (priv == NULL) { - RTE_LOG(ERR, PMD, "No Memory for priv CTXT"); + RTE_LOG(ERR, PMD, "No Memory for priv CTXT\n"); return -1; } @@ -1184,7 +1184,7 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev, session->aead_key.data = rte_zmalloc(NULL, aead_xform->key.length, RTE_CACHE_LINE_SIZE); if (session->aead_key.data == NULL && aead_xform->key.length > 0) { - RTE_LOG(ERR, PMD, "No Memory for aead key"); + RTE_LOG(ERR, PMD, "No Memory for aead key\n"); rte_free(priv); return -1; } @@ -1207,7 +1207,7 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev, session->cipher_alg = RTE_CRYPTO_AEAD_AES_GCM; break; case RTE_CRYPTO_AEAD_AES_CCM: - RTE_LOG(ERR, PMD, "Crypto: Unsupported AEAD alg %u", + RTE_LOG(ERR, PMD, "Crypto: Unsupported AEAD alg %u\n", aead_xform->algo); goto error_out; default: @@ -1225,7 +1225,7 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev, &priv->flc_desc[0].desc[1], 1); if (err < 0) { - PMD_DRV_LOG(ERR, "Crypto: Incorrect key lengths"); + PMD_DRV_LOG(ERR, "Crypto: Incorrect key lengths\n"); goto error_out; } if (priv->flc_desc[0].desc[1] & 1) { @@ -1308,7 +1308,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev, sizeof(struct ctxt_priv) + sizeof(struct sec_flc_desc), RTE_CACHE_LINE_SIZE); if (priv == NULL) { - RTE_LOG(ERR, PMD, "No Memory for priv CTXT"); + RTE_LOG(ERR, PMD, "No Memory for priv CTXT\n"); return -1; } @@ -1318,7 +1318,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev, session->cipher_key.data = rte_zmalloc(NULL, cipher_xform->key.length, RTE_CACHE_LINE_SIZE); if (session->cipher_key.data == NULL && cipher_xform->key.length > 0) { - RTE_LOG(ERR, PMD, "No Memory for cipher key"); + RTE_LOG(ERR, PMD, "No Memory for cipher key\n"); rte_free(priv); return -1; } @@ -1326,7 +1326,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev, session->auth_key.data = rte_zmalloc(NULL, auth_xform->key.length, RTE_CACHE_LINE_SIZE); if (session->auth_key.data == NULL && auth_xform->key.length > 0) { - RTE_LOG(ERR, PMD, "No Memory for auth key"); + RTE_LOG(ERR, PMD, "No Memory for auth key\n"); rte_free(session->cipher_key.data); rte_free(priv); return -1; @@ -1389,7 +1389,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev, case RTE_CRYPTO_AUTH_AES_CMAC: case RTE_CRYPTO_AUTH_AES_CBC_MAC: case RTE_CRYPTO_AUTH_ZUC_EIA3: - RTE_LOG(ERR, PMD, "Crypto: Unsupported auth alg %u", + RTE_LOG(ERR, PMD, "Crypto: Unsupported auth alg %u\n", auth_xform->algo); goto error_out; default: @@ -1423,7 +1423,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev, case RTE_CRYPTO_CIPHER_3DES_ECB: case RTE_CRYPTO_CIPHER_AES_ECB: case RTE_CRYPTO_CIPHER_KASUMI_F8: - RTE_LOG(ERR, PMD, "Crypto: Unsupported Cipher alg %u", + RTE_LOG(ERR, PMD, "Crypto: Unsupported Cipher alg %u\n", cipher_xform->algo); goto error_out; default: @@ -1442,7 +1442,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev, &priv->flc_desc[0].desc[2], 2); if (err < 0) { - PMD_DRV_LOG(ERR, "Crypto: Incorrect key lengths"); + PMD_DRV_LOG(ERR, "Crypto: Incorrect key lengths\n"); goto error_out; } if (priv->flc_desc[0].desc[2] & 1) { @@ -1469,7 +1469,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev, session->digest_length, session->dir); } else { - RTE_LOG(ERR, PMD, "Hash before cipher not supported"); + RTE_LOG(ERR, PMD, "Hash before cipher not supported\n"); goto error_out; } @@ -1503,7 +1503,7 @@ dpaa2_sec_set_session_parameters(struct rte_cryptodev *dev, PMD_INIT_FUNC_TRACE(); if (unlikely(sess == NULL)) { - RTE_LOG(ERR, PMD, "invalid session struct"); + RTE_LOG(ERR, PMD, "invalid session struct\n"); return -1; } @@ -1539,7 +1539,7 @@ dpaa2_sec_set_session_parameters(struct rte_cryptodev *dev, dpaa2_sec_aead_init(dev, xform, session); } else { - RTE_LOG(ERR, PMD, "Invalid crypto type"); + RTE_LOG(ERR, PMD, "Invalid crypto type\n"); return -1; } @@ -1910,7 +1910,7 @@ dpaa2_sec_dev_init(struct rte_cryptodev *cryptodev) NULL, NULL, NULL, NULL, SOCKET_ID_ANY, 0); if (!internals->fle_pool) { - RTE_LOG(ERR, PMD, "%s create failed", str); + RTE_LOG(ERR, PMD, "%s create failed\n", str); goto init_error; } else RTE_LOG(INFO, PMD, "%s created: %p\n", str, diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c index d578c2f..973b9d4 100644 --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c @@ -188,7 +188,7 @@ rte_dpaa2_mbuf_release(struct rte_mempool *pool __rte_unused, if (unlikely(!DPAA2_PER_LCORE_DPIO)) { ret = dpaa2_affine_qbman_swp(); if (ret != 0) { - RTE_LOG(ERR, PMD, "Failed to allocate IO portal"); + RTE_LOG(ERR, PMD, "Failed to allocate IO portal\n"); return; } } @@ -267,7 +267,7 @@ rte_dpaa2_mbuf_alloc_bulk(struct rte_mempool *pool, if (unlikely(!DPAA2_PER_LCORE_DPIO)) { ret = dpaa2_affine_qbman_swp(); if (ret != 0) { - RTE_LOG(ERR, PMD, "Failed to allocate IO portal"); + RTE_LOG(ERR, PMD, "Failed to allocate IO portal\n"); return ret; } } @@ -323,7 +323,7 @@ rte_hw_mbuf_free_bulk(struct rte_mempool *pool, bp_info = mempool_to_bpinfo(pool); if (!(bp_info->bp_list)) { - RTE_LOG(ERR, PMD, "DPAA2 buffer pool not configured"); + RTE_LOG(ERR, PMD, "DPAA2 buffer pool not configured\n"); return -ENOENT; } rte_dpaa2_mbuf_release(pool, obj_table, bp_info->bpid, @@ -341,7 +341,7 @@ rte_hw_mbuf_get_count(const struct rte_mempool *mp) struct dpaa2_dpbp_dev *dpbp_node; if (!mp || !mp->pool_data) { - RTE_LOG(ERR, PMD, "Invalid mempool provided"); + RTE_LOG(ERR, PMD, "Invalid mempool provided\n"); return 0; } @@ -351,12 +351,12 @@ rte_hw_mbuf_get_count(const struct rte_mempool *mp) ret = dpbp_get_num_free_bufs(&dpbp_node->dpbp, CMD_PRI_LOW, dpbp_node->token, &num_of_bufs); if (ret) { - RTE_LOG(ERR, PMD, "Unable to obtain free buf count (err=%d)", + RTE_LOG(ERR, PMD, "Unable to obtain free buf count (err=%d)\n", ret); return 0; } - RTE_LOG(DEBUG, PMD, "Free bufs = %u", num_of_bufs); + RTE_LOG(DEBUG, PMD, "Free bufs = %u\n", num_of_bufs); return num_of_bufs; } diff --git a/drivers/net/dpaa2/base/dpaa2_hw_dpni.c b/drivers/net/dpaa2/base/dpaa2_hw_dpni.c index f3ac069..5aa12db 100644 --- a/drivers/net/dpaa2/base/dpaa2_hw_dpni.c +++ b/drivers/net/dpaa2/base/dpaa2_hw_dpni.c @@ -91,8 +91,9 @@ dpaa2_setup_flow_dist(struct rte_eth_dev *eth_dev, &tc_cfg); rte_free(p_params); if (ret) { - RTE_LOG(ERR, PMD, "Setting distribution for Rx failed with" - " err code: %d\n", ret); + RTE_LOG(ERR, PMD, + "Setting distribution for Rx failed with err: %d\n", + ret); return ret; } @@ -134,8 +135,9 @@ int dpaa2_remove_flow_dist( &tc_cfg); rte_free(p_params); if (ret) { - RTE_LOG(ERR, PMD, "Setting distribution for Rx failed with" - " err code: %d\n", ret); + RTE_LOG(ERR, PMD, + "Setting distribution for Rx failed with err: %d\n", + ret); return ret; } return ret; diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 9666d9d..44a5bc2 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -121,7 +121,7 @@ dpaa2_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on) PMD_INIT_FUNC_TRACE(); if (dpni == NULL) { - RTE_LOG(ERR, PMD, "dpni is NULL"); + RTE_LOG(ERR, PMD, "dpni is NULL\n"); return -1; } @@ -156,7 +156,7 @@ dpaa2_vlan_offload_set(struct rte_eth_dev *dev, int mask) ret = dpni_enable_vlan_filter(dpni, CMD_PRI_LOW, priv->token, false); if (ret < 0) - RTE_LOG(ERR, PMD, "Unable to set vlan filter ret = %d", + RTE_LOG(ERR, PMD, "Unable to set vlan filter = %d\n", ret); } } @@ -721,17 +721,17 @@ dpaa2_dev_promiscuous_enable( PMD_INIT_FUNC_TRACE(); if (dpni == NULL) { - RTE_LOG(ERR, PMD, "dpni is NULL"); + RTE_LOG(ERR, PMD, "dpni is NULL\n"); return; } ret = dpni_set_unicast_promisc(dpni, CMD_PRI_LOW, priv->token, true); if (ret < 0) - RTE_LOG(ERR, PMD, "Unable to enable U promisc mode %d", ret); + RTE_LOG(ERR, PMD, "Unable to enable U promisc mode %d\n", ret); ret = dpni_set_multicast_promisc(dpni, CMD_PRI_LOW, priv->token, true); if (ret < 0) - RTE_LOG(ERR, PMD, "Unable to enable M promisc mode %d", ret); + RTE_LOG(ERR, PMD, "Unable to enable M promisc mode %d\n", ret); } static void @@ -745,19 +745,20 @@ dpaa2_dev_promiscuous_disable( PMD_INIT_FUNC_TRACE(); if (dpni == NULL) { - RTE_LOG(ERR, PMD, "dpni is NULL"); + RTE_LOG(ERR, PMD, "dpni is NULL\n"); return; } ret = dpni_set_unicast_promisc(dpni, CMD_PRI_LOW, priv->token, false); if (ret < 0) - RTE_LOG(ERR, PMD, "Unable to disable U promisc mode %d", ret); + RTE_LOG(ERR, PMD, "Unable to disable U promisc mode %d\n", ret); if (dev->data->all_multicast == 0) { ret = dpni_set_multicast_promisc(dpni, CMD_PRI_LOW, priv->token, false); if (ret < 0) - RTE_LOG(ERR, PMD, "Unable to disable M promisc mode %d", + RTE_LOG(ERR, PMD, + "Unable to disable M promisc mode %d\n", ret); } } @@ -773,13 +774,13 @@ dpaa2_dev_allmulticast_enable( PMD_INIT_FUNC_TRACE(); if (dpni == NULL) { - RTE_LOG(ERR, PMD, "dpni is NULL"); + RTE_LOG(ERR, PMD, "dpni is NULL\n"); return; } ret = dpni_set_multicast_promisc(dpni, CMD_PRI_LOW, priv->token, true); if (ret < 0) - RTE_LOG(ERR, PMD, "Unable to enable multicast mode %d", ret); + RTE_LOG(ERR, PMD, "Unable to enable multicast mode %d\n", ret); } static void @@ -792,7 +793,7 @@ dpaa2_dev_allmulticast_disable(struct rte_eth_dev *dev) PMD_INIT_FUNC_TRACE(); if (dpni == NULL) { - RTE_LOG(ERR, PMD, "dpni is NULL"); + RTE_LOG(ERR, PMD, "dpni is NULL\n"); return; } @@ -802,7 +803,7 @@ dpaa2_dev_allmulticast_disable(struct rte_eth_dev *dev) ret = dpni_set_multicast_promisc(dpni, CMD_PRI_LOW, priv->token, false); if (ret < 0) - RTE_LOG(ERR, PMD, "Unable to disable multicast mode %d", ret); + RTE_LOG(ERR, PMD, "Unable to disable multicast mode %d\n", ret); } static int @@ -816,7 +817,7 @@ dpaa2_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) PMD_INIT_FUNC_TRACE(); if (dpni == NULL) { - RTE_LOG(ERR, PMD, "dpni is NULL"); + RTE_LOG(ERR, PMD, "dpni is NULL\n"); return -EINVAL; } @@ -855,15 +856,15 @@ dpaa2_dev_add_mac_addr(struct rte_eth_dev *dev, PMD_INIT_FUNC_TRACE(); if (dpni == NULL) { - RTE_LOG(ERR, PMD, "dpni is NULL"); + RTE_LOG(ERR, PMD, "dpni is NULL\n"); return -1; } ret = dpni_add_mac_addr(dpni, CMD_PRI_LOW, priv->token, addr->addr_bytes); if (ret) - RTE_LOG(ERR, PMD, "error: Adding the MAC ADDR failed:" - " err = %d", ret); + RTE_LOG(ERR, PMD, + "error: Adding the MAC ADDR failed: err = %d\n", ret); return 0; } @@ -882,15 +883,15 @@ dpaa2_dev_remove_mac_addr(struct rte_eth_dev *dev, macaddr = &data->mac_addrs[index]; if (dpni == NULL) { - RTE_LOG(ERR, PMD, "dpni is NULL"); + RTE_LOG(ERR, PMD, "dpni is NULL\n"); return; } ret = dpni_remove_mac_addr(dpni, CMD_PRI_LOW, priv->token, macaddr->addr_bytes); if (ret) - RTE_LOG(ERR, PMD, "error: Removing the MAC ADDR failed:" - " err = %d", ret); + RTE_LOG(ERR, PMD, + "error: Removing the MAC ADDR failed: err = %d\n", ret); } static void @@ -904,7 +905,7 @@ dpaa2_dev_set_mac_addr(struct rte_eth_dev *dev, PMD_INIT_FUNC_TRACE(); if (dpni == NULL) { - RTE_LOG(ERR, PMD, "dpni is NULL"); + RTE_LOG(ERR, PMD, "dpni is NULL\n"); return; } @@ -912,7 +913,8 @@ dpaa2_dev_set_mac_addr(struct rte_eth_dev *dev, priv->token, addr->addr_bytes); if (ret) - RTE_LOG(ERR, PMD, "error: Setting the MAC ADDR failed %d", ret); + RTE_LOG(ERR, PMD, + "error: Setting the MAC ADDR failed %d\n", ret); } static void dpaa2_dev_stats_get(struct rte_eth_dev *dev, @@ -929,12 +931,12 @@ void dpaa2_dev_stats_get(struct rte_eth_dev *dev, PMD_INIT_FUNC_TRACE(); if (!dpni) { - RTE_LOG(ERR, PMD, "dpni is NULL"); + RTE_LOG(ERR, PMD, "dpni is NULL\n"); return; } if (!stats) { - RTE_LOG(ERR, PMD, "stats is NULL"); + RTE_LOG(ERR, PMD, "stats is NULL\n"); return; } @@ -987,7 +989,7 @@ void dpaa2_dev_stats_reset(struct rte_eth_dev *dev) PMD_INIT_FUNC_TRACE(); if (dpni == NULL) { - RTE_LOG(ERR, PMD, "dpni is NULL"); + RTE_LOG(ERR, PMD, "dpni is NULL\n"); return; } @@ -1016,7 +1018,7 @@ dpaa2_dev_link_update(struct rte_eth_dev *dev, PMD_INIT_FUNC_TRACE(); if (dpni == NULL) { - RTE_LOG(ERR, PMD, "error : dpni is NULL"); + RTE_LOG(ERR, PMD, "dpni is NULL\n"); return 0; } memset(&old, 0, sizeof(old)); @@ -1024,7 +1026,7 @@ dpaa2_dev_link_update(struct rte_eth_dev *dev, ret = dpni_get_link_state(dpni, CMD_PRI_LOW, priv->token, &state); if (ret < 0) { - RTE_LOG(ERR, PMD, "error: dpni_get_link_state %d", ret); + RTE_LOG(ERR, PMD, "error: dpni_get_link_state %d\n", ret); return -1; } @@ -1069,7 +1071,7 @@ dpaa2_dev_set_link_up(struct rte_eth_dev *dev) dpni = (struct fsl_mc_io *)priv->hw; if (dpni == NULL) { - RTE_LOG(ERR, PMD, "Device has not yet been configured"); + RTE_LOG(ERR, PMD, "DPNI is NULL\n"); return ret; } @@ -1116,7 +1118,7 @@ dpaa2_dev_set_link_down(struct rte_eth_dev *dev) dpni = (struct fsl_mc_io *)priv->hw; if (dpni == NULL) { - RTE_LOG(ERR, PMD, "Device has not yet been configured"); + RTE_LOG(ERR, PMD, "Device has not yet been configured\n"); return ret; } @@ -1170,13 +1172,13 @@ dpaa2_flow_ctrl_get(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf) dpni = (struct fsl_mc_io *)priv->hw; if (dpni == NULL || fc_conf == NULL) { - RTE_LOG(ERR, PMD, "device not configured"); + RTE_LOG(ERR, PMD, "device not configured\n"); return ret; } ret = dpni_get_link_state(dpni, CMD_PRI_LOW, priv->token, &state); if (ret) { - RTE_LOG(ERR, PMD, "error: dpni_get_link_state %d", ret); + RTE_LOG(ERR, PMD, "error: dpni_get_link_state %d\n", ret); return ret; } @@ -1226,7 +1228,7 @@ dpaa2_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf) dpni = (struct fsl_mc_io *)priv->hw; if (dpni == NULL) { - RTE_LOG(ERR, PMD, "dpni is NULL"); + RTE_LOG(ERR, PMD, "dpni is NULL\n"); return ret; } @@ -1236,7 +1238,7 @@ dpaa2_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf) */ ret = dpni_get_link_state(dpni, CMD_PRI_LOW, priv->token, &state); if (ret) { - RTE_LOG(ERR, PMD, "Unable to get link state (err=%d)", ret); + RTE_LOG(ERR, PMD, "Unable to get link state (err=%d)\n", ret); return -1; } @@ -1281,14 +1283,15 @@ dpaa2_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf) cfg.options &= ~DPNI_LINK_OPT_ASYM_PAUSE; break; default: - RTE_LOG(ERR, PMD, "Incorrect Flow control flag (%d)", + RTE_LOG(ERR, PMD, "Incorrect Flow control flag (%d)\n", fc_conf->mode); return -1; } ret = dpni_set_link_cfg(dpni, CMD_PRI_LOW, priv->token, &cfg); if (ret) - RTE_LOG(ERR, PMD, "Unable to set Link configuration (err=%d)", + RTE_LOG(ERR, PMD, + "Unable to set Link configuration (err=%d)\n", ret); /* Enable link */ -- 2.7.4 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH 0/8] NXP DPAA2 compilation and runtime fixes 2017-07-11 14:55 [dpdk-dev] [PATCH 0/8] NXP DPAA2 compilation and runtime fixes Hemant Agrawal ` (7 preceding siblings ...) 2017-07-11 14:55 ` [dpdk-dev] [PATCH 8/8] drivers: add newline in RTE LOG usages in dpaa2 Hemant Agrawal @ 2017-07-14 13:49 ` Thomas Monjalon 8 siblings, 0 replies; 10+ messages in thread From: Thomas Monjalon @ 2017-07-14 13:49 UTC (permalink / raw) To: Hemant Agrawal; +Cc: dev, ferruh.yigit, shreyansh.jain, akhil.goyal 11/07/2017 16:55, Hemant Agrawal: > This patch series add support for: > [1-2] GCC 7.1 compilation issue > [3-4] Compilation with all debug mode enabled > [5-7] Run time issues obseved over RC1 > [8] adding newline char in RTE_LOG > > Hemant Agrawal (8): > crypto/dpaa2_sec: remove GCC 7.1 compilation error > net/dpaa2: fix flow control switch case break > bus/fslmc: fixes compilation in debug mode > event/dpaa2: enable debug mode compilation > bus/fslmc: set the dpaa2 device name > bus/fslmc: align the object name log to real resource names > config: enable virtual IOVA by default for DPAA2 > drivers: add newline in RTE LOG usages in dpaa2 Applied, thanks ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-07-14 13:49 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-07-11 14:55 [dpdk-dev] [PATCH 0/8] NXP DPAA2 compilation and runtime fixes Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 1/8] crypto/dpaa2_sec: remove GCC 7.1 compilation error Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 2/8] net/dpaa2: fix flow control switch case break Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 3/8] bus/fslmc: fixes compilation in debug mode Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 4/8] event/dpaa2: enable debug mode compilation Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 5/8] bus/fslmc: set the dpaa2 device name Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 6/8] bus/fslmc: align the object name log to real resource names Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 7/8] config: enable virtual IOVA by default for DPAA2 Hemant Agrawal 2017-07-11 14:55 ` [dpdk-dev] [PATCH 8/8] drivers: add newline in RTE LOG usages in dpaa2 Hemant Agrawal 2017-07-14 13:49 ` [dpdk-dev] [PATCH 0/8] NXP DPAA2 compilation and runtime fixes Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).