From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <haifeng.lin@huawei.com>
Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [119.145.14.65])
 by dpdk.org (Postfix) with ESMTP id 283C69ACA
 for <dev@dpdk.org>; Tue, 24 Mar 2015 08:47:55 +0100 (CET)
Received: from 172.24.2.119 (EHLO szxeml425-hub.china.huawei.com)
 ([172.24.2.119])
 by szxrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued)
 with ESMTP id CIX01226; Tue, 24 Mar 2015 15:47:54 +0800 (CST)
Received: from [127.0.0.1] (10.177.19.115) by szxeml425-hub.china.huawei.com
 (10.82.67.180) with Microsoft SMTP Server id 14.3.158.1; Tue, 24 Mar 2015
 15:46:33 +0800
Message-ID: <55111658.9060707@huawei.com>
Date: Tue, 24 Mar 2015 15:46:32 +0800
From: Linhaifeng <haifeng.lin@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1;
 rv:31.0) Gecko/20100101 Thunderbird/31.1.0
MIME-Version: 1.0
To: "Xie, Huawei" <huawei.xie@intel.com>, "Ouyang, Changchun"
 <changchun.ouyang@intel.com>
References: <1426902420-21492-1-git-send-email-haifeng.lin@huawei.com>
 <F52918179C57134FAEC9EA62FA2F962511A6BEF6@shsmsx102.ccr.corp.intel.com>
 <C37D651A908B024F974696C65296B57B0F3F4851@SHSMSX101.ccr.corp.intel.com>
In-Reply-To: <C37D651A908B024F974696C65296B57B0F3F4851@SHSMSX101.ccr.corp.intel.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.19.115]
X-CFilter-Loop: Reflected
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] lib/librte_vhost: update used->idx when
 allocation of mbuf fails
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Mar 2015 07:47:57 -0000



On 2015/3/24 15:14, Xie, Huawei wrote:
> On 3/22/2015 8:08 PM, Ouyang, Changchun wrote:
>>
>>> -----Original Message-----
>>> From: linhaifeng [mailto:haifeng.lin@huawei.com]
>>> Sent: Saturday, March 21, 2015 9:47 AM
>>> To: dev@dpdk.org
>>> Cc: Ouyang, Changchun; Xie, Huawei
>>> Subject: [PATCH v3] lib/librte_vhost: update used->idx when allocation of
>>> mbuf fails
>>>
>>> From: Linhaifeng <haifeng.lin@huawei.com>
>>>
>>> When failed to malloc buffer from mempool we just update last_used_idx
>>> but not used->idx so after many times vhost thought have handle all packets
>>> but virtio_net thought vhost have not handle all packets and will not update
>>> avail->idx.
>>>
>>> Signed-off-by: Linhaifeng <haifeng.lin@huawei.com>
>> Acked-by: Changchun Ouyang <changchun.ouyang@intel.com>
>>
>>
>>
> Acked-by: Huawei Xie <huawei.xie@intel.com>
> 
> This patch fix the issue.
> Simple solution like other PMDs is before processing one descriptor,
> ensure allocation of new mbuf is successfull, and then immediately
> refill after receiving the packet from the descriptor.
> In future, we should consider optimized bulk allocation strategy with
> threshold.
> 

Hi, huawei

THis is patch is for librte_vhost.
Do you want to ack for the other patch for virtio-net-pmd?
> 
> 
> 
> 
> 

-- 
Regards,
Haifeng