From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <declan.doherty@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 4B36A569D
 for <dev@dpdk.org>; Thu, 26 Mar 2015 12:53:17 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga101.fm.intel.com with ESMTP; 26 Mar 2015 04:53:17 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,471,1422950400"; d="scan'208";a="670916665"
Received: from dwdohert-dpdk-fedora-20.ir.intel.com ([163.33.213.98])
 by orsmga001.jf.intel.com with ESMTP; 26 Mar 2015 04:53:15 -0700
Message-ID: <5513F424.1030403@intel.com>
Date: Thu, 26 Mar 2015 11:57:24 +0000
From: Declan Doherty <declan.doherty@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Thomas Monjalon <thomas.monjalon@6wind.com>, Jia Yu <jyu@vmware.com>
References: <1426196301-11138-1-git-send-email-jyu@vmware.com>
 <21300766.9euP7jPIpL@xps13>
In-Reply-To: <21300766.9euP7jPIpL@xps13>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] librte_pmd_bond: remove memory alloc for
	rte_pci_driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Mar 2015 11:53:17 -0000

On 23/03/15 11:31, Thomas Monjalon wrote:
> Declan,
> Any comment?
>
> 2015-03-12 14:38, Jia Yu:
>> eth_driver already contains rte_pci_driver data structure.
>> Allocating rte_pci_driver without referencing it after bond
>> creation causes memory leakage.
>
> Jia, Signed-off is missing.
>

Hey Thomas, I've been away for a few days but this looks fine, I'll ack 
the v2.

Declan