DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/3] bus/fslmc: cleanup unused firmware code
Date: Thu, 04 Apr 2019 23:43:24 +0200	[thread overview]
Message-ID: <5514293.kQscWdxMbc@xps> (raw)
In-Reply-To: <e9552992-7b6f-b56e-8c0d-772798019885@intel.com>

04/04/2019 23:29, Ferruh Yigit:
> On 4/4/2019 8:23 AM, Shreyansh Jain wrote:
> > Removes some unused firmware code which was added in last bump
> > of the firmware version. No current features uses these APIs.
> > 
> > Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> 
> <...>
> 
> > diff --git a/drivers/bus/fslmc/mc/fsl_dpci.h b/drivers/bus/fslmc/mc/fsl_dpci.h
> > index 9af9097e5..cf3d15267 100644
> > --- a/drivers/bus/fslmc/mc/fsl_dpci.h
> > +++ b/drivers/bus/fslmc/mc/fsl_dpci.h
> > @@ -108,27 +108,6 @@ int dpci_get_attributes(struct fsl_mc_io *mc_io,
> >  			uint16_t token,
> >  			struct dpci_attr *attr);
> >  
> > -/**
> > - * struct dpci_peer_attr - Structure representing the peer DPCI attributes
> > - * @peer_id:		DPCI peer id; if no peer is connected returns (-1)
> > - * @num_of_priorities:	The pper's number of receive priorities; determines the
> > - *			number of transmit priorities for the local DPCI object
> > - */
> > -struct dpci_peer_attr {
> > -	int peer_id;
> > -	uint8_t num_of_priorities;
> > -};
> > -
> > -int dpci_get_peer_attributes(struct fsl_mc_io *mc_io,
> > -			     uint32_t cmd_flags,
> > -			     uint16_t token,
> > -			     struct dpci_peer_attr *attr);
> > -
> > -int dpci_get_link_state(struct fsl_mc_io *mc_io,
> > -			uint32_t cmd_flags,
> > -			uint16_t token,
> > -			int *up);
> 
> These needs to be removed from .map file too.

Removed from master.
Thanks for the catch.

  parent reply	other threads:[~2019-04-04 21:43 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 14:23 [dpdk-dev] [PATCH 0/3] Update FSLMC bus firmware Shreyansh Jain
2019-04-03 14:23 ` Shreyansh Jain
2019-04-03 14:23 ` [dpdk-dev] [PATCH 1/3] bus/fslmc: cleanup unused firmware code Shreyansh Jain
2019-04-03 14:23   ` Shreyansh Jain
2019-04-03 14:23 ` [dpdk-dev] [PATCH 2/3] drivers: update MC firmware version for FSLMC bus Shreyansh Jain
2019-04-03 14:23   ` Shreyansh Jain
2019-04-03 14:23 ` [dpdk-dev] [PATCH 3/3] doc: bump SDK support version for dpaa2 Shreyansh Jain
2019-04-03 14:23   ` Shreyansh Jain
2019-04-04  7:23 ` [dpdk-dev] [PATCH v2 0/3] Update FSLMC bus firmware Shreyansh Jain
2019-04-04  7:23   ` Shreyansh Jain
2019-04-04  7:23   ` [dpdk-dev] [PATCH v2 1/3] bus/fslmc: cleanup unused firmware code Shreyansh Jain
2019-04-04  7:23     ` Shreyansh Jain
2019-04-04 21:29     ` Ferruh Yigit
2019-04-04 21:29       ` Ferruh Yigit
2019-04-04 21:43       ` Thomas Monjalon [this message]
2019-04-04 21:43         ` Thomas Monjalon
2019-04-05 11:19         ` Shreyansh Jain
2019-04-05 11:19           ` Shreyansh Jain
2019-04-05 11:37           ` Ferruh Yigit
2019-04-05 11:37             ` Ferruh Yigit
2019-04-05 11:38           ` Shreyansh Jain
2019-04-05 11:38             ` Shreyansh Jain
2019-04-05 12:35             ` Thomas Monjalon
2019-04-05 12:35               ` Thomas Monjalon
2019-04-05 12:58               ` Shreyansh Jain
2019-04-05 12:58                 ` Shreyansh Jain
2019-04-04  7:23   ` [dpdk-dev] [PATCH v2 2/3] drivers: update MC firmware version for FSLMC bus Shreyansh Jain
2019-04-04  7:23     ` Shreyansh Jain
2019-04-04  7:23   ` [dpdk-dev] [PATCH v2 3/3] doc: bump SDK support version for dpaa2 Shreyansh Jain
2019-04-04  7:23     ` Shreyansh Jain
2019-04-04 21:08   ` [dpdk-dev] [PATCH v2 0/3] Update FSLMC bus firmware Thomas Monjalon
2019-04-04 21:08     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5514293.kQscWdxMbc@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=shreyansh.jain@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).