From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <shreyansh.jain@nxp.com>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
(mail-bl2nam02on0053.outbound.protection.outlook.com [104.47.38.53])
by dpdk.org (Postfix) with ESMTP id 9502B937E
for <dev@dpdk.org>; Thu, 8 Sep 2016 07:49:28 +0200 (CEST)
Received: from BLUPR0301CA0035.namprd03.prod.outlook.com (10.162.113.173) by
MWHPR03MB2448.namprd03.prod.outlook.com (10.169.200.142) with Microsoft SMTP
Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id
15.1.609.9; Thu, 8 Sep 2016 05:49:27 +0000
Received: from BN1BFFO11FD021.protection.gbl (2a01:111:f400:7c10::1:199) by
BLUPR0301CA0035.outlook.office365.com (2a01:111:e400:5259::45) with Microsoft
SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384)
id 15.1.609.9 via Frontend Transport; Thu, 8 Sep 2016 05:49:26 +0000
Authentication-Results: spf=fail (sender IP is 192.88.168.50)
smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed)
header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com;
Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not
designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com;
client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net;
Received: from tx30smr01.am.freescale.net (192.88.168.50) by
BN1BFFO11FD021.mail.protection.outlook.com (10.58.144.84) with Microsoft SMTP
Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.587.6
via Frontend Transport; Thu, 8 Sep 2016 05:49:26 +0000
Received: from [10.232.14.87] ([10.232.14.87])
by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u885nNJO020103;
Wed, 7 Sep 2016 22:49:24 -0700
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com>
<1472219823-29486-1-git-send-email-shreyansh.jain@nxp.com>
<1472219823-29486-18-git-send-email-shreyansh.jain@nxp.com>
<57C46970.7020101@intel.com>
CC: <viktorin@rehivetech.com>, <david.marchand@6wind.com>,
<thomas.monjalon@6wind.com>, <hemant.agrawal@nxp.com>
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Message-ID: <55159319-3384-30a7-a71e-c0c3490d17a2@nxp.com>
Date: Thu, 8 Sep 2016 11:19:38 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <57C46970.7020101@intel.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-Matching-Connectors: 131177873668856477;
(91ab9b29-cfa4-454e-5278-08d120cd25b8); ()
X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI;
SFV:NSPM;
SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(3190300001)(339900001)(199003)(24454002)(189002)(377454003)(93886004)(87936001)(106466001)(230700001)(65806001)(65956001)(50466002)(64126003)(85426001)(31696002)(47776003)(77096005)(586003)(305945005)(105606002)(54356999)(76176999)(68736007)(86362001)(81166006)(8676002)(356003)(8936002)(2950100001)(97736004)(23746002)(36756003)(81156014)(8666005)(104016004)(4001350100001)(7846002)(5001770100001)(189998001)(50986999)(31686004)(11100500001)(83506001)(626004)(4326007)(33646002)(92566002)(2906002)(5660300001)(65826007)(19580395003)(19580405001)(7059030);
DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR03MB2448; H:tx30smr01.am.freescale.net;
FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en;
X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD021;
1:0tV36zZDrkXxU+sVmS3ZnnYuZkRgznYBX6tPACoU4xLNnAVbZtMo3khINbLf5L8yc70TuhXSVzFwtrEJi/pPPDOeajgTt+TuDufubC6umNRbzu3/nMPCy6BVyIxnLgZdboZlxIQYkMQ2KmzFoLw7uTXr4CoJN2VCUbeyez9CEDq7ZdTbjP2n43i7YImVGIuCSYsi4KmRz0dnYW3cVFzifShrWpjQJvblV9ODlbP8x1EKtKUNHdK7UHCwex06yInwWR9oSb6+oxyKonH5jP1Ws3Io1OQ4siBXFm9xw1FXM3ElRdpztF6mJdeBxVv2F7apUZSRrRmFR00k1zVF4K0aOGIj3bdMjuW4jj1ElOOQ+v0rXbP0f5JUEkyEiUvt5kaZmQvIWq3LCVIPEmpQBJrcl7RwluMuGbyxgPXJVdkM+VX6vO6dhQFXvG+CrxdwQGMI/Z8dNOXSTnFRvldygRS43PS9M8huTotFG6JWCN09NC7nA3vWEWkjK2XrrdOEOm9PHh5fT5C9V4HBznij5ghYBFsgA6gJZeeYUKb9INuMu0UhVw0CbC5HyJcSvD4KB/C48Gg9Ol9gHqrwQXfHO+90x7nmk+h4NV/YPHBQVnOTHVmjZu3OFX2MsccHdctmCwvEX+2H/yApWCcMVS/RZ5D6pQ==
X-MS-Office365-Filtering-Correlation-Id: a044667c-a0c4-45fd-5a9d-08d3d7abe4e3
X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2448;
2:Y48s7hY+yZFwpXOw7MNk/8Cd3zLzRsPCrGmQMOK3GdkSGML42vitJS6H0BsMNEYPxQxmAGF75zZFJBoZqQEvLfR64uzYjNuBULrnZ59DF/Z/LMXKFsREke2s8gsc03SnBUInvGkOzo1gW3d7UB3mmXVwvboDDg7ZH6RkTt9CC1z9eMrwvPiqj/SXiBm+S92n;
3:GmDp60RIecWVS0QD6tavsRhB/6tupfw+9ByBy3UFT8yrn6QRfdRiiYYIkGDPdravNg169WMMgRzLIgQXVfPcKkVKPYus3Bfl3QJzqq7XY/kLo6FbMDCUhFHf2Is5U5iBUm/+AZvipKfy9dm36BxVouuWIv5nY3K6NuIsjIRM/FwPxy5C9T6GJuuevrtMiJg8l3DPLbFSj+zu6p0A2UfQcESge72Qn1hoHecY409Alns=;
25:gOUvLSHOeWRY7WotPzL6+Q3qSohQJjsBoQcZPgj0LmlK8AZj7XUUv+ecHFMofwImp83WVVawL7LAtfV7wQcFo0EEaq1ELYCqbWngPRnZRluu+YfBQZwbUXbCIrhL9p/bKhMhNVmkPMsYqu2LgH0vo5Y6HZVsyQYEM065W+9QCDFfmUdraR5tsz3SpUpKb3YGoOm1ONf7JamII+h/uuAsQ23GJJyU2Vm7eK0SeTc9lYLFdKea9b8mb0dNU1esrCMaYEvD3bG083VTRD3PLd1G+Y2GARYkETrTelrE9Z/DxyCW3eZcwfyU0+y4rzsvCCEv9549yjGojGV0nIszPcyUjMDYnbJTDK4KfzvtaFp8YXsFyF5Bh7DNzKXfvaBSai0C3C6WpNFe7QTT9Zt65U37EMsiR65LFXEsqMIQyYTQw0o=
X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR03MB2448;
X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2448;
31:HSCGvTx4ivwAKTERLEGD1lsRpOwQjqFXl8mUECybNxgTFsYlszsRbOb3cmc2UyR9ba2lIGCCOpsWU4PVEKazKryqKf4/XDSNV+3NBcFcsMsujM5v0CSRJrkWl27TD8xVhxL09jLh3gXaRaUQQFLTx/yvE7m+eAUjYWqqWcwOZ70CrREGI8ypCcH82sllVGkxdmuQLMZL+zMxyMMNhK8zPBxEkEWSF7zuE437DDT+fGA=;
4:u/w2NOy/BEMRBOABviVKxitCCy4tNnzest6N7KXXi0oLFYZYLdwBEiffYFDOlX1OJ3FS5eDUHs5URfTFwdY+DbnezYT2gZ7FKZDZ/oyv//ocwoqYfplJQqI5lb6HqnTwmNTfzd9hfDqxWHHb663geb31GcwIATnhtFDaR0+cei2kk00s9zWDIZ8Xb5Z3YcxupximK8zgBJwl+dcGld30QiNuSTkQlZCfnwOXABvkpoqsSgaFWhTzP8tKIxDNS4w26PrI4qIZFXIvwORfGRq/pHJTX1LwRFF60shQmzhdnYCVBVqCwV5Mscc5vlyt71vvIg09AupdM7aGL0IsCpNbTGz2JE4koDDOfvnmSAVtDDmWGenaN9BAO/Zi8FCH2WdzCT+fXxj0uC8y6zGzLn8SmfADJQB2y6+8TUK0NcSmmLqTjYsubPo1DbEvaliSfdUuJjVBcDN7bsrBWNHUr15ix/HAsmhD5oRsYx7XXn1MgokgbrK1fUP6kygl1UlKZDBfBXaMSlBibgppC4EWm9/gCPi9DLjK2/9KBTbOr5FzIPQ=
X-Microsoft-Antispam-PRVS: <MWHPR03MB244805655BDA75168D8D84B790FB0@MWHPR03MB2448.namprd03.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(185117386973197);
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(6040176)(601004)(2401047)(13015025)(13017025)(13024025)(13018025)(13023025)(8121501046)(5005006)(3002001)(10201501046)(6055026);
SRVR:MWHPR03MB2448; BCL:0; PCL:0; RULEID:(400006); SRVR:MWHPR03MB2448;
X-Forefront-PRVS: 00594E8DBA
X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; MWHPR03MB2448;
23:IlWm7ebUvFP8pEeh2r/8hWI0bSCt2wm4BPTmu?=
=?Windows-1252?Q?fPTU6/gzCVoLwzTHTejQouYSPI3JuDeueX5ubKgtTHkyTdy58Ebq8ZKJ?=
=?Windows-1252?Q?PZLZRo+FTCfIQydjYN5pVBBdsLXcZxKcRQqs9xf7in7EbneD0NkPunRi?=
=?Windows-1252?Q?Vnw8HVAkk2OmnzbBY5va87BicNplMJgri6WhPYgECAO/zVEDmlBb93PW?=
=?Windows-1252?Q?cOZUOo893G8lmXaFDwvAyOAu7bfG3h1dWiNNAu/XwjOEsnWiW+8mI4Zc?=
=?Windows-1252?Q?EHyvPmQXYFAVespyl2CtHHFbXtp/w0MKZnhEabAtFCNErqy6QMfRhHLG?=
=?Windows-1252?Q?yTLA6LBjREo222UFVPBr24iD6MgYqR+0OCLLMoazVTCBWsPHsjphz1xC?=
=?Windows-1252?Q?4UdrgLsxvi6/YQpSiR4nfZcTl9FdFTEFp1a26Pbjb6/yJAR4eLYjiLQf?=
=?Windows-1252?Q?jmSFtPjMk4W0OxwFwaUnK+Bl/4jtA9gokAyUa7K8Ae8AAJiwdPyY1jC3?=
=?Windows-1252?Q?P18crT00yprjOHkEQQQAgeTBa3IoBsA50374D3iqMGKSHCR0sXXGv8Dm?=
=?Windows-1252?Q?sxlnnvMGvrqdeesT3QiaPf2XeQCHiV8eu+4hFKpnuEIARgty25+6URHr?=
=?Windows-1252?Q?RmAYcgtrJy75uYqCl/XIkQ9wH9b08q+RK0XFLQCTf32UQphf8dViN/KN?=
=?Windows-1252?Q?tQDctS+FEO3gR4jA6dd9m3QaDOjxcX2ItokX5TgvFhwQuinBZKePrW4i?=
=?Windows-1252?Q?P4jgbNV9UKHD9ujwm++0lr9cALzSvgLrpsX9GFriMqmdPug9vXmYL3Zg?=
=?Windows-1252?Q?WCMuKRZBvs5+FDPJ15QTTk3Ia9suvkxgG7pv932m77whqJbFdy87HpNH?=
=?Windows-1252?Q?pr9mPX58W/eAyDSHeV/w/l6cL9uoH6nEiE+j8tOgafbeuyGf5CSkveSG?=
=?Windows-1252?Q?6URfoJhEMBhtcHMvL6G2DJ6dlWUFfWxxjB+u5sn6ktPUp5cdYR3SRsSn?=
=?Windows-1252?Q?CX8admFkbBz1hZqxXxWfbSUU9EBcY/OIlzXowFRs/gvVWJRBib+vxlay?=
=?Windows-1252?Q?774MrXivPsmm9FrExmWVUDzwGsMnt0RRAMx3BBtQ6An++T+6712RHJxp?=
=?Windows-1252?Q?TS9uDc7c7OiffE9/HXUzayh8aP1Mb9O9NAqwRI8GkPoCmPnpjVNcP205?=
=?Windows-1252?Q?XTBRNvVO1xC3Sh8ma9+KeKws3dokIn6/TOLGv8Jga5/87sRQMOGEJCI8?=
=?Windows-1252?Q?ImWnHxq+o4Ejz9NAEgzVSPpVEaEkLcPFEeTRDtqCh+B4HWaxnI1xhywq?=
=?Windows-1252?Q?dZZAxB6e+jaQHT6HG+jjNvIFeNXN8TvKh/nSqie/dYD4YbQFL3n4zOCe?=
=?Windows-1252?Q?F7DJo0QhkrinvD0ALbaFkafqY0BS3TE1OyHhxj1PPwWOekFdrizMMXjB?=
=?Windows-1252?Q?L3jice03XDiiHYBoEYY4adG6wLjYM5/2/TBKliYfPhfn2Iq+ER2JC2D7?=
=?Windows-1252?Q?rFx3H2lHwVi97jMm+/ehecm+hkIVkeOSSq2JI7mmEN4DAC+TA=3D=3D?=
X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2448;
6:tlhz5NdkYcScdHIELBJXgU0ryeldUNTPXIab+O6VNsCjD2aK94Ja2vbHaYB00G4Su73fCvkwIHWqL0KLDum1ziuE8bcbe5RqUOjveD+mec0NHKqRQf3ZI9RLWqJBhW8nGlgjftgn85/LD27V60wi5RhJmDFRm0+wJSiJHCuu50SsoH6gjr9JSV8EFT7PpcI5+e2KNvPqTsGOxMEZ7KYvBGp6iR5utyE/giQcdTDCjpb7HF3SaTATdJxssuJ9Jl/RL01AuCiT9eXeKZIIGksZ80EUyJT5A0QT4+JnpJAhwE8=;
5:ZNpf8Of3UXhL42pnHVB0Dy6JuglfkNsepRerPLL8/fEQzAaIdVA1NrRDS6rDKnU+7tezuJ6v+0tDurbFm11OZLNZvO1IyaIN29cAR2Hvjl4uA+uxvc+xAlH4BoMsMCdaVSzIOftDE3KWWRK86kXgrHu9l/rNRzSq+OyeDD7Zicc=;
24:D4vPZZ5bVp8vg8pSzx3utwhvURvq+ohGfz6ekBcNcwOM/l7lEgF3MtN76YIyG5VurdVipR0w8PLNM3efyIuIaNeDO8XgX2/etYY5r/8u1co=;
7:f+ewZ9mfDdTtZn9NBHr8pECMBFH3bSBn5hTWtotDC8wlNRAu8SZb+Y9rN97PW4+PTxoAPk1rfGHBfgJ6BhJGF+SmUdVH70ag+xj0c1IMPeeSeAa0aB867oQSngoYu+Osj5SjWYS7wEvMIFJHVT5zohBRYevgJY2HE8gELpI4yBKyDBVDOvYYJP2CtnWs2yhrYfrS+mIjbMigZPG5mObxnIjEMLyqpLDKRRF+ashSLgsObTOLvzO4nmOjb2o1iHz5
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2016 05:49:26.6828 (UTC)
X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50];
Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2448
Subject: Re: [dpdk-dev] [PATCH v8 17/25] drivers: convert PMD_VDEV drivers
to use rte_vdev_driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Sep 2016 05:49:29 -0000
Hi Ferruh,
On Monday 29 August 2016 10:27 PM, Ferruh Yigit wrote:
> On 8/26/2016 2:56 PM, Shreyansh Jain wrote:
>> All PMD_VDEV drivers can now use rte_vdev_driver instead of the
>> rte_driver (which is embedded in the rte_vdev_driver).
>>
>> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>> ---
>
> ....
>
>> diff --git a/drivers/net/xenvirt/rte_eth_xenvirt.c b/drivers/net/xenvirt/rte_eth_xenvirt.c
>> index 6b15381..fa00e52 100644
>> --- a/drivers/net/xenvirt/rte_eth_xenvirt.c
>> +++ b/drivers/net/xenvirt/rte_eth_xenvirt.c
>> @@ -759,12 +759,14 @@ rte_pmd_xenvirt_devuninit(const char *name)
>> return 0;
>> }
>
> xenvirt missing header file rte_vdev.h:
>
> CC rte_eth_xenvirt.o
> ..../drivers/net/xenvirt/rte_eth_xenvirt.c:762:31: error: variable has
> incomplete type 'struct rte_vdev_driver'
> static struct rte_vdev_driver pmd_xenvirt_drv = {
I have updated this in v9. Compilation now seems OK.
(I missed compiling this before v8)
>
>
>>
>> -static struct rte_driver pmd_xenvirt_drv = {
>> - .type = PMD_VDEV,
>> - .init = rte_pmd_xenvirt_devinit,
>> - .uninit = rte_pmd_xenvirt_devuninit,
>> +static struct rte_vdev_driver pmd_xenvirt_drv = {
>> + .driver = {
>> + .type = PMD_VDEV,
>> + .init = rte_pmd_xenvirt_devinit,
>> + .uninit = rte_pmd_xenvirt_devuninit
>> + },
>> };
>>
>> -PMD_REGISTER_DRIVER(pmd_xenvirt_drv, eth_xenvirt);
>> +DRIVER_REGISTER_VDEV(eth_xenvirt, pmd_xenvirt_drv);
>> DRIVER_REGISTER_PARAM_STRING(eth_xenvirt,
>> "mac=<mac addr>");
>>
>
>
-
Shreyansh