From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BEAEA0503; Fri, 20 May 2022 09:06:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 690B142BB3; Fri, 20 May 2022 09:04:51 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 758AA42B86 for ; Fri, 20 May 2022 09:04:50 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id C53248B; Fri, 20 May 2022 10:04:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru C53248B DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1653030290; bh=goNCUJo0PtTiaKLmg88ii3shReIvFnLeRFwsaIT4QG4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=B+7lenP/X5F6krMvNTCT8fFkwwALMnIXlagxS9DdGh8AbmtV4GYzQH1+Why2a52oC WCdRNosTggvQLj+99cXnmzNXVb2VnhJEySHReZ74YbI38kKSTy9mtjbGJ33er2cSyD ttYeH3kApq50+DYyJ4p+pUtQIyydncwfpTRa6iog= Message-ID: <551648de-77f8-80e3-e6cb-af610a65c976@oktetlabs.ru> Date: Fri, 20 May 2022 10:04:49 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [RFC PATCH v2 0/5] Split driver specific commands out of testpmd Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: thomas@monjalon.net References: <20220513075718.18674-1-david.marchand@redhat.com> <20220518194649.1868574-1-david.marchand@redhat.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20220518194649.1868574-1-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/18/22 22:46, David Marchand wrote: > Hello, > > Following TB decision and recent discussions on the driver specific > commands in testpmd, here is a proposal on how the split could be done. > > For now, this series simply moves the testpmd code in the driver > directory. The driver specific testpmd code is still compiled as part of > testpmd compilation via a global meson testpmd_driver_sources list. I like the approach suggested in the RFC. It is simple and it makes absolutely clear who is responsible for corresponding testpmd code maintenance. > > TODO: > - ixgbe bypass commands in testpmd are "dead" code since switch to meson, > as the RTE_LIBRTE_IXGBE_BYPASS define is not set while compiling testpmd. > I am tempted to simply drop those, since no one complained about issue > for the last two years. For now, this series reinstates them. IMHO two years is sufficient period to say that it is unused and remove it. > > - this series keeps the command names as is. We could consolidate with a > clear prefix so that users directly know they are exerting a special > feature that makes no sense on other hw. > For this, I had in mind introducing a "driver" top level prefix, > where drivers would hook their specific stuff. For example: > testpmd> driver ixgbe set vf split drop (port_id) (vf_id) (on|off) Good idea and I think that it should be fixed in a separate follow up patches. > > - the documentation of those commands is left untouched, we should > probably move any existing doc into the driver documentation itself. > testpmd documentation could then have a generic > "Driver specific commands" section pointing at all other driver docs. Yes, it would be good to move documentation as well. > > Opinions? > >