DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Luca Boccassi <bluca@debian.org>,
	David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: fix support for plain bourne shell
Date: Fri, 19 Apr 2019 23:18:37 +0200	[thread overview]
Message-ID: <5524018.aJI2RBs9e0@xps> (raw)
In-Reply-To: <a0cc56fa80c190142f5376e01020da63fa62e3d5.camel@debian.org>

19/04/2019 14:42, Luca Boccassi:
> On Fri, 2019-04-19 at 13:04 +0100, Bruce Richardson wrote:
> > The pipefail option is not supported in /bin/sh, just in bash/ksh and
> > similar shells - which means it's there by default on most Linux
> > distros
> > but not on e.g. FreeBSD. Therefore we check for it's presence before
> > setting the option, and if it's missing, we upgrade verbosity level
> > if
> > needed to ensure we never hide any build failures.
> > 
> > Signed-off-by: Bruce Richardson <
> > bruce.richardson@intel.com
> > >
> > ---
> > This patch is a replacement for the previous patch: "fix support for
> > FreeBSD" [1], which was an incorrect/incomplete fix.
> > 
> > [1]
> > http://patches.dpdk.org/patch/52468/
> > 
> > ---
> >  devtools/test-meson-builds.sh | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> Acked-by: Luca Boccassi <bluca@debian.org>

Looks good.
Applied, thanks

  parent reply	other threads:[~2019-04-19 21:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-19 12:04 Bruce Richardson
2019-04-19 12:04 ` Bruce Richardson
2019-04-19 12:42 ` Luca Boccassi
2019-04-19 12:42   ` Luca Boccassi
2019-04-19 21:18   ` Thomas Monjalon [this message]
2019-04-19 21:18     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5524018.aJI2RBs9e0@xps \
    --to=thomas@monjalon.net \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).