DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Sridhar.V.Iyer" <sridhariyer@versa-networks.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Packet drops at lower tc transmit-rates.
Date: Tue, 12 Apr 2016 16:38:52 -0700	[thread overview]
Message-ID: <552ECCE7-B985-4E84-BBDD-A21AB1D5D3E1@versa-networks.com> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126479A0AF8@IRSMSX108.ger.corp.intel.com>

Hi Cristian,

Thanks for the response.

> 
> Another potential workaround could be to change the pipe TC credit update logic from straightforward re-initialization to a slightly more tuned strategy that, in some cases, keeps some of the existing credits, so that the existing credits are not completely lost but some of them (value capped to 1x MTU) are carried forward:
> 
> 	pipe->tc_credits[i] = (params->tc_credits_per_period[i] < MTU)?
> 		((pipe->tc_credits[i] % MTU) + params->tc_credits_per_period[i]) : 
> 		params->tc_credits_per_period[i];
> 
> This would give the chance to the pipe TC credits to accumulate and become greater than the MTU every few periods and a packet to be transmitted for this pipe TC. Of course, this strategy needs to be further developed.

This approach seemed to give the apparent rate closest to the configured rate, irrespective of the MTU, the packet size, or the min packet size. I’ll use the port->mtu to influence the tc_credits_per_period accumulation.

Is there any particular reason why a token bucket was not used for traffic classes?

Regards,
Sridhar

  reply	other threads:[~2016-04-12 23:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07 19:24 Sridhar.V.Iyer
2016-04-11 21:00 ` Dumitrescu, Cristian
2016-04-12 23:38   ` Sridhar.V.Iyer [this message]
2016-04-13  9:31     ` Dumitrescu, Cristian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552ECCE7-B985-4E84-BBDD-A21AB1D5D3E1@versa-networks.com \
    --to=sridhariyer@versa-networks.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).