From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.hunt@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id C30BD2A5E
 for <dev@dpdk.org>; Tue, 21 Feb 2017 12:50:10 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga104.jf.intel.com with ESMTP; 21 Feb 2017 03:50:09 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.35,189,1484035200"; d="scan'208";a="50725263"
Received: from dhunt5-mobl.ger.corp.intel.com (HELO [10.237.221.69])
 ([10.237.221.69])
 by orsmga002.jf.intel.com with ESMTP; 21 Feb 2017 03:50:08 -0800
To: dev@dpdk.org
References: <1485163480-156507-2-git-send-email-david.hunt@intel.com>
 <1487647073-129064-1-git-send-email-david.hunt@intel.com>
 <1487647073-129064-8-git-send-email-david.hunt@intel.com>
Cc: bruce.richardson@intel.com
From: "Hunt, David" <david.hunt@intel.com>
Message-ID: <552f9ce7-5f5b-925e-78ba-05c76672b8c9@intel.com>
Date: Tue, 21 Feb 2017 11:50:07 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <1487647073-129064-8-git-send-email-david.hunt@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v7 07/17] lib: apply symbol versioning to
	distibutor lib
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Feb 2017 11:50:11 -0000


On 21/2/2017 3:17 AM, David Hunt wrote:
> Note: LIBABIVER is also bumped up in the Makefile
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
>   lib/librte_distributor/rte_distributor.c           | 10 +++++++++-
>   lib/librte_distributor/rte_distributor_v20.c       | 10 ++++++++++
>   lib/librte_distributor/rte_distributor_version.map | 14 ++++++++++++++
>   3 files changed, 33 insertions(+), 1 deletion(-)
>
--snip--

The following is generated by checkpatch for this patch:

ERROR:SPACING: space required after that ',' (ctx:VxO)
#70: FILE: lib/librte_distributor/rte_distributor.c:105:
+BIND_DEFAULT_SYMBOL(rte_distributor_request_pkt,, 17.05);
                                                 ^

However, I also tried with a space:

ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#26: FILE: lib/librte_distributor/rte_distributor.c:105:
+BIND_DEFAULT_SYMBOL(rte_distributor_request_pkt, , 17.05);
                                                   ^
So in either case it seems it's not possible to make checkpatch happy.


Rgds,
Dave.