From: Thomas Monjalon <thomas@monjalon.net>
To: Shaiq Wani <shaiq.wani@intel.com>
Cc: bruce.richardson@intel.com, dev@dpdk.org,
Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>,
Cheng Jiang <honest.jiang@foxmail.com>,
Chengwen Feng <fengchengwen@huawei.com>
Subject: Re: [PATCH v2] doc: documentation update for idxd driver
Date: Tue, 19 Nov 2024 18:42:47 +0100 [thread overview]
Message-ID: <5538683.29KlJPOoH8@thomas> (raw)
In-Reply-To: <20241008065216.1135728-1-shaiq.wani@intel.com>
08/10/2024 08:52, Shaiq Wani:
> Added a note to avoid usage errors by end user.
>
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
>
> v2 - addressed review comments.
> ---
> --- a/app/test-dma-perf/config.ini
> +++ b/app/test-dma-perf/config.ini
> @@ -61,6 +61,9 @@
> ; If you do not specify a result file, one will be generated with the same name as the configuration
> ; file, with the addition of "_result.csv" at the end.
>
> +; Note: When using idxd device (Device 0b25) with vfio-pci driver, add queue_id (lcore_dma=lcore10@0000:00:04.2-q0)
> +; When using idxd device (Device 0b25) with kernel driver, add work_queue (lcore_dma=lcore4@wq0.0)
> +
> [case1]
> type=DMA_MEM_COPY
> mem_size=10
> diff --git a/doc/guides/tools/dmaperf.rst b/doc/guides/tools/dmaperf.rst
> index f68353b920..a689fa0baa 100644
> --- a/doc/guides/tools/dmaperf.rst
> +++ b/doc/guides/tools/dmaperf.rst
> @@ -104,6 +104,8 @@ Configuration Parameters
> .. note::
>
> The mapping of lcore to DMA must be one-to-one and cannot be duplicated.
> + When using idxd device (Device 0b25) with vfio-pci driver, add queue_id (lcore_dma=lcore10@0000:00:04.2-q0)
> + When using idxd device (Device 0b25) with kernel driver, add work_queue (lcore_dma=lcore4@wq0.0)
I suppose the double space is not needed.
Waiting for review from dma-perf maintainers.
prev parent reply other threads:[~2024-11-19 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 5:34 [PATCH] app/dma-perf: documentation update of DMA perf for idxd Shaiq Wani
2024-10-04 16:56 ` Bruce Richardson
2024-10-08 6:52 ` [PATCH v2] doc: documentation update for idxd driver Shaiq Wani
2024-11-19 17:42 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5538683.29KlJPOoH8@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=gmuthukrishn@marvell.com \
--cc=honest.jiang@foxmail.com \
--cc=shaiq.wani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).