From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 1D8F91B2BA for ; Mon, 30 Oct 2017 18:31:40 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP; 30 Oct 2017 10:31:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,320,1505804400"; d="scan'208";a="169060033" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.254]) ([10.241.225.254]) by fmsmga005.fm.intel.com with ESMTP; 30 Oct 2017 10:31:39 -0700 To: Gaetan Rivet , dev@dpdk.org References: <8492fe4cf1a8d6f15d389c9148e4942f1d060a40.1509381300.git.gaetan.rivet@6wind.com> <6d3b81d98b4d1b3754c616f71b293f2119d79bd1.1509381300.git.gaetan.rivet@6wind.com> From: Ferruh Yigit Message-ID: <553dd226-2572-eaa4-7531-aec36f4cc527@intel.com> Date: Mon, 30 Oct 2017 10:31:39 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <6d3b81d98b4d1b3754c616f71b293f2119d79bd1.1509381300.git.gaetan.rivet@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 2/2] eal: warn user that VFIO is disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 17:31:41 -0000 On 10/30/2017 9:36 AM, Gaetan Rivet wrote: > If VFIO is not compatible with the kernel used, print a soft warning to > the user if RTE_EAL_VFIO was still enabled in the configuration. > > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/linuxapp/eal/eal_vfio.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.h b/lib/librte_eal/linuxapp/eal/eal_vfio.h > index 766d004..fadd274 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_vfio.h > +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.h > @@ -183,6 +183,8 @@ int vfio_mp_sync_setup(void); > #define SOCKET_ERR 0xFF > > #define VFIO_PRESENT > +#else > +#pragma message("VFIO configured but not supported by this kernel, disabling.") There is a flaw here, but it seems it was already there, nothing coming for this patch. There is a RTE_KERNELDIR variable, to compile DPDK with a given kernel, instead of default one. I am using this a lot for kni and igb_uio. Default RTE_KERNELDIR is: RTE_KERNELDIR ?= /lib/modules/$(shell uname -r)/build For vfio case, it is not taking this variable into account and always using the default one, so RTE_KERNELDIR is broken here. > #endif /* kernel version */ > #endif /* RTE_EAL_VFIO */ > >