From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B51FAA00C2; Tue, 25 Jan 2022 13:56:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EBE1A429A3; Tue, 25 Jan 2022 13:56:45 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 0AF62429A3 for ; Tue, 25 Jan 2022 13:56:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643115404; x=1674651404; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=oYYK6AvUm+5GWXNPZ7UxocotjhplcH+U+NPO/CWPQHc=; b=PVdmT1ltO1WL6rJDauMPt8nreVtUhTUMWaZ857dcjAJkT/y9yOLyyvIM mtI0h6gYY4YkkZgQkdjOkxPV69vroXI4UVVEHiNlTm3OssQLm9YP6c/nm B/OUtembr2ANjkrRb1u0lqLo9K78T4G38RGRLJ2Aq5q65pi/UoorU+2lQ p3+oH6wQ6r/a1GY7oFnPAVHB8zLpaOINFkQ9hWwFvYsnSq3BTnqNjcOeQ 1eGUytCO1FZHGjGCZaYS6Md9NpDbzTVm/UlqC5bWvb3EMKlXeU3tokb6+ 3A3NaIFsYX3bbxSnM2zCf2gLk3wocD8cGAYxeNOMPlfLDsCS4A5B0dFw7 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10237"; a="226962329" X-IronPort-AV: E=Sophos;i="5.88,315,1635231600"; d="scan'208";a="226962329" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2022 04:56:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,315,1635231600"; d="scan'208";a="627918570" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga004.jf.intel.com with ESMTP; 25 Jan 2022 04:56:42 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 25 Jan 2022 04:56:42 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 25 Jan 2022 04:56:41 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 25 Jan 2022 04:56:41 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 25 Jan 2022 04:56:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F3nxv8sX9OMW4EL81wFIiN+NzdZeCqRG8Ca1KrZa5J9Q69pm2c+kPrvO83/NPZ8c2X14K8nI3djzclS57seFfx9ayqRp25K4Q5GfggulFRNLKnVMPDcAliqoHCN17sBK8UC6kY9x5Nt8MOkRZMrr1S7e6epdRjShD6lrUiFK6pBwX2mKnttulKfWtOZ6dAB+kYMMnCGIpbrYTc1TUlJhwf8OBKzEJugw9mXlxIHM8hDNwJxh0G5JbXt5ec+fZgPknRgnlIxkL+mywyl7lmVH9vMHJaefHMEE01L2yQhTpbkPMOTveJCFWJ9lVSV+7z7ZaRPwrw99nDfYlKUovCqrYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SEdY7MTW7ZAzmP0Z1kIAGpXbOeP1Y4kK4WpucqciTsA=; b=lU3lAGyB1zu5yqeqWku/3R/ETbMsio/jmf+haYJ3wguN5FgeWbNwU5HIN77zJ/qn2DcObW6zcfSeNsBLRU7d+nxMFKQ3jmPpAFbWdvN62d1VgbxZuVLflwiWsr8TcM7Ciss2kms6pDtywuLg1bRHKRLauDkshBvDDyztAplzd6ow7IbZWYcS6Yd3iGFOUu06VHgcIb7B16UhEbzJb3VzfWGLDxb3rm/s5fshUAa4+jd2FCwxvvTefD8ICX2V4qlCGtro19rAZaH8DMKwk0nekIXR/XjpUDsIuNI7IB9Jw1rBW6UtOMtEFHTt/h1SAo8h4ONpf/0XDynJ/I//NxMZMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) by PH7PR11MB5767.namprd11.prod.outlook.com (2603:10b6:510:13a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7; Tue, 25 Jan 2022 12:56:40 +0000 Received: from SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::5097:78f8:816f:f243]) by SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::5097:78f8:816f:f243%6]) with mapi id 15.20.4930.015; Tue, 25 Jan 2022 12:56:40 +0000 Message-ID: <553e64fe-fc14-31fe-cdc4-efa1785e6930@intel.com> Date: Tue, 25 Jan 2022 12:56:34 +0000 Content-Language: en-US To: Ajit Khaparde , Ray Kinsella CC: "Min Hu (Connor)" , dpdk-dev , =?UTF-8?Q?Morten_Br=c3=b8rup?= , Thomas Monjalon , Andrew Rybchenko , "Loftus, Ciara" References: <20220111115437.32855-1-humin29@huawei.com> <20220112111424.20594-1-humin29@huawei.com> <87h7a9p3a0.fsf@mdr78.vserver.site> From: Ferruh Yigit Subject: Re: [RFC v3] ethdev: introduce ethdev dump API X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0090.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::30) To SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d87c4db7-306b-4351-63e4-08d9e0022111 X-MS-TrafficTypeDiagnostic: PH7PR11MB5767:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NqfkJI48JRGrp3fcChKuUAPQ2I00rUH8KeGmDvu5vBoeNE6cqnEzG6pvEogxTP2lk7Zzx+YdM3C6XcgRWlPXqlMNtKRBrv2kT4eC18fR/xGnM8dZF3H6EfWRUoQwW0byu+i5LtXe2zlKXNcijeLSPW6l2wHA45h2Cvg/d5cUk6Id5jKCaMyjcnlry795TNe1xiRwBcDpvaYhgJeegAYJZb+V89zwo4WlUuCvBPbe4deC7EPwHE+E+GHWOwKUHgBz+dfW9eKTaUGtoFN1wgwPRo4WB7Y1V0eL1zbdH3p6GjvVhkrN5F0Bi7gguyrtmJbviD7YRVYDcErnU/ZsuLIH6+eNcJ58Li6560Z3N7/8joqzBOOogcrMaQOMBZR31Z9Dnwug00YsWX7f2lnsbx+9IMa4lOxwvLEsDQPwTrpWNQmHJ643NWO2WaCTuqthCNv8hkZky5+urEnk9sBwNSRXQCHsinJN4A2oxoYt2jVmLISuCghREm7av3+N8fqN+mxjO7M2TEMmD4Z9Vxfro4ofG5bvEBpxntv9Be8XW1UHEPLhEs+Mvb4CdhPUMJAobTjvcyjvy3l3t7dFTbz5xYfqwHFBKwhDnffgjLPzrjyCW1dsrhKYx4UxAhKhRCXK50aRfJPmbpujX50SJIClauR4bxNcwPxOeHDTJ2aZlMiaPK/zM2jG/rJYLnAb+P0TVBouJ1p8Be4b7z6prH8sBEc8yw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5005.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(54906003)(6666004)(6506007)(5660300002)(66556008)(107886003)(82960400001)(2906002)(6486002)(2616005)(26005)(36756003)(316002)(66476007)(53546011)(31696002)(110136005)(86362001)(38100700002)(508600001)(4326008)(31686004)(6512007)(8676002)(66946007)(44832011)(8936002)(186003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGxEbnVscWVLL3lRNVZrMEQvMkZzNFVCUUduWnZaTHRzeUJNV2xIQ2tzVWEw?= =?utf-8?B?TWJtMVNqT0drZmNCYStQQitjQXA0b0pGNkdRWmpLNk1jSDJLd0ttNlhmU3A2?= =?utf-8?B?OFdhQ1ZDV1J2YW1wQXBhM0tVYXBURS9aRTQ5elNhbm1XTDJRRC9BRU1DYm0w?= =?utf-8?B?QVVVQ0lEOGRYN1dZK1VVYklKVkZCYWpkclFzVGhkUklWVGxGTnRyY2V0V1p5?= =?utf-8?B?amtCWVZSM0I4aCtRNVZBVkUxWEZ1N2dJcmVDcUl2VEFMZ0pSZzJnc2JycGN0?= =?utf-8?B?S1Yxb3IzUEVVWmFUTUNndjZPVTR2eEFDZ0tBQWh6VmgvVmsyNDVaRmY3SW1N?= =?utf-8?B?NHBIbWVtcTZIUzJOS3dCYUZuMnJuQ1NZZERhdVlYMU9ab1Z3aDNUanNodXAw?= =?utf-8?B?RmE3Tk9LMk9zTEJOYVVqenVHSXNiWDVIbHlvMDZqVklhaGR4eDR6RCsvS2wv?= =?utf-8?B?alRsSVJkeGZvOGs5Vm1MdlBZaEFXVDZFWDRzeG5GZGY1QkljZ2Z2ZGlwbFlZ?= =?utf-8?B?RXh4dUZveFFGamRvV0s3VzZHKytoblRISTRHT2JDekZRcEtjQVA2RXpaR0Zz?= =?utf-8?B?YmtIdENLaFpDeUluR1l5aXMxTGl1TXhxYldCZ0tMbVZvL2g2UWVCK1hHRlVC?= =?utf-8?B?V21hVTFtOEFUNE1UWDV5WEk3MVY1dnVDbmpuNFd2NjVqWU5oeWZIWlZVZThB?= =?utf-8?B?MDVFWnR3VzlWcGtua0JBSlIyNEFSNmNoSzFVbEZWQlhXQS9NY2Zycys3VkpU?= =?utf-8?B?WVNGY3pTVWUxdmIvR21rdlpEZi9iNnhwZndNRytJQm00dlF2N1ZoZ3FwdEUw?= =?utf-8?B?MWdKRGJNWk8rMG5SYXlNSkRCUFJ4UXdJZlJIeGNmaG5YQ3J1a0pGL0JVNWUw?= =?utf-8?B?WTQxcklBRjFZTGs4UUF0U0ZEL0E4bjRjUDExTVBFZHppYi9YT0hiVWdnS2pW?= =?utf-8?B?dFFCMDNIOWZxMFJ0MVdUdmdYNi90dlZ4NXRhSkpZUEI2SWZyQUNhNHhPZWVI?= =?utf-8?B?U2tTMXQ5bVVReXJKQnltOW8xV3kvRy9LUVk0Zms0K25SRWVhT3V5RzV2TXNU?= =?utf-8?B?TWFWWHFObW1lb2FpRVo5VFYva0RBa005Z0QvWnVkTEFENFBIZ3V4LzRHUkZO?= =?utf-8?B?a2xEbkthNDdSV3pkNEJPSUg2NFd4NTc0SXBHa01hRkNpYW9tMFNQTmlrZVVv?= =?utf-8?B?ZG4xTXRXTkFWeWJSVXBrb0NIUUNzdXMvRllSQTUxMVh6N1IzbDNlT0JVbzRx?= =?utf-8?B?UEFULzhhNkozRkV6NWtVWFUxMkNjRURUbGg0RHNicC90c3B0OXBZT2FLa2gw?= =?utf-8?B?Sllqc3Q4aFJPRHhNdWIrWlJBVU91VmdsemxRNGZ1WWozUnMwYlpCVVJYK0N5?= =?utf-8?B?SDAzdDZvQm04VENZQ0VsOWU5YXhxbThQWS9EdUVYR2NCdXRnai9HR2srWFhB?= =?utf-8?B?WmxHY2ExSjRwWnl2LzYyMnFTdlV4NDlMais5Q3p5VXF1dU1zeC9SRW5abWVC?= =?utf-8?B?NE9Jb3FkclU5UWZKcXBDZFZSZGdSSE9sWlFFUlZRVlN3S3dsTTY0YWZvZmJN?= =?utf-8?B?Rm5NSG1mTUJvU3RUVDh3MTZ4bnRNdThYSGpjWjRQblpwZzhVeXJHVnNDVXRa?= =?utf-8?B?UEllQ0tVQ3Zsb0tiMm42djB4ZnBDd2lhOEhjMWJ6ZTdONnhUaE5SOUE4SXpM?= =?utf-8?B?djlyNGxlWUI1VU9XeEZ5RTJMVkJxU0VNVHd4dEgza1BiWnRTVmNNYzJXd2RZ?= =?utf-8?B?RU1QRHpIWUU2bG9STzIwV3VrcmpKR01yK1RZdEFJb0JZVVdEM1Z4U1lDOExI?= =?utf-8?B?M3lOWW0xRk1Ra2FnZFFadXFLSlRmT1N3T1dKS1JZZUJJSEJ4eGFiRzB4UHo3?= =?utf-8?B?UTc1R3Rzb1RhR1BIM3VHa2l3bFJJenZsRldWV25ORW5UMmwxNzRIUmEvUzh0?= =?utf-8?B?cHFMalFneDFVRzhMZXVuQVpJUlExc3pPemljYXZCZnlRNCtHRUVncjM2N3di?= =?utf-8?B?QkJvSVB0d2Zrc3pSdXFsd1h3QzJ3SytNd2Q2eWhKNkxNVk9EZzZUOGt1WGsy?= =?utf-8?B?RG9TejIwaTB3OUZsSVVYTk9vc1QzdDF0T2xxMm5ZZUk2QVhRVzBZZ2ZpUG8x?= =?utf-8?B?cWQ1bWRvUk1vbVUzam8rSDQvRDJRMzRGTDNKRUpINHc4bnhWTTd1ZDVyR2Mz?= =?utf-8?Q?Sa8Os4LMenxtIXlkC9zTES4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d87c4db7-306b-4351-63e4-08d9e0022111 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5005.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2022 12:56:40.1947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UP8JonWsCdNz77HrUxql629QC/cyz4EItvB8etr4AjZyu9t0xUM1OhtGaY9G2YS3pemhXqT7UOq4tJAeMsLLKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5767 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/18/2022 3:34 PM, Ajit Khaparde wrote: > On Wed, Jan 12, 2022 at 4:06 AM Ray Kinsella wrote: >> >> >> Min Hu (Connor) writes: >> >>> Added the ethdev dump API which provides functions for query private info >>> from device. There exists many private properties in different PMD drivers, >>> such as adapter state, Rx/Tx func algorithm in hns3 PMD. The information of >>> these properties is important for debug. As the information is private, >>> the new API is introduced. >>> >>> Signed-off-by: Min Hu (Connor) >>> Acked-by: Morten BrÞrup >>> --- >>> v3: >>> * fix comment. >>> * add rte_eth_dev_priv_dump to version.map file. >>> >>> v2: >>> * fix dump API name >>> * adjust description in doc. >>> --- >>> doc/guides/rel_notes/release_22_03.rst | 7 +++++++ >>> lib/ethdev/ethdev_driver.h | 17 +++++++++++++++++ >>> lib/ethdev/rte_ethdev.c | 15 +++++++++++++++ >>> lib/ethdev/rte_ethdev.h | 16 ++++++++++++++++ >>> lib/ethdev/version.map | 3 +++ >>> 5 files changed, 58 insertions(+) >>> >> >> Acked-by: Ray Kinsella > Acked-by: Ajit Khaparde I have a concern and this "private info", it can be useful for debug but still it will lead to a PMD specific applications, I wonder if some common information can be provided. Is there any list in your mind what can be part of this private info? Also why not use existing xstats or telemetry to get more data from the drivers? As synced with Ciara (cc'ed), she mentioned more information can be get via registering callbacks to ethdev.