From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cunming.liang@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id F223DFFA
 for <dev@dpdk.org>; Thu,  7 May 2015 08:29:56 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga101.jf.intel.com with ESMTP; 06 May 2015 23:29:56 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,383,1427785200"; d="scan'208";a="706522012"
Received: from shwdeisgchi017.ccr.corp.intel.com (HELO [10.239.66.47])
 ([10.239.66.47])
 by fmsmga001.fm.intel.com with ESMTP; 06 May 2015 23:29:55 -0700
Message-ID: <554B0662.6060409@intel.com>
Date: Thu, 07 May 2015 14:29:54 +0800
From: "Liang, Cunming" <cunming.liang@intel.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Stephen Hemminger <stephen@networkplumber.org>
References: <1425012976-10173-1-git-send-email-cunming.liang@intel.com>	<1430804386-28949-1-git-send-email-cunming.liang@intel.com>	<1430804386-28949-7-git-send-email-cunming.liang@intel.com>
 <20150505113842.586ec802@urahara>
In-Reply-To: <20150505113842.586ec802@urahara>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v7 06/10] eal/linux: add interrupt vectors
 handling on VFIO
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 07 May 2015 06:29:57 -0000



On 5/6/2015 2:38 AM, Stephen Hemminger wrote:
> On Tue,  5 May 2015 13:39:42 +0800
> Cunming Liang <cunming.liang@intel.com> wrote:
>
>> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
>> index aea1fb1..387f54c 100644
>> --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
>> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
>> @@ -308,6 +308,18 @@ pci_vfio_setup_interrupts(struct rte_pci_device *dev, int vfio_dev_fd)
>>   		case VFIO_PCI_MSIX_IRQ_INDEX:
>>   			internal_config.vfio_intr_mode = RTE_INTR_MODE_MSIX;
>>   			dev->intr_handle.type = RTE_INTR_HANDLE_VFIO_MSIX;
>> +			for (i = 0; i < RTE_MAX_RXTX_INTR_VEC_ID; i++) {
>> +				fd = eventfd(0, 0);
>> +				if (fd < 0) {
>> +
> You should pass EFD_NONBLOCK and EFD_CLOEXEC as flags to any eventfd's created
> internally.
[LCM] Agree, make sense.