From: Luca Vizzarro <Luca.Vizzarro@arm.com>
To: Nicholas Pratte <npratte@iol.unh.edu>,
juraj.linkes@pantheon.tech, dmarx@iol.unh.edu,
Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com,
probb@iol.unh.edu, jspewock@iol.unh.edu,
yoan.picchi@foss.arm.com
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] dts: Testbed And Node Configuration Split
Date: Mon, 18 Nov 2024 17:25:37 +0000 [thread overview]
Message-ID: <554ae4cc-bdc8-4538-8e91-c22028c200d9@arm.com> (raw)
In-Reply-To: <20240703145749.23416-2-npratte@iol.unh.edu>
This is a good change, but I'd like to review it once you adapt it to
the Pydantic-based config, as it may look quite different.
While we are splitting things I suggest to create two new source files
under `config` for each sections:
conf/
__init__.py # where Configurations stays and brings everything together
test_run.py # to hold the `test_run` and all the related models
node.py # as above but for `node`
This will hopefully make it easier to read.
Best,
Luca
prev parent reply other threads:[~2024-11-18 17:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 19:34 [PATCH v1] " Nicholas Pratte
2024-06-10 19:37 ` Nicholas Pratte
2024-06-14 18:32 ` Jeremy Spewock
2024-09-10 8:57 ` Juraj Linkeš
2024-06-14 18:27 ` Jeremy Spewock
2024-09-10 9:00 ` Juraj Linkeš
2024-07-03 14:57 ` [PATCH v2] " Nicholas Pratte
2024-07-16 14:11 ` Jeremy Spewock
2024-09-10 9:19 ` Juraj Linkeš
2024-11-18 17:25 ` Luca Vizzarro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554ae4cc-bdc8-4538-8e91-c22028c200d9@arm.com \
--to=luca.vizzarro@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=jspewock@iol.unh.edu \
--cc=juraj.linkes@pantheon.tech \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).