From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 59DEC45D39;
	Mon, 18 Nov 2024 18:25:41 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 44E3740290;
	Mon, 18 Nov 2024 18:25:41 +0100 (CET)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id 98A8B4025E
 for <dev@dpdk.org>; Mon, 18 Nov 2024 18:25:40 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0389F165C;
 Mon, 18 Nov 2024 09:26:10 -0800 (PST)
Received: from [192.168.50.107] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id
 DA6B53F6A8; Mon, 18 Nov 2024 09:25:38 -0800 (PST)
Message-ID: <554ae4cc-bdc8-4538-8e91-c22028c200d9@arm.com>
Date: Mon, 18 Nov 2024 17:25:37 +0000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] dts: Testbed And Node Configuration Split
Content-Language: en-GB
To: Nicholas Pratte <npratte@iol.unh.edu>, juraj.linkes@pantheon.tech,
 dmarx@iol.unh.edu, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com,
 probb@iol.unh.edu, jspewock@iol.unh.edu, yoan.picchi@foss.arm.com
Cc: dev@dpdk.org
References: <20240610193410.17968-2-npratte@iol.unh.edu>
 <20240703145749.23416-2-npratte@iol.unh.edu>
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
In-Reply-To: <20240703145749.23416-2-npratte@iol.unh.edu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

This is a good change, but I'd like to review it once you adapt it to 
the Pydantic-based config, as it may look quite different.

While we are splitting things I suggest to create two new source files 
under `config` for each sections:

   conf/
     __init__.py # where Configurations stays and brings everything together
     test_run.py # to hold the `test_run` and all the related models
     node.py     # as above but for `node`

This will hopefully make it easier to read.

Best,
Luca