From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 407C04C93 for ; Tue, 2 Oct 2018 15:27:10 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2018 06:27:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,332,1534834800"; d="scan'208";a="267770506" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by fmsmga005.fm.intel.com with ESMTP; 02 Oct 2018 06:27:08 -0700 To: Thomas Monjalon , Igor Ryzhov Cc: dev@dpdk.org References: <20180923191202.64896-1-iryzhov@nfware.com> <20180926162106.1129-1-iryzhov@nfware.com> <4313273.d4aErm0F2p@xps> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <554bb0ff-2aa6-6777-74d6-d6499657c54a@intel.com> Date: Tue, 2 Oct 2018 14:27:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4313273.d4aErm0F2p@xps> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] kni: dynamically allocate memory for each KNI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 13:27:10 -0000 On 10/2/2018 2:06 PM, Thomas Monjalon wrote: > Hi, > > 26/09/2018 18:21, Igor Ryzhov: >> Long time ago preallocation of memory for KNI was introduced in commit >> 0c6bc8e. It was done because of lack of ability to free previously >> allocated memzones, which led to memzone exhaustion. Currently memzones >> can be freed and this patch uses this ability for dynamic KNI memory >> allocation. >> >> Signed-off-by: Igor Ryzhov > > The patch does not apply on master. > Is there a dependency? There should not be a conflict, following commit already in tree is causing the conflict, I was resolving it myself when testing: Commit e716b639856c ("kni: fix crash with null name") Basically both do same thing: <<<<<<< IN REPO if (name == NULL || name[0] == '\0') return NULL; ======= if (!name || !name[0]) return NULL; >>>>>>> PATCH It seems Igor has a older version of the tree. It is OK to keep the check existing in the repo.