From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id CD8FBC3A6 for ; Mon, 11 May 2015 05:32:51 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 10 May 2015 20:32:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,404,1427785200"; d="scan'208";a="723782051" Received: from shwdeisgchi017.ccr.corp.intel.com (HELO [10.239.66.47]) ([10.239.66.47]) by fmsmga002.fm.intel.com with ESMTP; 10 May 2015 20:32:51 -0700 Message-ID: <555022E0.7080406@intel.com> Date: Mon, 11 May 2015 11:32:48 +0800 From: "Liang, Cunming" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Stephen Hemminger References: <1425012976-10173-1-git-send-email-cunming.liang@intel.com> <1430804386-28949-1-git-send-email-cunming.liang@intel.com> <1430804386-28949-3-git-send-email-cunming.liang@intel.com> <20150507195753.24518cfd@urahara> In-Reply-To: <20150507195753.24518cfd@urahara> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7 02/10] eal/linux: add rte_epoll_wait/ctl support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 May 2015 03:32:52 -0000 On 5/8/2015 10:57 AM, Stephen Hemminger wrote: > On Tue, 5 May 2015 13:39:38 +0800 > Cunming Liang wrote: > >> + else if (rc < 0) { >> + /* epoll_wait fail */ >> + RTE_LOG(ERR, EAL, "epoll_wait returns with fail %s\n", >> + strerror(errno)); > In real application there maybe other random signals. > Therefore the code should ignore and return for case of EWOULDBLOCK and EINTR [LCM] Thanks, you're right, when EINTR happens, shall continue epoll_wait instead of return. Per EWOULDBLOCK, seems epoll_wait won't return it, so I assume your mention is about epoll event read.