From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 7E3CE11C5
 for <dev@dpdk.org>; Wed, 13 May 2015 15:34:11 +0200 (CEST)
Received: by widdi4 with SMTP id di4so198895475wid.0
 for <dev@dpdk.org>; Wed, 13 May 2015 06:34:11 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:organization:user-agent
 :mime-version:to:cc:subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=08dQ3EDq0va5q0mLEOhDNTjIg1npIqCsD7Il/SbP0wU=;
 b=j8jqmx47ZcKh9GG1mA2b3Qlm7dhI55gY7xhA/v6BG9TzzyXqQ32r/gIqRiZ+zGXW6/
 hr41aT7VkIR+9x3KOpj4YDI4sn1gLU9a7G41Gq/wREZiUwkvM0MehDpzuELAEmv08uzx
 +BdmIQ+DkkP3ubyLkOWVHH3a07M6M/zHMVUEODqtgpCYcZeySI24tyP9R4+22MEfCF5v
 YVrCKEJ4rtcog0WQs/8WENUDhBibuDbxPHGaASeMIPzNebOSxnAgRgG3oL/BIdZgoSRF
 myQlX/RbB5o85Oo62kvLLkjzIXtlaDPpOR2wnKaFA4OnaUaZSLFmEan23SFIOLLnHkxv
 8GQA==
X-Gm-Message-State: ALoCoQkFZAano0LPBvwoT/fTHLj607f3xNfzzU7XoSAET8bN2zaffMXgvAJkUvc3WjFrvvct6jVo
X-Received: by 10.194.133.71 with SMTP id pa7mr40877299wjb.155.1431524051370; 
 Wed, 13 May 2015 06:34:11 -0700 (PDT)
Received: from [192.168.1.65] (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id n3sm8226647wix.1.2015.05.13.06.34.09
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 13 May 2015 06:34:10 -0700 (PDT)
Message-ID: <555352A7.6090408@6wind.com>
Date: Wed, 13 May 2015 15:33:27 +0200
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Organization: 6WIND
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Bruce Richardson <bruce.richardson@intel.com>
References: <1431012951-6423-1-git-send-email-bruce.richardson@intel.com>
 <1431450315-13179-1-git-send-email-bruce.richardson@intel.com>
 <555254E5.7050906@6wind.com> <20150513090109.GB12276@bricha3-MOBL3>
In-Reply-To: <20150513090109.GB12276@bricha3-MOBL3>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 00/19] Move PMDs to drivers directory
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 13 May 2015 13:34:11 -0000

2015-05-13 11:01, Bruce Richardson:
> On Tue, May 12, 2015 at 09:30:45PM +0200, Thomas Monjalon wrote:
>> 2015-05-12 19:04, Bruce Richardson:
>>>  drivers/e1000/e1000/e1000_hw.h                     | 1026 ++++
>>
>> As explained in a previous comment,
>> http://dpdk.org/ml/archives/dev/2015-May/017509.html
>> I think this path would be better:
>>    drivers/net/e1000/base/e1000_hw.h
> 
> Two reasons why I didn't create the "net" subfolder:
> 1. I initally forgot to consider it :-(
> 2. While we may at some future point have other device driver types, are we really
> needing to start categorising PMDs at this point?
> 
> As for the base driver part, I was viewing that as a something that should be
> a separate patch set, since it's unrelated to moving things to the drivers
> subdir.

I understand your points and I partially agree.
However, file moves may be perturbing because it change habits
and may complicate a bit the git history browsing.
So I think it's better to minimize such moves and do altogether.