* [dpdk-dev] [PATCH] net/mlx5: fix indirect action modify rollback
@ 2021-07-21 12:51 Dmitry Kozlyuk
2021-07-22 14:04 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Kozlyuk @ 2021-07-21 12:51 UTC (permalink / raw)
To: dev; +Cc: andreyv, stable, Matan Azrad, Shahaf Shuler, Viacheslav Ovsiienko
mlx5_ind_table_obj_modify() first references queues from the new list,
then applies the new list to HW. In case of apply failure the function
dereferenced queues from the old list, while it should be the new list.
Fixes: fa7ad49e96b5 ("net/mlx5: fix shared RSS action update")
Cc: andreyv@nvidia.com
Cc: stable@dpdk.org
Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
drivers/net/mlx5/mlx5_rxq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index 23685d7654..06545ebf68 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -2086,7 +2086,7 @@ mlx5_ind_table_obj_modify(struct rte_eth_dev *dev,
error:
err = rte_errno;
for (j = 0; j < i; j++)
- mlx5_rxq_release(dev, ind_tbl->queues[j]);
+ mlx5_rxq_release(dev, queues[j]);
rte_errno = err;
DRV_LOG(DEBUG, "Port %u cannot setup indirection table.",
dev->data->port_id);
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix indirect action modify rollback
2021-07-21 12:51 [dpdk-dev] [PATCH] net/mlx5: fix indirect action modify rollback Dmitry Kozlyuk
@ 2021-07-22 14:04 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2021-07-22 14:04 UTC (permalink / raw)
To: Dmitry Kozlyuk
Cc: dev, stable, andreyv, Matan Azrad, Shahaf Shuler, Viacheslav Ovsiienko
21/07/2021 14:51, Dmitry Kozlyuk:
> mlx5_ind_table_obj_modify() first references queues from the new list,
> then applies the new list to HW. In case of apply failure the function
> dereferenced queues from the old list, while it should be the new list.
>
> Fixes: fa7ad49e96b5 ("net/mlx5: fix shared RSS action update")
> Cc: andreyv@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-22 14:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21 12:51 [dpdk-dev] [PATCH] net/mlx5: fix indirect action modify rollback Dmitry Kozlyuk
2021-07-22 14:04 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).