From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 5A79F728B for ; Fri, 12 Jan 2018 00:46:25 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 97DAC20BDA; Thu, 11 Jan 2018 18:46:24 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 11 Jan 2018 18:46:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=E6FNwflKMkeWYf/rKW2oIxr7Ot 9Uvb801I06NJjXj9g=; b=OInQzhYDYxes5vBCx1DnktkVsaecNFkQajJ3XdZCtK Z85w2Ril4Js2PlHLeJCNiubDMc85PH4WzdsztkyRrpEsgzEXYp7OH6QY7q9D6BQz ITPzdq+HLEtFus9z5EVNOFbAtBpm0DxgwuwWqP5e/z3l11/G2Jh/Se2vDqxQgjhZ M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=E6FNwf lKMkeWYf/rKW2oIxr7Ot9Uvb801I06NJjXj9g=; b=WmnALQxg+XLjHKCA3lTXha 8wzSXD05xP03bZ5S5EEMHF/kmz1CR+dHHGcgDgfIPNI3J2bnXMz3BB04ARVx0G6S lVqu/bvqfhhwEbyh+8mQm6T4MP87r/3sEsMGXl6GxZIu40IURl4gAq0zgXgo2a2V aIdRzr9rV1f+Dfl73JMo8EJ7haJnYSeTg+vB79tOFCZxHT8TPvGNJl8+a8Epoi9g j3xYyjMDdF+HDbG3BJijqlUWcQJuuPZdENBNpN5X1ENY5lRmrp2KtHkDT2QFstRW ujXW5oLVx9PY1oFdsYMZ7tt4Z3wBWN5GGDbv/meIMol4iC1fAogcDzT18A2f2syw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6011F24718; Thu, 11 Jan 2018 18:46:24 -0500 (EST) From: Thomas Monjalon To: Jonas Pfefferle1 , anatoly.burakov@intel.com Cc: dev@dpdk.org Date: Fri, 12 Jan 2018 00:45:56 +0100 Message-ID: <5559040.Nhk1psZjz2@xps> In-Reply-To: References: <1509465586-7436-1-git-send-email-jpf@zurich.ibm.com> <3858523.3OloCCdIaW@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2018 23:46:25 -0000 07/11/2017 10:50, Jonas Pfefferle1: > Thomas Monjalon wrote on 11/07/2017 10:40:15 AM: > > > From: Thomas Monjalon > > To: Jonas Pfefferle1 , anatoly.burakov@intel.com > > Cc: dev@dpdk.org > > Date: 11/07/2017 10:40 AM > > Subject: Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling > > > > 07/11/2017 10:05, Jonas Pfefferle1: > > > Thomas Monjalon wrote on 11/06/2017 09:25:15 PM: > > > > > > > From: Thomas Monjalon > > > > To: Jonas Pfefferle , anatoly.burakov@intel.com > > > > Cc: dev@dpdk.org > > > > Date: 11/06/2017 09:55 PM > > > > Subject: Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling > > > > > > > > 31/10/2017 16:59, Jonas Pfefferle: > > > > > Check and report errors on open/read in noiommu check. > > > > > > > > > > Signed-off-by: Jonas Pfefferle > > > > > > > > I cannot decide to apply this patch as it does not explain what > > > > it is fixing, and as it is not reviewed. > > > > > > > > > > This patch adds error handling and logging to the noiommu check. > > > Also, on older kernels when the noiommu_enable file does not exist it > > > assumes noiommu is not enabled instead of returning -1. > > > Note that in rte_pci_get_iommu_class (drivers/bus/pci/linux/pci.c) > > > is the only usage of the function and it assumes return == 1: > > > noiommu is enabled any other return value noiommu disabled, i.e. > > > my code change does not change the behavior of this function. > > > We might want to check for errors in rte_pci_get_iommu_class > > > as well since assuming it is not enabled when we cannot open > > > and read it might lead to iova == VA being used even if noiommu is > > > enabled. > > > > > > All this comes back to what I proposed before: instead of > > > the noiommu and PPC64 check we should decide which iova mode > > > to use depending on the iommu types available. > > > The type should be already available at the point where we > > > decide on the iova type. > > > (iommu types supported is checked by vfio_get_container_fd) > > > > Is there something urgent for 17.11? > > Or can it be refined in 18.02? > > Nothing urgent. We can refine this for 18.02. > > > Anatoly, any thought? Anatoly, Jonas, how do you want to proceed with this patch?