From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 3AADDC314
 for <dev@dpdk.org>; Mon, 18 May 2015 15:57:01 +0200 (CEST)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10])
 by mail.droids-corp.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128)
 (Exim 4.80) (envelope-from <olivier.matz@6wind.com>)
 id 1YuLbh-0001RS-Ta; Mon, 18 May 2015 16:01:32 +0200
Message-ID: <5559EFAC.9010604@6wind.com>
Date: Mon, 18 May 2015 15:57:00 +0200
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.6.0
MIME-Version: 1.0
To: Bruce Richardson <bruce.richardson@intel.com>
References: <1431937081-20083-1-git-send-email-olivier.matz@6wind.com>
 <1431937081-20083-2-git-send-email-olivier.matz@6wind.com>
 <20150518135305.GA12176@bricha3-MOBL3>
In-Reply-To: <20150518135305.GA12176@bricha3-MOBL3>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/4] examples/bond: fix compilation with clang
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 18 May 2015 13:57:01 -0000

Hi Bruce,

On 05/18/2015 03:53 PM, Bruce Richardson wrote:
> On Mon, May 18, 2015 at 10:17:58AM +0200, Olivier Matz wrote:
>> Fix the following compilation error:
>>
>> examples/bond/main.c:717:1: error: control reaches end of
>>   non-void function [-Werror,-Wreturn-type]
>>
>> The prompt() function does not return anything, so fix its prototype
>> to be void.
>>
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Out of interest, what version of clang throws up this error?

$ clang --version
Debian clang version 3.5.0-10 (tags/RELEASE_350/final) (based on LLVM 3.5.0)
Target: x86_64-pc-linux-gnu
Thread model: posix

And by the way, the gcc version I used for the other patches of the
series:

$ gcc --version
gcc (Debian 4.9.2-10) 4.9.2


Regards,
Olivier

> 
> /Bruce
> 
>> ---
>>  examples/bond/main.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/examples/bond/main.c b/examples/bond/main.c
>> index e90dc1d..4622283 100644
>> --- a/examples/bond/main.c
>> +++ b/examples/bond/main.c
>> @@ -705,7 +705,7 @@ cmdline_parse_ctx_t main_ctx[] = {
>>  };
>>  
>>  /* prompt function, called from main on MASTER lcore */
>> -static void *prompt(__attribute__((unused)) void *arg1)
>> +static void prompt(__attribute__((unused)) void *arg1)
>>  {
>>  	struct cmdline *cl;
>>  
>> -- 
>> 2.1.4
>>