From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ernst.netinsight.se (ernst.netinsight.se [194.16.221.21]) by dpdk.org (Postfix) with SMTP id 8D9983237 for ; Wed, 27 May 2015 10:09:12 +0200 (CEST) Received: from [10.100.1.152] (unverified [10.100.1.152]) by ernst.netinsight.se (EMWAC SMTPRS 0.83) with SMTP id ; Wed, 27 May 2015 10:09:07 +0200 Message-ID: <55657BA4.5060305@netinsight.net> Date: Wed, 27 May 2015 10:09:08 +0200 From: =?UTF-8?B?U2ltb24gS8OlZ3N0csO2bQ==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: David Marchand References: <20150520142427.4b977210@miho> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] eal_common_options: Allow combining -m and --no-huge X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2015 08:09:12 -0000 Hi John and David! On 2015-05-27 09:29, Mcnamara, John wrote:> > Minor comments. > > * Without mem_parsed the () aren't required and the conditional will fit on one line. > > * The section prefix on the first/subject line should be "eal:" and the commit message/justification could be clearer. It would be worth doing a "git log" on the file and following the previous conventions for commit message on that component/file. OK, I'll fix these issues. On 2015-05-27 09:43, David Marchand wrote: > Well, I asked some question last time : > http://dpdk.org/ml/archives/dev/2015-March/015867.html > > This patch looks good but since I don't use this --no-huge that often, I > would like to know how you tested this. I used the pcap PMD driver with file input, basically ./test-dpdk --no-huge -m 1024 -l 0,1 -n3 --vdev 'eth_pcap0,rx_pcap=/tmp/eth-out.pcap,tx_pcap=/tmp/eth0.pcap' this patch allows me to run this as myself (i.e., not root) > And please, when resending a patch, it should be marked as vX. Sorry about that, I stashed it and forgot about it for a while, and then just re-made the commit. (Not only that: I lost the reply in the flood of DPDK mails, so sort of what I was complaining about in the first place!) Anyway, I'll update the patch and resend. // Simon