From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <marc.sune@bisdn.de>
Received: from mx.bisdn.de (mx.bisdn.de [185.27.182.31])
 by dpdk.org (Postfix) with ESMTP id 2C0F51396
 for <dev@dpdk.org>; Thu, 28 May 2015 10:52:02 +0200 (CEST)
Received: from [172.16.250.156] (unknown [172.16.250.156])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mx.bisdn.de (Postfix) with ESMTPSA id DB9C7A23F3
 for <dev@dpdk.org>; Thu, 28 May 2015 10:52:01 +0200 (CEST)
Message-ID: <5566D731.3030103@bisdn.de>
Date: Thu, 28 May 2015 10:52:01 +0200
From: Marc Sune <marc.sune@bisdn.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.6.0
MIME-Version: 1.0
To: dev@dpdk.org
References: <1432556634-9498-1-git-send-email-bruce.richardson@intel.com>
 <1432556634-9498-2-git-send-email-bruce.richardson@intel.com>
In-Reply-To: <1432556634-9498-2-git-send-email-bruce.richardson@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 1/2] eal: add missing include <stdio.h> to
 rte_pci.h
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 May 2015 08:52:02 -0000



On 25/05/15 14:23, Bruce Richardson wrote:
> rte_pci.h depends upon stdio.h for the definition of the FILE type. Add
> in #include <stdio.h> to the file to satisfy this dependency in cases
> where the including C file does not already include stdio.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>   lib/librte_eal/common/include/rte_pci.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h
> index 223d3cd..a346532 100644
> --- a/lib/librte_eal/common/include/rte_pci.h
> +++ b/lib/librte_eal/common/include/rte_pci.h
> @@ -74,6 +74,7 @@
>   extern "C" {
>   #endif
>   
> +#include <stdio.h>
>   #include <stdlib.h>
>   #include <limits.h>
>   #include <errno.h>

Acked-by: Marc Sune <marc.sune@bisdn.de>