From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <marc.sune@bisdn.de>
Received: from mx.bisdn.de (mx.bisdn.de [185.27.182.31])
 by dpdk.org (Postfix) with ESMTP id CBBAD3237
 for <dev@dpdk.org>; Thu, 28 May 2015 10:54:58 +0200 (CEST)
Received: from [172.16.250.156] (unknown [172.16.250.156])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mx.bisdn.de (Postfix) with ESMTPSA id 82CE2A23F3
 for <dev@dpdk.org>; Thu, 28 May 2015 10:54:58 +0200 (CEST)
Message-ID: <5566D7DF.4040707@bisdn.de>
Date: Thu, 28 May 2015 10:54:55 +0200
From: Marc Sune <marc.sune@bisdn.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.6.0
MIME-Version: 1.0
To: dev@dpdk.org
References: <1432556634-9498-1-git-send-email-bruce.richardson@intel.com>
 <1432556634-9498-3-git-send-email-bruce.richardson@intel.com>
In-Reply-To: <1432556634-9498-3-git-send-email-bruce.richardson@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 2/2] kni: add missing include dependencies
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 May 2015 08:54:59 -0000



On 25/05/15 14:23, Bruce Richardson wrote:
> The file rte_kni.h depends upon a number of other headers, some of which
> are missing from the #include lines. The following #includes are added:
>   * rte_memory.h - for the definition of phys_addr_t
>   * rte_mempool.h - for the definition of mempool struct and the mempool
>     create function.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>   lib/librte_kni/rte_kni.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h
> index 98edd72..44240fe 100644
> --- a/lib/librte_kni/rte_kni.h
> +++ b/lib/librte_kni/rte_kni.h
> @@ -47,6 +47,8 @@
>    */
>   
>   #include <rte_pci.h>
> +#include <rte_memory.h>
> +#include <rte_mempool.h>
>   
>   #include <exec-env/rte_kni_common.h>
>   

A fwd declaration of struct rte_mempool would be sufficient, but

Acked-by: Marc Sune <marc.sune@bisdn.de>