From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B45A745B63; Fri, 18 Oct 2024 03:09:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A0B040268; Fri, 18 Oct 2024 03:09:21 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id B37824021E for ; Fri, 18 Oct 2024 03:09:19 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4XV6540SjCzyR99; Fri, 18 Oct 2024 09:07:52 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id B4C7E1800F2; Fri, 18 Oct 2024 09:09:17 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 18 Oct 2024 09:09:17 +0800 Message-ID: <5566b273-5c42-4d11-968c-b52648ff4732@huawei.com> Date: Fri, 18 Oct 2024 09:09:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/6] refine argparse library From: fengchengwen To: , CC: , Stephen Hemminger References: <20240220131502.47510-1-fengchengwen@huawei.com> <20240318111838.16991-1-fengchengwen@huawei.com> <20241009123330.5ae1ac97@hermes.local> <13bb1302-9e94-4526-913e-5a51c94d68aa@huawei.com> Content-Language: en-US In-Reply-To: <13bb1302-9e94-4526-913e-5a51c94d68aa@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas and David, This patchset was already acked by Stephen. It missed in DPDK 24.07, hope merge in 24.11. Thanks On 2024/10/10 9:35, fengchengwen wrote: > Hi Thomas and David, > > Kindly ping for merge. > > On 2024/10/10 3:33, Stephen Hemminger wrote: >> On Mon, 18 Mar 2024 11:18:32 +0000 >> Chengwen Feng wrote: >> >>> I found a couple of issues when I revisited the argparse_autotest >>> output, so got this patchset. >>> >>> Chengwen Feng (6): >>> argparse: refine error message >>> argparse: remove dead code >>> argparse: replace flag enum with marco >>> argparse: fix argument flags operate as uint32 type >>> test/argparse: refine testcases >>> argparse: fix doc don't display two hyphens >>> >>> --- >>> v4: address Thomas's comment on 4/6 commit: >>> - remove unused macros TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK and >>> TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK. >>> v3: >>> - address Thomas's comment on 4/6 comit. >>> - add commit: fix doc don't display two hyphens. >>> v2: address David Marchand's comment: >>> - replace flag enum with marco. >>> - replace flag's hardcode with macro in test_argparse.c. >>> >>> app/test/test_argparse.c | 65 +++++++++++--------- >>> doc/guides/prog_guide/argparse_lib.rst | 47 +++++++------- >>> lib/argparse/rte_argparse.c | 61 +++++++++--------- >>> lib/argparse/rte_argparse.h | 85 ++++++++++++-------------- >>> 4 files changed, 127 insertions(+), 131 deletions(-) >> >> The verb refine is not usually used for edits to documents or software >> that probably is a translation issue. >> >> Series-acked-by: Stephen Hemminger > > Thank Stephen >