From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F898A04FA; Thu, 6 Feb 2020 01:48:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4BB3A1C214; Thu, 6 Feb 2020 01:48:19 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 21AEC1C0B5 for ; Thu, 6 Feb 2020 01:48:17 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A1A8D22085; Wed, 5 Feb 2020 19:48:13 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 05 Feb 2020 19:48:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=gSO0ZEkaHU/7a1H0KxNJe1rslGV0A6V9XTihzGcXy/U=; b=sx9PoIAyKQjX 3tNJ1qtv4+WCZkTIltPc6emr+jRHQLZsct9nspYc3piZtNLGvD0/nA34AFV+UmBC ZCBnv/v1R8Zf66B2Nf1wSDHa+5+6TxXZ61RDQVbAlwMaFCeJYVaaOyBmW1vOEdWu WTdEEKAk362WfXpLvUdcqzjI8cQTOOk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=gSO0ZEkaHU/7a1H0KxNJe1rslGV0A6V9XTihzGcXy /U=; b=UjWp6uPUkGh50Bn7OnoyRfA8u/BmqSWZhgejwCsMHTEgATABfEeVNIuis U69zjLXHEEIJHkh5foLghcHJ4G1bdpk7+zs+0Bk0EBT2fPVCpNfYvgB/A6frU+zy jZhBiyT4zUbNkvgwXefF8rnlSxvibnssUFi8CrQM6NXfLkVhn7vAKAKP/Om3+FVx uqhvO4QP77o6d2oRvOgMqxvvwE60qe2a7njs2iA1ARzZszP2YjnFCbHlQNMOh3zL xkI4oSBAlN6k4bzBpZUAyf9H79UUDq+i+5sBBOYeHOalZ/AFthoDRqYw9zSbkdFP dvXqlFxjMQRfaj5u+/N8MAs45iWkA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrhedvgddviecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6DDD63280062; Wed, 5 Feb 2020 19:48:12 -0500 (EST) From: Thomas Monjalon To: Marcin Smoczynski Cc: akhil.goyal@nxp.com, konstantin.ananyev@intel.com, roy.fan.zhang@intel.com, declan.doherty@intel.com, radu.nicolau@intel.com, pablo.de.lara.guarch@intel.com, dev@dpdk.org Date: Thu, 06 Feb 2020 01:48:11 +0100 Message-ID: <5567685.31tnzDBltd@xps> In-Reply-To: <20200204131258.17632-2-marcinx.smoczynski@intel.com> References: <20200128142220.16644-1-marcinx.smoczynski@intel.com> <20200204131258.17632-1-marcinx.smoczynski@intel.com> <20200204131258.17632-2-marcinx.smoczynski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 1/8] cryptodev: introduce cpu crypto support API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/02/2020 14:12, Marcin Smoczynski: > +/** > + * Converts portion of mbuf data into a vector representation. > + * Each segment will be represented as a separate entry in *vec* array. > + * Expects that provided *ofs* + *len* not to exceed mbuf's *pkt_len*. > + * @param mbuf > + * Pointer to the *rte_mbuf* object. > + * @param ofs > + * Offset within mbuf data to start with. > + * @param len > + * Length of data to represent. > + * @return > + * - number of successfully filled entries in *vec* array. > + * - negative number of elements in *vec* array required. > + */ > +__rte_experimental > +static inline int > +rte_crypto_mbuf_to_vec(const struct rte_mbuf *mb, uint32_t ofs, uint32_t len, > + struct rte_crypto_vec vec[], uint32_t num) The doxygen comment is incomplete. I workaround the miss with this change: - * @param mbuf + * @param mb * Pointer to the *rte_mbuf* object. * @param ofs * Offset within mbuf data to start with. * @param len * Length of data to represent. + * @param vec + * @param num Please complete vec and num descriptions.