From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 433552716 for ; Fri, 29 May 2015 11:33:59 +0200 (CEST) Received: by wgv5 with SMTP id 5so57602198wgv.1 for ; Fri, 29 May 2015 02:33:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=j1mxUhsKgLOLYD12rhYr2ocxumfSynrSplDvjzi7izs=; b=KsGigQQjHisgUzFD3aQH4+vl7MuOvhaXdVwvBpoIp6eIxbbnFIsb/gkBgEnQkdgYjU l2B2Hp0hqc3ToXWtecJ6kFe/ymvT5CdIKCp2oN9TewMXGLP7AxVzgLH+/K96FbmVNW8X RT3ZfNgS3EyWEH7iS+k5y5kPOuBs9cXt2QfhFknTXbEGii6guYdbT6yz5x3VuQN4xIYP 9RcgiBRe6YDJ8WMSpZeXhssgk3t+0Q1Fk9xiqMKv4ZPJ1RONlCtWZVN9YBBER7+zVuFp yuz9y1jCplEVAkJn2SrLVglLtmq4SVkl3H7JtLkJNq94FudPCOnF5P5swXYc1x5G+8rc Ha8g== X-Gm-Message-State: ALoCoQnF4RdoBGyv7lPPISjlJkMVnsiXYyYe02I/3R4BLu71Fo3dPYuGiR2pcgwj+aE3t/Kv87Ni X-Received: by 10.180.198.198 with SMTP id je6mr4707951wic.82.1432892039097; Fri, 29 May 2015 02:33:59 -0700 (PDT) Received: from [10.16.0.189] (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id be3sm2197515wib.21.2015.05.29.02.33.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 May 2015 02:33:58 -0700 (PDT) Message-ID: <55683282.8020306@6wind.com> Date: Fri, 29 May 2015 11:33:54 +0200 From: Ivan Boule User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Stephen Hemminger References: <1432825523-19006-1-git-send-email-ivan.boule@6wind.com> <20150528092142.7a4241ec@urahara> In-Reply-To: <20150528092142.7a4241ec@urahara> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/5] multicast address filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2015 09:33:59 -0000 On 05/28/2015 06:21 PM, Stephen Hemminger wrote: > On Thu, 28 May 2015 17:05:18 +0200 > Ivan Boule wrote: > >> Introduce PMD API to set the list of multicast MAC addresses filtered >> by a port. >> Implemented in the following PMDs: igb, igbvf, em, ixgbe, and ixgbevf. >> Implementation for physical PMDs i40e, i40evf, enic, and fm10k left >> to their respective maintainers. >> >> Ivan Boule (5): >> ethdev: add multicast address filtering >> app/testpmd: new command to add/remove multicast MAC addresses >> e1000: add multicast MAC address filtering >> ixgbe: add multicast MAC address filtering >> app/testpmd: fix reply to a multicast ICMP request >> >> app/test-pmd/cmdline.c | 52 ++++++++++++++ >> app/test-pmd/config.c | 142 ++++++++++++++++++++++++++++++++++++++ >> app/test-pmd/icmpecho.c | 65 +++++++++++++++-- >> app/test-pmd/testpmd.h | 6 ++ >> drivers/net/e1000/em_ethdev.c | 17 +++++ >> drivers/net/e1000/igb_ethdev.c | 18 +++++ >> drivers/net/ixgbe/ixgbe_ethdev.c | 32 +++++++++ >> lib/librte_ether/rte_ethdev.c | 17 +++++ >> lib/librte_ether/rte_ethdev.h | 26 +++++++ >> 9 files changed, 369 insertions(+), 6 deletions(-) >> > > Looks good, could you also add support for virtio and vmxnet3? > As for physical NICs (i40e, etc.) listed above, I let the maintainers of the remaining NICs where this function is relevant to implement and to test it. By the way, I supposed that Guest front-end vNICs were always in promiscuous mode by construction. Said differently: that all packets supplied "from the outside" to the Host vNIC back-end driver were systematically delivered to the Guest vNIC front-end, whatever their destination MAC address, VLAN id., etc. Did I missed something ?