From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cunming.liang@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id D94A05A35
 for <dev@dpdk.org>; Wed,  3 Jun 2015 09:16:38 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga101.fm.intel.com with ESMTP; 03 Jun 2015 00:16:34 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,545,1427785200"; d="scan'208";a="501972493"
Received: from shwdeisgchi017.ccr.corp.intel.com (HELO [10.239.66.47])
 ([10.239.66.47])
 by FMSMGA003.fm.intel.com with ESMTP; 03 Jun 2015 00:16:31 -0700
Message-ID: <556EA9D0.9000700@intel.com>
Date: Wed, 03 Jun 2015 15:16:32 +0800
From: "Liang, Cunming" <cunming.liang@intel.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Stephen Hemminger <shemming@brocade.com>
References: <1432889125-20255-1-git-send-email-cunming.liang@intel.com>	<1433228006-24661-1-git-send-email-cunming.liang@intel.com>	<1433228006-24661-3-git-send-email-cunming.liang@intel.com>
 <20150602092117.3a0b443a@urahara>
In-Reply-To: <20150602092117.3a0b443a@urahara>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, liang-min.wang@intel.com
Subject: Re: [dpdk-dev] [PATCH v10 02/13] eal/linux: add rte_epoll_wait/ctl
 support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Jun 2015 07:16:40 -0000



On 6/3/2015 12:21 AM, Stephen Hemminger wrote:
> On Tue,  2 Jun 2015 14:53:15 +0800
> Cunming Liang <cunming.liang@intel.com> wrote:
>
>> The patch adds 'rte_epoll_wait' and 'rte_epoll_ctl' for async event wakeup.
>> It defines 'struct rte_epoll_event' as the event param.
>> The 'op' uses the same enum as epoll_wait/ctl does.
>> The epoll event support to carry a raw user data and to register a callback which is exectuted during wakeup.
>>
>> Signed-off-by: Cunming Liang <cunming.liang@intel.com>
>
> Minor polish comments, not blockers.
>
>
>> +static inline int
>> +eal_init_tls_epfd(void)
>> +{
>> +	int pfd = epoll_create(255);
>> +	if (pfd < 0) {
>
> Kernel style checker wants blank line after declaration here.
>
> /
>> +int
>> +rte_epoll_ctl(int epfd, int op, int fd,
>> +	      struct rte_epoll_event *event);
>> +
>> +/**
>> + * The function returns the per thread epoll instance.
>> + *
>> + * @return
>> + *   epfd the epoll instance refered to.
> Spell check: 'refered' may be misspelled - perhaps 'referred'?
>
>
>
>> + */
>> +int
>> +rte_intr_tls_epfd(void);
Thanks Stephen, will fix the typo and send the cleanup patch.